Re: r249939+ not detecting ata trim

2013-04-27 Thread Steven Hartland
- Original Message - From: matt sendtom...@gmail.com To: freebsd-current@FreeBSD.org Sent: Saturday, April 27, 2013 10:00 PM Subject: r249939+ not detecting ata trim I had been updating/porting Steve Hartland's patches for zfs trim on mps for 8.3 stable. Trim was working fine for me

Re: r249939+ not detecting ata trim

2013-04-27 Thread Steven Hartland
- Original Message - From: Steven Hartland I had been updating/porting Steve Hartland's patches for zfs trim on mps for 8.3 stable. Trim was working fine for me before r249939. When I saw that this functionality was being added to current, I built world/kernel without the patches.

Re: r249939+ not detecting ata trim

2013-04-27 Thread matt
On 04/27/13 15:58, Steven Hartland wrote: If your controller doesn't support UNMAP then this will be the reason, however mps should support this. Could you confirm if previously you where seeing UNMAP as the reported delete_method? Regards Steve

Re: r249939+ not detecting ata trim

2013-04-27 Thread Steven Hartland
- Original Message - From: matt On 04/27/13 15:58, Steven Hartland wrote: If your controller doesn't support UNMAP then this will be the reason, however mps should support this. Could you confirm if previously you where seeing UNMAP as the reported delete_method? I am rebuilding

Re: r249939+ not detecting ata trim

2013-04-27 Thread matt
On 04/27/13 18:32, Steven Hartland wrote: FYI: Change only requires kernel, world would be identical, which should save you some time. Regards Steve And some untrimmed deletes! Thanks, with geom/cam/disk stuff I usually assume that it could affect userland out of caution. BTW...ata

Re: r249939+ not detecting ata trim

2013-04-27 Thread Steven Hartland
- Original Message - From: matt FYI: Change only requires kernel, world would be identical, which should save you some time. And some untrimmed deletes! Thanks, with geom/cam/disk stuff I usually assume that it could affect userland out of caution. BTW...ata identify is working

Re: r249939+ not detecting ata trim

2013-04-27 Thread matt
On 04/27/13 18:51, Steven Hartland wrote: - Original Message - From: matt FYI: Change only requires kernel, world would be identical, which should save you some time. And some untrimmed deletes! Thanks, with geom/cam/disk stuff I usually assume that it could affect userland out of

Re: r249939+ not detecting ata trim

2013-04-27 Thread Steven Hartland
- Original Message - From: matt sendtom...@gmail.com To: Steven Hartland kill...@multiplay.co.uk Cc: freebsd-current@FreeBSD.org Sent: Sunday, April 28, 2013 3:03 AM Subject: Re: r249939+ not detecting ata trim On 04/27/13 18:51, Steven Hartland wrote: - Original Message

Re: r249939+ not detecting ata trim

2013-04-27 Thread matt
On 04/27/13 19:13, Steven Hartland wrote: Thats correct, the mps controllers I have here announce UNMAP support for SATA disks that support TRIM and then do firmware translation on the commands sent from the OS before passing them to the disks. This is why I was expecting your controller to

Re: r249939+ not detecting ata trim

2013-04-27 Thread Steven Hartland
- Original Message - From: matt sendtom...@gmail.com Here are the delete methods: deleteflag: ATA_TRIM (2) = 1 da4: Delete methods: ATA_TRIM(*) deleteflag: ATA_TRIM (2) = 1 da3: Delete methods: ATA_TRIM(*) deleteflag: ATA_TRIM (2) = 1 Here is a truncated dmesg | fgrep mps mps0: LSI