Re: src/sys/dev/syscons/scvesactl.c broken

2000-10-09 Thread Poul-Henning Kamp


Are you sure your tree is entirely in sync ?

I can't reproduce your problem here with the NOTES/LINT kernel...

   Version 1.16 of src/sys/dev/syscons/scvesactl.c, removing
machine/console.h broke the kernel build for me. Attached is the
relevant log, and my kernel file. 

--
Poul-Henning Kamp   | UNIX since Zilog Zeus 3.20
[EMAIL PROTECTED] | TCP/IP since RFC 956
FreeBSD coreteam member | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: src/sys/dev/syscons/scvesactl.c broken

2000-10-09 Thread Doug Barton

Poul-Henning Kamp wrote:
 
 Are you sure your tree is entirely in sync ?

Yes... I've checked it several times. 
 
 I can't reproduce your problem here with the NOTES/LINT kernel...

The following patch got my kernel compiled and running, although I
can't say it's the right thing to do. I'll cvsup again and do a cvs
update -A just to double check, but I'm pretty sure that this is a good
tree, and it's happening for me on two different machines with similar
kernel confs. 

Doug

Index: scvesactl.c
===
RCS file: /usr/ncvs/src/sys/dev/syscons/scvesactl.c,v
retrieving revision 1.16
diff -u -r1.16 scvesactl.c
--- scvesactl.c 2000/10/08 21:33:54 1.16
+++ scvesactl.c 2000/10/09 06:37:05
@@ -35,6 +35,8 @@
 #include sys/conf.h
 #include sys/tty.h
 #include sys/kernel.h
+#include sys/fbio.h
+#include sys/consio.h
 
 #include machine/pc/vesa.h
 


 
Version 1.16 of src/sys/dev/syscons/scvesactl.c, removing
 machine/console.h broke the kernel build for me. Attached is the
 relevant log, and my kernel file.


-- 
"The dead cannot be seduced."
- Kai, "Lexx"

Do YOU Yahoo!?


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: src/sys/dev/syscons/scvesactl.c broken

2000-10-09 Thread Poul-Henning Kamp

In message [EMAIL PROTECTED], Doug Barton writes:
Poul-Henning Kamp wrote:
 
 Are you sure your tree is entirely in sync ?

   Yes... I've checked it several times. 
 
 I can't reproduce your problem here with the NOTES/LINT kernel...

OK, found it, two negative options in NOTES/LINT prevented a lot
of syscons code from being covered by NOTES/LINT.

I'll commit in a sec...

--
Poul-Henning Kamp   | UNIX since Zilog Zeus 3.20
[EMAIL PROTECTED] | TCP/IP since RFC 956
FreeBSD coreteam member | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message



Re: src/sys/dev/syscons/scvesactl.c broken

2000-10-09 Thread Doug Barton

Poul-Henning Kamp wrote:
 
 In message [EMAIL PROTECTED], Doug Barton writes:
 Poul-Henning Kamp wrote:
 
  Are you sure your tree is entirely in sync ?
 
Yes... I've checked it several times.
 
  I can't reproduce your problem here with the NOTES/LINT kernel...
 
 OK, found it, two negative options in NOTES/LINT prevented a lot
 of syscons code from being covered by NOTES/LINT.
 
 I'll commit in a sec...

Cool... you da man. :)

Doug
-- 
"The dead cannot be seduced."
- Kai, "Lexx"

Do YOU Yahoo!?


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message