Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-20 Thread Mark Millard
Glad to help. Going in another direction: What of stable/11 ? (And possibly stable/10 .) Changing the BROOKE kernel ABI in stable/11 is a no-no. Similarly for AIM. Is there a reason to prefer which context actually works correctly for 11.0 default builds for accessing pm_stats in pmap? My

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Justin Hibbits
My buildworld completed successfully, so it's been fixed in r308873/ r308874. Thanks for your testing. I often build just kernel, so wouldn't have seen the fallout until it was far too late. - Justin On Nov 19, 2016, at 10:22 PM, Mark Millard wrote: On 2016-Nov-16, at 8:33 PM, Justin

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Justin Hibbits
umastat doesn't even build right now anyway. I just tried: [chmeee@zhabar:pts/29]:~...tools/umastat> make echo umastat.full: /usr/lib/libc.a /usr/lib/libkvm.a >> .depend Warning: Object directory not changed from original /home/chmeee/ freebsd/head/tools/tools/umastat cc -O2 -pipe -g -MD

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Mark Millard
On 2016-Nov-16, at 8:33 PM, Justin Hibbits wrote: > *sigh* okay, thanks. I just tested, and vm/vm_page.h, and vm/vm.h can both > be removed from memstat_uma.c for it to compile. I'm kicking off a > buildworld myself now, too, and hope to have it ready to commit tomorrow

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Justin Hibbits
*sigh* okay, thanks. I just tested, and vm/vm_page.h, and vm/vm.h can both be removed from memstat_uma.c for it to compile. I'm kicking off a buildworld myself now, too, and hope to have it ready to commit tomorrow (takes a couple hours to buildworld on my G5). - Justin On Nov 19, 2016,

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Mark Millard
[Top post of bad news.] With the patch I get a different incomplete type used in libmemstat: struct md_page --- all_subdir_lib/libmemstat --- In file included from /usr/src/lib/libmemstat/memstat_uma.c:34:0: /usr/src/sys/vm/vm_page.h:144:17: error: field 'md' has incomplete type struct

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Justin Hibbits
On Nov 19, 2016 21:42, "Mark Millard" wrote: > > On 2016-Nov-19, at 7:36 PM, Mark Millard wrote: > > > On 2016-Nov-19, at 7:32 PM, Justin Hibbits wrote: > > > >> Sorry, I generated the diff from a different tree that wasn't synced to head (had the same change in both trees

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Mark Millard
On 2016-Nov-19, at 7:36 PM, Mark Millard wrote: > On 2016-Nov-19, at 7:32 PM, Justin Hibbits wrote: > >> Sorry, I generated the diff from a different tree that wasn't synced to head >> (had the same change in both trees originally). If that is the only problem, >> you can ignore it and try

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Mark Millard
On 2016-Nov-19, at 7:32 PM, Justin Hibbits wrote: > Sorry, I generated the diff from a different tree that wasn't synced to head > (had the same change in both trees originally). If that is the only problem, > you can ignore it and try the rest. I can generate another

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Justin Hibbits
Sorry, I generated the diff from a different tree that wasn't synced to head (had the same change in both trees originally). If that is the only problem, you can ignore it and try the rest. I can generate another diff later too. - Justin On Nov 19, 2016 21:27, "Mark Millard"

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Mark Millard
[Top post about patch issues.] Looking at the patch it seems to be designed for when #else was in use: > -#else > +#elif defined(BOOKE) but -r308817 already has the 2nd line (BOOKE). Your patch shows: > Index: sys/powerpc/include/pmap.h >

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Mark Millard
It may take a little bit but I'll try the patch. It looks like sys/powerpc/include/pmap.h from -r176700 from 2088-Mar-3 is when the BOOKE/E500 split started with the preprocessor use of AIM and #else . This predates PowerMac G5 support. This is definitely not new for the general structure on the

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Mark Millard
On 2016-Nov-19, at 6:31 PM, Justin Hibbits wrote: > On Sat, 19 Nov 2016 18:19:37 -0800 > Mark Millard wrote: > >>> Author: jhibbits >>> Date: Fri Nov 18 22:59:33 2016 >>> New Revision: 308817 >>> URL: https://svnweb.freebsd.org/changeset/base/308817 >>> >>> Log: >>> Fix buildworld >>> >>>

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Justin Hibbits
On Sat, 19 Nov 2016 18:36:39 -0800 Mark Millard wrote: > [Quick top post I'm afraid.] > > I think that I figured out why there is a problem even earlier > --that just did not stop the compiles. > > lib/libutil/kinfo_getallproc.c is built here as part of buildworld > (stage

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Mark Millard
[Quick top post I'm afraid.] I think that I figured out why there is a problem even earlier --that just did not stop the compiles. lib/libutil/kinfo_getallproc.c is built here as part of buildworld (stage 4.2 "building libraries" instead of buildkernel. It does not have the KERNCONF's AIM vs.

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Justin Hibbits
On Sat, 19 Nov 2016 18:19:37 -0800 Mark Millard wrote: > > Author: jhibbits > > Date: Fri Nov 18 22:59:33 2016 > > New Revision: 308817 > > URL: https://svnweb.freebsd.org/changeset/base/308817 > > > > Log: > > Fix buildworld > > > > Change the pv_tracked flag to an

Re: svn commit: r308817 - head/sys/powerpc/include [Still have pmap_t and struct pmap ppowerpc64 problems as of -r308860]

2016-11-19 Thread Mark Millard
> Author: jhibbits > Date: Fri Nov 18 22:59:33 2016 > New Revision: 308817 > URL: https://svnweb.freebsd.org/changeset/base/308817 > > Log: > Fix buildworld > > Change the pv_tracked flag to an int, just in case userspace decides to > include > this file and defines BOOKE. > >