Re: usb/234503 already committed, but needs modification to cover more devices

2019-01-26 Thread Mel Pilgrim

On 01/26/2019 01:24, Hans Petter Selasky wrote:

On 1/26/19 1:41 AM, Mel Pilgrim wrote:
A quirk for a USB flashdrive was added to head (r342657), but the 
modification was too narrow.  The quirk affects all of the devices

in the Chipfancier SLC family, not just the one specific device for
which the quirk was added.

I replied to usb/234503 about this, but as this is already in head,
 I'd like someone to act on it and modify the quirk to cover all of
the devices in the family before 12.0-R comes out (and hopefully
MFC to stable before 11.3 comes out).

As I wrote in the PR, I'm already running the patch in releng/11.2
in production.


It is not a problem to make a patch to ignore the idProduct field
when matching. Will you make a patch for usb_quirk.c ?


I can do up a patch, yes.

The subject file thus far is scsi_da.c, not usb_quirk.c?

I'm not sure how to make a quirk that is idProduct agnostic.  Is there 
documentation on this, or can you point me an example of such an entry?

___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"


Re: usb/234503 already committed, but needs modification to cover more devices

2019-01-26 Thread Hans Petter Selasky

On 1/26/19 1:41 AM, Mel Pilgrim wrote:
A quirk for a USB flashdrive was added to head (r342657), but the 
modification was too narrow.  The quirk affects all of the devices in 
the Chipfancier SLC family, not just the one specific device for which 
the quirk was added.


I replied to usb/234503 about this, but as this is already in head, I'd 
like someone to act on it and modify the quirk to cover all of the 
devices in the family before 12.0-R comes out (and hopefully MFC to 
stable before 11.3 comes out).


As I wrote in the PR, I'm already running the patch in releng/11.2 in 
production.


It is not a problem to make a patch to ignore the idProduct field when 
matching. Will you make a patch for usb_quirk.c ?


--HPS
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"