Re: world broken yet again

2001-05-17 Thread Sheldon Hearn



On 16 May 2001 20:47:05 EST, Michael Harnois wrote:

 cc -O2 -fno-strength-reduce -pipe -march=pentiumpro -DHAS_CGETENT -DENCRYPTION 
-DDES_ENCRYPTION -DAUTHENTICATION  -DSRA 
-I/usr/src/secure/lib/libtelnet/../../../crypto/telnet 
-I/usr/obj/usr/src/i386/usr/include -c 
/usr/src/secure/lib/libtelnet/../../../crypto/telnet/libtelnet/pk.c -o pk.o

You're not supposed to report errors with world and kernel if you're
using non-standard optimizations.  See /etc/defaults/make.conf:

# CFLAGS controls the compiler settings used when compiling C code.
# Note that optimization settings above -O (-O2, ...) are not recommended
# or supported for compiling the world or the kernel - please revert any
# nonstandard optimization settings to -O before submitting bug reports
# to the developers.

Ciao,
Sheldon.

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: world broken yet again

2001-05-17 Thread Michael Harnois

On Thu, 17 May 2001 11:17:10 +0200, Sheldon Hearn [EMAIL PROTECTED] said:

 You're not supposed to report errors with world and kernel if
 you're using non-standard optimizations.

Are you telling me this error had something to do with optimizations?

-- 
Michael D. Harnois[EMAIL PROTECTED]
Redeemer Lutheran Church  Washburn, Iowa 
 Everyone thinks of changing the world, 
  but no one thinks of changing himself. -- Leo Nikolaevich Tolstoy

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: world broken yet again

2001-05-17 Thread Will Andrews

On Thu, May 17, 2001 at 06:36:01AM -0500, Michael Harnois wrote:
 Are you telling me this error had something to do with optimizations?

No.  But they can affect compiles in bizarre ways (believe me, in the
four years that I've compiled world, I've seen several).

If you compile with optimizations, you need to be wary of any failed
buildworlds your machine gives.  If you are compiling a world that you
KNOW works, and optimizations give a problem, then you have a bona fide
optimization problem.  Sometimes it's correctable, sometimes not.

However, in this case, you ran into a bona fide breakage.  It was fixed
awhile ago, so re-cvsup and re-make world.  :)

-- 
wca

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: world broken yet again

2001-05-17 Thread Michael Harnois

On Thu, 17 May 2001 07:11:16 -0500, Will Andrews [EMAIL PROTECTED] said:

 On Thu, May 17, 2001 at 06:36:01AM -0500, Michael Harnois wrote:
 Are you telling me this error had something to do with
 optimizations?

 No. 

My point is that I knew that.

 However, in this case, you ran into a bona fide breakage. It was
 fixed awhile ago, so re-cvsup and re-make world. :)

I knew that too. However, it had not been fixed at the time I reported
the problem.

-- 
Michael D. Harnois[EMAIL PROTECTED]
Redeemer Lutheran Church  Washburn, Iowa 
 Everyone thinks of changing the world, 
  but no one thinks of changing himself. -- Leo Nikolaevich Tolstoy

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message



Re: world broken yet again

2001-05-16 Thread nnd

In article [EMAIL PROTECTED]
Michael Harnois [EMAIL PROTECTED] wrote:
 /usr/src/secure/lib/libtelnet/../../../crypto/telnet/libtelnet/pk.c: In function 
`getseed':
 /usr/src/secure/lib/libtelnet/../../../crypto/telnet/libtelnet/pk.c:146: `i' 
undeclared (first use in this function)
 /usr/src/secure/lib/libtelnet/../../../crypto/telnet/libtelnet/pk.c:146: (Each 
undeclared identifier is reported only once
 /usr/src/secure/lib/libtelnet/../../../crypto/telnet/libtelnet/pk.c:146: for each 
function it appears in.)
 /usr/src/secure/lib/libtelnet/../../../crypto/telnet/libtelnet/pk.c: In function 
`pk_encode':
 /usr/src/secure/lib/libtelnet/../../../crypto/telnet/libtelnet/pk.c:235: warning: 
passing arg 1 of `des_cbc_encrypt' from incompatible pointer type
 /usr/src/secure/lib/libtelnet/../../../crypto/telnet/libtelnet/pk.c:235: warning: 
passing arg 2 of `des_cbc_encrypt' from incompatible pointer type
 /usr/src/secure/lib/libtelnet/../../../crypto/telnet/libtelnet/pk.c: In function 
`pk_decode':
 /usr/src/secure/lib/libtelnet/../../../crypto/telnet/libtelnet/pk.c:272: warning: 
passing arg 1 of `des_cbc_encrypt' from incompatible pointer type
 /usr/src/secure/lib/libtelnet/../../../crypto/telnet/libtelnet/pk.c:272: warning: 
passing arg 2 of `des_cbc_encrypt' from incompatible pointer type
 *** Error code 1
 
 Stop in /usr/src/secure/lib/libtelnet.
 *** Error code 1
 

At least the 'i undeclared' error can be corrected by the next patch:

Index: src/crypto/telnet/libtelnet/pk.c
===
RCS file: /scratch/CVS/src/crypto/telnet/libtelnet/pk.c,v
retrieving revision 1.4
diff -b -u -r1.4 pk.c
--- src/crypto/telnet/libtelnet/pk.c2001/05/16 18:32:46 1.4
+++ src/crypto/telnet/libtelnet/pk.c2001/05/17 03:10:50
@@ -142,6 +142,7 @@
 seed[i] = (lrand48()  0xff);
 }
 #else
+   int i;
srandomdev();
for (i = 0; i  seedsize; i++) {
seed[i] = random()  0xff;

To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message