Re: SVN r296272 breaks virtualbox
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 03/ 1/16 05:29 PM, Michael Butler wrote: > The removal of "taskqueue_enqueue_fast" breaks the virtualbox > kmods: > > Mar 1 16:54:36 toshi kernel: vboxdrv: fAsync=0 offMin=0x914 > offMax=0x151c Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol > taskqueue_enqueue_fast undefined Mar 1 16:54:36 toshi kernel: > linker_load_file: Unsupported file type Mar 1 16:54:36 toshi > kernel: link_elf_obj: symbol taskqueue_enqueue_fast undefined Mar > 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type > Mar 1 16:54:36 toshi kernel: KLD vboxnetadp.ko: depends on > vboxnetflt - not available or version mismatch Mar 1 16:54:36 > toshi kernel: linker_load_file: Unsupported file type It should be fixed now (r409965). Jung-uk Kim -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQEcBAEBCAAGBQJW12mUAAoJEHyflib82/FGjCoIAI7SgVEn4KsODrF4/y/Aifp1 vw9jDQ9oGo7z3zRKk7C14/tLeS6Z+GjrfZldKOJBZHKoWLlzs9+WCpXmESez10Kj 0nR3dbk2RHAE0iHFqwz7jzzANGu/eZohsgQ44a7ZhZcnrlUchGLCIz3eZMQWctYz KFUHLewYbr0/nBn/HB5G/5LI/DEBvhlxgplfjOFyvjZXXeYWot3q2cUvhNUjWQMf B3iqXmeMQmQ4lHPA/GkIDpIUwhi0sSn8FoaaV+dF13MU023lBE//klcUn5GbYd4Y 4DkLzZJKy4gpfdKelkSU8GUAVERRKonxkROtRRvt9eioE8IpEcT2KDMkshEmXFU= =Fj+q -END PGP SIGNATURE- ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: SVN r296272 breaks virtualbox
On Wednesday, March 02, 2016 07:27:45 AM Kurt Jaeger wrote: > Hi! > > > > > The removal of "taskqueue_enqueue_fast" breaks the virtualbox kmods: > [...] > > Then the port needs to be patched? It's been using an API deprecated > > for the last 15 years. A simple s/taskqueue_enqueue_fast/taskqueue_enqueue/ > > will fix it. > > A patch is possible if a new __FreeBSD_version is created for that > API. Who can do that ? You don't need a new bump. taskqueue_enqueue has worked fine for a "fast" taskqueue since 700013, so you can use that version. OTOH, I would be surprised if VirtualBox worked on FreeBSD 6.x. -- John Baldwin ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: SVN r296272 breaks virtualbox
On Wednesday, March 02, 2016 07:06:26 AM Howard Su wrote: > On Tue, Mar 1, 2016 at 10:28 PM Kurt Jaeger wrote: > > > Hi! > > > > > > > The removal of "taskqueue_enqueue_fast" breaks the virtualbox kmods: > > [...] > > > Then the port needs to be patched? It's been using an API deprecated > > > for the last 15 years. A simple > > s/taskqueue_enqueue_fast/taskqueue_enqueue/ > > > will fix it. > > > > A patch is possible if a new __FreeBSD_version is created for that > > API. Who can do that ? > > > There is no version pump and it is not needed. r296272 didn't have any > behavior change. binary compatible is kept as well. Actually, I broke binary compat in HEAD as 11.0 hasn't shipped yet and 11.0 won't be released for a while yet. In this case I think ripping the band-aid off is fine, especially since the replacement API has been ready for such a long time (and goes back to 7.0). -- John Baldwin ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: SVN r296272 breaks virtualbox
On Tue, Mar 01, 2016, Michael Butler wrote:
> The removal of "taskqueue_enqueue_fast" breaks the virtualbox kmods:
>
> Mar 1 16:54:36 toshi kernel: vboxdrv: fAsync=0 offMin=0x914 offMax=0x151c
> Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol
> taskqueue_enqueue_fast undefined
> Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type
> Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol
> taskqueue_enqueue_fast undefined
> Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type
> Mar 1 16:54:36 toshi kernel: KLD vboxnetadp.ko: depends on vboxnetflt -
> not available or version mismatch
> Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type
Attached patch for emulators/virtualbox-ose and rebuilding
virtualbox-ose and virtualbox-ose-kmod fixed problem for me.
===
---
files/patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-VBoxNetFlt-freebsd.c.orig
2016-03-02 10:15:39.814893000 +0300
+++ files/patch-src-VBox-HostDrivers-VBoxNetFlt-freebsd-VBoxNetFlt-freebsd.c
2016-03-02 10:16:39.070847000 +0300
@@ -1,10 +1,5 @@
-Add VLAN trunking support to vboxnetflt
-
-See:
http://lists.freebsd.org/pipermail/freebsd-emulation/2012-April/009698.html
-See:
http://lists.freebsd.org/pipermail/freebsd-emulation/2013-May/010605.html
-Submitted by: Landon J Fuller
./src/VBox/HostDrivers/VBoxNetFlt/freebsd/VBoxNetFlt-freebsd.c.orig
2013-04-12 06:38:11.0 -0400
-+++ ./src/VBox/HostDrivers/VBoxNetFlt/freebsd/VBoxNetFlt-freebsd.c
2013-05-25 20:14:52.152180452 -0400
+--- src/VBox/HostDrivers/VBoxNetFlt/freebsd/VBoxNetFlt-freebsd.c.orig
2016-01-19 22:18:38.0 +0300
src/VBox/HostDrivers/VBoxNetFlt/freebsd/VBoxNetFlt-freebsd.c
2016-03-02 10:10:21.181922000 +0300
@@ -51,6 +51,7 @@
#include
#include
@@ -13,6 +8,24 @@
#include
#include
+@@ -369,7 +370,7 @@
+ mtx_lock_spin(&pThis->u.s.inq.ifq_mtx);
+ _IF_ENQUEUE(&pThis->u.s.inq, m);
+ mtx_unlock_spin(&pThis->u.s.inq.ifq_mtx);
+-taskqueue_enqueue_fast(taskqueue_fast, &pThis->u.s.tskin);
++taskqueue_enqueue(taskqueue_fast, &pThis->u.s.tskin);
+ }
+ /*
+ * Handle mbufs on the outgoing hook, frames going to the interface
+@@ -387,7 +388,7 @@
+ mtx_lock_spin(&pThis->u.s.outq.ifq_mtx);
+ _IF_ENQUEUE(&pThis->u.s.outq, m);
+ mtx_unlock_spin(&pThis->u.s.outq.ifq_mtx);
+-taskqueue_enqueue_fast(taskqueue_fast, &pThis->u.s.tskout);
++taskqueue_enqueue(taskqueue_fast, &pThis->u.s.tskout);
+ }
+ else
+ {
@@ -427,6 +428,8 @@
struct ifnet *ifp = pThis->u.s.ifp;
unsigned int cSegs = 0;
===
--
Regards, | "In theory there is no difference between theory
Vladimir Zakharov | and practice. In practice there is."- Yogi Berra
___
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: SVN r296272 breaks virtualbox
On Tue, Mar 1, 2016 at 10:28 PM Kurt Jaeger wrote: > Hi! > > > > > The removal of "taskqueue_enqueue_fast" breaks the virtualbox kmods: > [...] > > Then the port needs to be patched? It's been using an API deprecated > > for the last 15 years. A simple > s/taskqueue_enqueue_fast/taskqueue_enqueue/ > > will fix it. > > A patch is possible if a new __FreeBSD_version is created for that > API. Who can do that ? > There is no version pump and it is not needed. r296272 didn't have any behavior change. binary compatible is kept as well. And taskqueue_enqueue_fast should and is able to be replaced with taskqueue_enqueue long time ago.Blind replace taskqueue_enqueue_fast with taskqueue_enqueue is enough. -Howard > > -- > p...@opsec.eu+49 171 3101372 4 years to > go ! > ___ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org" > ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: SVN r296272 breaks virtualbox
Hi! > > > The removal of "taskqueue_enqueue_fast" breaks the virtualbox kmods: [...] > Then the port needs to be patched? It's been using an API deprecated > for the last 15 years. A simple s/taskqueue_enqueue_fast/taskqueue_enqueue/ > will fix it. A patch is possible if a new __FreeBSD_version is created for that API. Who can do that ? -- p...@opsec.eu+49 171 3101372 4 years to go ! ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: SVN r296272 breaks virtualbox
On 2/03/2016 9:29 AM, Michael Butler wrote: > The removal of "taskqueue_enqueue_fast" breaks the virtualbox kmods: > > Mar 1 16:54:36 toshi kernel: vboxdrv: fAsync=0 offMin=0x914 offMax=0x151c > Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol > taskqueue_enqueue_fast undefined > Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type > Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol > taskqueue_enqueue_fast undefined > Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type > Mar 1 16:54:36 toshi kernel: KLD vboxnetadp.ko: depends on vboxnetflt - > not available or version mismatch > Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type > > Michael > Please create a bugzilla issue to track this, including: * a link to this mailing list thread so the maintainers can see the suggestion by John. * An attachment containing a log with the errors observed * Reference/link to the commit that caused the regression * CC the committer of the base revision in question Attaching a patch to fix the issue will likely encourage it to be committed sooner, but is not compulsory ./koobs ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: SVN r296272 breaks virtualbox
On Wednesday, March 02, 2016 12:42:05 AM Ivan Klymenko wrote: > On Tue, 1 Mar 2016 17:29:37 -0500 > Michael Butler wrote: > > > The removal of "taskqueue_enqueue_fast" breaks the virtualbox kmods: > > > > Mar 1 16:54:36 toshi kernel: vboxdrv: fAsync=0 offMin=0x914 > > offMax=0x151c Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol > > taskqueue_enqueue_fast undefined > > Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type > > Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol > > taskqueue_enqueue_fast undefined > > Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type > > Mar 1 16:54:36 toshi kernel: KLD vboxnetadp.ko: depends on > > vboxnetflt - not available or version mismatch > > Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type > > > > Michael > > > > > +1 Then the port needs to be patched? It's been using an API deprecated for the last 15 years. A simple s/taskqueue_enqueue_fast/taskqueue_enqueue/ will fix it. -- John Baldwin ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
Re: SVN r296272 breaks virtualbox
On Tue, 1 Mar 2016 17:29:37 -0500 Michael Butler wrote: > The removal of "taskqueue_enqueue_fast" breaks the virtualbox kmods: > > Mar 1 16:54:36 toshi kernel: vboxdrv: fAsync=0 offMin=0x914 > offMax=0x151c Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol > taskqueue_enqueue_fast undefined > Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type > Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol > taskqueue_enqueue_fast undefined > Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type > Mar 1 16:54:36 toshi kernel: KLD vboxnetadp.ko: depends on > vboxnetflt - not available or version mismatch > Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type > > Michael > +1 ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
SVN r296272 breaks virtualbox
The removal of "taskqueue_enqueue_fast" breaks the virtualbox kmods: Mar 1 16:54:36 toshi kernel: vboxdrv: fAsync=0 offMin=0x914 offMax=0x151c Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol taskqueue_enqueue_fast undefined Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type Mar 1 16:54:36 toshi kernel: link_elf_obj: symbol taskqueue_enqueue_fast undefined Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type Mar 1 16:54:36 toshi kernel: KLD vboxnetadp.ko: depends on vboxnetflt - not available or version mismatch Mar 1 16:54:36 toshi kernel: linker_load_file: Unsupported file type Michael ___ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"
