Re: XOR pt. 2

2015-12-11 Thread NGie Cooper
On Fri, Dec 11, 2015 at 1:19 PM, Don Lewis wrote: > On 11 Dec, Michael McConville wrote: >> Note that IFCAP_HWCSUM has two bits set. Because of this, it doesn't XOR >> cleanly in the current if-else condition, but I'm not sure whether that >> was intended. I just wanted to pass this by people in c

Re: XOR pt. 2

2015-12-11 Thread Don Lewis
On 11 Dec, Michael McConville wrote: > Note that IFCAP_HWCSUM has two bits set. Because of this, it doesn't XOR > cleanly in the current if-else condition, but I'm not sure whether that > was intended. I just wanted to pass this by people in case it was a > logical bug. Yeah, the original code loo

XOR pt. 2

2015-12-11 Thread Michael McConville
Note that IFCAP_HWCSUM has two bits set. Because of this, it doesn't XOR cleanly in the current if-else condition, but I'm not sure whether that was intended. I just wanted to pass this by people in case it was a logical bug. --- dev/ixgb/if_ixgb.c.orig +++ dev/ixgb/if_ixgb.c @@ -599,10 +599,7 @@