fix for a bug that causes a panic in the udp_pcblist() sysctl

2002-06-21 Thread Maxime Henrion
Hi all, I just fixed a bug that has been hitting me everytime I do a sysctl -a since inp locking was committed. I would like to commit it as soon as possible, so I'd like it if someone could review it. Thanks, Maxime Index: udp_usrreq.c

Re: fix for a bug that causes a panic in the udp_pcblist() sysctl

2002-06-21 Thread Maxime Henrion
Maxime Henrion wrote: Hi all, I just fixed a bug that has been hitting me everytime I do a sysctl -a since inp locking was committed. BTW, this bug probably only arises when the security.bsd.see_other_uids sysctl is set to 0, otherwise the cr_canseesocket() call always succeeds. So

Re: fix for a bug that causes a panic in the udp_pcblist() sysctl

2002-06-21 Thread Jeffrey Hsu
Can you try this fix instead? It's based on a similar patch Jonathan Lemon sent to me for a similar spot in tcp_subr.c. Index: udp_usrreq.c === RCS file: /home/ncvs/src/sys/netinet/udp_usrreq.c,v retrieving revision 1.113 diff -u

Re: fix for a bug that causes a panic in the udp_pcblist() sysctl

2002-06-21 Thread Maxime Henrion
Jeffrey Hsu wrote: Can you try this fix instead? It's based on a similar patch Jonathan Lemon sent to me for a similar spot in tcp_subr.c. Well yes, this works too, since it produces the same code as with my fix. But yours is more beautiful. :-) Thanks, Maxime To Unsubscribe: send mail to

Re: fix for a bug that causes a panic in the udp_pcblist() sysctl

2002-06-21 Thread Terry Lambert
Maxime Henrion wrote: I just fixed a bug that has been hitting me everytime I do a sysctl -a since inp locking was committed. I would like to commit it as soon as possible, so I'd like it if someone could review it. Wow. Good catch. -- Terry To Unsubscribe: send mail to [EMAIL PROTECTED]