Re: pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc)
On Mon, Feb 04, 2002 at 07:06:54PM -0800, Kris Kennaway wrote: If you use the argument that one shouldn't set WARNS because a new compiler will cause the tree to break, then there's no point having it at all since that condition will always be true. The difference is _impending_. -- -- David ([EMAIL PROTECTED]) To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc)
On Tue, Feb 05, 2002 at 07:20:46AM -0800, David O'Brien wrote: On Mon, Feb 04, 2002 at 07:06:54PM -0800, Kris Kennaway wrote: If you use the argument that one shouldn't set WARNS because a new compiler will cause the tree to break, then there's no point having it at all since that condition will always be true. The difference is _impending_. EPARSE. Kris msg34142/pgp0.pgp Description: PGP signature
pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc)
On Sun, Feb 03, 2002 at 07:51:52AM -0800, Mark Murray wrote:
markm 2002/02/03 07:51:52 PST
Modified files:
lib/libpam Makefile.inc
Log:
Turn on fascist warning mode.
Revision ChangesPath
1.4 +3 -1 src/lib/libpam/Makefile.inc
This delta breaks buildworld. gcc(1) has a known bug-feature
of hiding some errors in standard system headers, making them
invisible without -I.
During buildworld, ${WORLDTMP}/usr/include is populated with
headers, and -I${WORLDTMP}/usr/include is added to CFLAGS,
and compile now can't survive the WARNS=4.
Try this to see the breakage:
cd /usr/src/lib/libpam/modules/pam_ssh
make cleandir
make DESTDIR=/
Please back it out.
Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
[EMAIL PROTECTED] Sunbay Software AG,
[EMAIL PROTECTED] FreeBSD committer,
+380.652.512.251Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to [EMAIL PROTECTED]
with unsubscribe freebsd-current in the body of the message
Re: pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc)
On Mon, Feb 04, 2002 at 03:30:32PM +0200, Ruslan Ermilov wrote: This delta breaks buildworld. gcc(1) has a known bug-feature of hiding some errors in standard system headers, making them invisible without -I. ... and compile now can't survive the WARNS=4. Not to mention there is ZERO way this code will pass WARNS=4 for GCC 3. Please Committers, do not try to WARNS code right now -- there just is no use. It will only get in the way later. Well, of course feel free to make the code changes, but PLEASE do not commit any stronger WARNS levels to Makefiles. To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc)
David O'Brien [EMAIL PROTECTED] writes: Not to mention there is ZERO way this code will pass WARNS=4 for GCC 3. Please Committers, do not try to WARNS code right now -- there just is no use. It will only get in the way later. Well, of course feel free to make the code changes, but PLEASE do not commit any stronger WARNS levels to Makefiles. Alternatively, developers working on WARNS could use a newer GCC from the ports collection. Best regards, Mike Barcroft To Unsubscribe: send mail to [EMAIL PROTECTED] with unsubscribe freebsd-current in the body of the message
Re: pam_ssh world breakage (was: Re: cvs commit: src/lib/libpam Makefile.inc)
On Mon, Feb 04, 2002 at 09:17:17AM -0800, David O'Brien wrote: On Mon, Feb 04, 2002 at 03:30:32PM +0200, Ruslan Ermilov wrote: This delta breaks buildworld. gcc(1) has a known bug-feature of hiding some errors in standard system headers, making them invisible without -I. ... and compile now can't survive the WARNS=4. Not to mention there is ZERO way this code will pass WARNS=4 for GCC 3. Please Committers, do not try to WARNS code right now -- there just is no use. It will only get in the way later. If a new compiler generates more warnings then we should temporarily disable the warnings when the compiler is imported by setting WARNS=0 in bsd.sys.mk. All of the Makefile.inc's which set a default WARNS value for a subdirectory use WARNS?= for this reason (so they can be globally overridden until someone goes through and fixes the new ones). If you use the argument that one shouldn't set WARNS because a new compiler will cause the tree to break, then there's no point having it at all since that condition will always be true. Kris msg34130/pgp0.pgp Description: PGP signature
