Re: pax(1) looping infinitely

2024-06-22 Thread Ganael Laplanche

On 6/22/24 08:19, Warner Losh wrote:


The last core team announced one.

But you can add Approved by: imp


Thanks Warner! I've just committed the change.

Have a nice week-end,
Best regards,

--
Ganael LAPLANCHE 
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac , http://www.FreeBSD.org



Re: pax(1) looping infinitely

2024-06-21 Thread Warner Losh
The last core team announced one.

But you can add Approved by: imp

Warner


On Sat, Jun 22, 2024, 12:16 AM Ganael Laplanche <
ganael.laplan...@martymac.org> wrote:

>
>
> On 6/21/24 23:41, Yuri Pankov wrote:
>
> > .mailmap
>
> Thanks Yuri!
>
> I cannot see any blanket approval for a ports committer modifying that
> file within the src repo.
>
> Can a src committer approve (or commit) the following change please ? :
>
> diff --git a/.mailmap b/.mailmap
> index 0d0231a3da68..3d33acc8d59a 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -16,3 +16,4 @@ Jose Luis Duran 
> 
>   Val Packett  
>   Piotr Paweł Stefaniak  
>   Sumit Saxena  
> +Ganael LAPLANCHE  
>
> Thanks in advance,
> Best regards,
>
> --
> Ganael LAPLANCHE 
> http://www.martymac.org | http://contribs.martymac.org
> FreeBSD: martymac , http://www.FreeBSD.org
>
>


Re: pax(1) looping infinitely

2024-06-21 Thread Ganael Laplanche




On 6/21/24 23:41, Yuri Pankov wrote:


.mailmap


Thanks Yuri!

I cannot see any blanket approval for a ports committer modifying that 
file within the src repo.


Can a src committer approve (or commit) the following change please ? :

diff --git a/.mailmap b/.mailmap
index 0d0231a3da68..3d33acc8d59a 100644
--- a/.mailmap
+++ b/.mailmap
@@ -16,3 +16,4 @@ Jose Luis Duran  


 Val Packett  
 Piotr Paweł Stefaniak  
 Sumit Saxena  
+Ganael LAPLANCHE  

Thanks in advance,
Best regards,

--
Ganael LAPLANCHE 
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac , http://www.FreeBSD.org



Re: pax(1) looping infinitely

2024-06-21 Thread Yuri Pankov
Ganael Laplanche wrote:
> 
> 
> Le 21/06/2024 à 18:58, Warner Losh a écrit :
> 
>> My apologies...  I didn't check, but. it's in your sig so I should
>> have. 
> 
> Hey, no pb :)
> 
>> There's a mapping file that can be updated for cases like this.
> 
> Hmmm, I could add my address there. Can you point me to that file, I
> can't find it in the source tree ?

mailmap




Re: pax(1) looping infinitely

2024-06-21 Thread Ganael Laplanche




Le 21/06/2024 à 18:58, Warner Losh a écrit :

My apologies...  I didn't check, but. it's in your sig so I should have. 



Hey, no pb :)


There's a mapping file that can be updated for cases like this.


Hmmm, I could add my address there. Can you point me to that file, I 
can't find it in the source tree ?


Cheers,

--
Ganael LAPLANCHE 
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac , http://www.FreeBSD.org



Re: pax(1) looping infinitely

2024-06-21 Thread Warner Losh
On Fri, Jun 21, 2024 at 10:55 AM Ganael Laplanche <
ganael.laplan...@martymac.org> wrote:

> On 6/21/24 18:44, Warner Losh wrote:
>
> Hi Warner,
>
> > Fixed.
>  >
> > commit 681fd2bed8eaba88693867ba928a1c03a5b152cc (HEAD -> main)
> > Author: Ganael Laplanche 
> Thanks!
>
> > Wrote the commit message and had to guess at the right email to use. But
> > it looked like bz and the mail here were the same.
>
> You could just have used my FreeBSD.org (martymac@) address here.
> Anyway, my personal address is OK too :)
>

My apologies...  I didn't check, but. it's in your sig so I should have.


There's a mapping file that can be updated for cases like this.


> > In the future, simple patches like this might work better as a github
> > pull request, though, since that would resolve all that ambiguity.
>
> Yep, thanks again!
>

You Bet. IT was an easy one to work with since the patch applied cleanly,
it clearly fixed the problem, (which I was able to reproduce and verify
things
were fixed), etc.

Warner


> Cheers,


> --

Ganael LAPLANCHE 

http://www.martymac.org | http://contribs.martymac.org

FreeBSD: martymac , http://www.FreeBSD.org


Re: pax(1) looping infinitely

2024-06-21 Thread Ganael Laplanche

On 6/21/24 18:44, Warner Losh wrote:

Hi Warner,


Fixed.

>

commit 681fd2bed8eaba88693867ba928a1c03a5b152cc (HEAD -> main)
Author: Ganael Laplanche 

Thanks!

Wrote the commit message and had to guess at the right email to use. But 
it looked like bz and the mail here were the same.


You could just have used my FreeBSD.org (martymac@) address here. 
Anyway, my personal address is OK too :)


In the future, simple patches like this might work better as a github 
pull request, though, since that would resolve all that ambiguity.


Yep, thanks again!

Cheers,

--
Ganael LAPLANCHE 
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac , http://www.FreeBSD.org



Re: pax(1) looping infinitely

2024-06-21 Thread Warner Losh
Fixed.

commit 681fd2bed8eaba88693867ba928a1c03a5b152cc (HEAD -> main)
Author: Ganael Laplanche 
Date:   Fri Jun 21 10:39:09 2024 -0600

pax: Terminate loop for empty directory names
..

Wrote the commit message and had to guess at the right email to use. But it
looked like bz and the mail here were the same.

In the future, simple patches like this might work better as a github pull
request, though, since that would resolve all that ambiguity.

Warner


On Fri, Jun 21, 2024 at 4:51 AM Ganael Laplanche <
ganael.laplan...@martymac.org> wrote:

> Hello,
>
> Our pax(1) implementation has a small bug triggered when it is fed with
> a directory containing a trailing slash.
>
> Could a src committer have a look at:
>
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277060
>
> ?
>
> I've submitted a small patch that fixes the problem.
>
> Thanks!
>
> Cheers,
>
> --
> Ganael LAPLANCHE 
> http://www.martymac.org | http://contribs.martymac.org
> FreeBSD: martymac , http://www.FreeBSD.org
>
>


pax(1) looping infinitely

2024-06-21 Thread Ganael Laplanche

Hello,

Our pax(1) implementation has a small bug triggered when it is fed with 
a directory containing a trailing slash.


Could a src committer have a look at:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277060

?

I've submitted a small patch that fixes the problem.

Thanks!

Cheers,

--
Ganael LAPLANCHE 
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac , http://www.FreeBSD.org