Re: New USB stack and Zero copy.

2007-07-06 Thread Hans Petter Selasky
On Friday 06 July 2007 01:35, John Baldwin wrote: On Thursday 05 July 2007 04:25:17 pm John Baldwin wrote: On Thursday 05 July 2007 03:31:59 am Hans Petter Selasky wrote: On Wednesday 04 July 2007 19:35, John-Mark Gurney wrote: Hans Petter Selasky wrote this message on Wed, Jul 04, 2007

Re: add closefrom() call

2007-07-06 Thread LI Xin
Hi, Joerg Sonnenberger wrote: On Wed, Jul 04, 2007 at 08:27:49PM -0400, Ighighi Ighighi wrote: The closefrom() call, available in Solaris, is present in NetBSD since version 3.0. It is implemented with the F_CLOSEM fcntl() available since version 2.0. You could also add a system call like

Re: add closefrom() call

2007-07-06 Thread Ed Schouten
* LI Xin [EMAIL PROTECTED] wrote: Here is my implementation for FreeBSD. Some difference between my and DragonFly's implementation: - closefrom(-1) would be no-op on DragonFly, my version would close all open files (From my understanding of OpenSolaris's userland implementation, this is

Re: add closefrom() call

2007-07-06 Thread Ighighi Ighighi
LI Xin delphij at delphij.net wrote: Here is my implementation for FreeBSD. Some difference between my and DragonFly's implementation: - closefrom(-1) would be no-op on DragonFly, my version would close all open files (From my understanding of OpenSolaris's userland implementation, this is

Re: add closefrom() call

2007-07-06 Thread Joerg Sonnenberger
On Fri, Jul 06, 2007 at 12:50:17PM +0100, Robert Watson wrote: Solaris side-steps this issue by simply auditing the individual close() system calls. My preference would be that we implement this in user space also, which would likewise generate a series of audit events, one for each system

Re: add closefrom() call

2007-07-06 Thread Joerg Sonnenberger
On Fri, Jul 06, 2007 at 06:18:14PM +0800, LI Xin wrote: - closefrom(-1) would be no-op on DragonFly, my version would close all open files (From my understanding of OpenSolaris's userland implementation, this is Solaris's behavior). I think this is a bad idea as -1 is generally an invalid

Re: add closefrom() call

2007-07-06 Thread Joerg Sonnenberger
On Wed, Jul 04, 2007 at 08:27:49PM -0400, Ighighi Ighighi wrote: It is implemented with the F_CLOSEM fcntl() available since version 2.0. I don't like the fcntl(2) approach as it applies actions to more than the passed in fd. That feels like an interface abuse. Joerg

Re: Finding slowdowns in pkg_install (continuations of previous threads)

2007-07-06 Thread Tim Kientzle
I'm currently running a gamut of tests (500 tests, per package -- 128 total on my server), and outputting all data to CSV files to interpret later, using another Perl script to interpret calculated averages and standard deviations. Excellent! Much-needed work. Using basic printf(2)'s

Re: Finding slowdowns in pkg_install (continuations of previous threads)

2007-07-06 Thread Garrett Cooper
Tim Kientzle wrote: I'm currently running a gamut of tests (500 tests, per package -- 128 total on my server), and outputting all data to CSV files to interpret later, using another Perl script to interpret calculated averages and standard deviations. Excellent! Much-needed work.

Re: Finding slowdowns in pkg_install (continuations of previous threads)

2007-07-06 Thread Tim Kientzle
-I tried ... buffering ... the +CONTENTS file parsing function, and the majority of the time it yielded good results One approach I prototyped sometime back was to use libarchive in pkg_add as follows: * Open the archive * Read +CONTENTS directly into memory (it's guaranteed to

Re: add closefrom() call

2007-07-06 Thread Julian Elischer
Ed Schouten wrote: * LI Xin [EMAIL PROTECTED] wrote: Here is my implementation for FreeBSD. Some difference between my and DragonFly's implementation: - closefrom(-1) would be no-op on DragonFly, my version would close all open files (From my understanding of OpenSolaris's userland

Re: add closefrom() call

2007-07-06 Thread Robert Watson
On Fri, 6 Jul 2007, Julian Elischer wrote: Ed Schouten wrote: * LI Xin [EMAIL PROTECTED] wrote: Here is my implementation for FreeBSD. Some difference between my and DragonFly's implementation: - closefrom(-1) would be no-op on DragonFly, my version would close all open files (From my

Re: add closefrom() call

2007-07-06 Thread Julian Elischer
Robert Watson wrote: On Fri, 6 Jul 2007, Julian Elischer wrote: Ed Schouten wrote: * LI Xin [EMAIL PROTECTED] wrote: Here is my implementation for FreeBSD. Some difference between my and DragonFly's implementation: - closefrom(-1) would be no-op on DragonFly, my version would close all

Re: Finding slowdowns in pkg_install

2007-07-06 Thread Michel Talon
Tim Kientzle said: One approach I prototyped sometime back was to use libarchive in pkg_add as follows: * Open the archive * Read +CONTENTS directly into memory (it's guaranteed to always be first in the archive) I can only concur with that. In my program

Re: New USB stack and Zero copy.

2007-07-06 Thread John Baldwin
On Friday 06 July 2007 02:59:39 am Hans Petter Selasky wrote: On Friday 06 July 2007 01:35, John Baldwin wrote: On Thursday 05 July 2007 04:25:17 pm John Baldwin wrote: On Thursday 05 July 2007 03:31:59 am Hans Petter Selasky wrote: On Wednesday 04 July 2007 19:35, John-Mark Gurney

Re: Finding slowdowns in pkg_install

2007-07-06 Thread youshi10
On Fri, 6 Jul 2007, Michel Talon wrote: Tim Kientzle said: One approach I prototyped sometime back was to use libarchive in pkg_add as follows: * Open the archive * Read +CONTENTS directly into memory (it's guaranteed to always be first in the archive) I can only concur with that. In