Re: bus_dma (9). What exactly means Loading of memory allocation ?

2009-02-04 Thread John Baldwin
On Monday 02 February 2009 11:23:33 am Alexej Sokolov wrote: Hi, thanx for your answer. I checked the source code of the *dma() functions. If I understand it correctly, loading of memory allocation means the following: 1. At first memory allocation should be done: bufp = *alloc(sizeof

Re: write-only variables in src/sys/ - possible bugs

2009-02-04 Thread Christoph Mallon
Christian Peron schrieb: I started following up on this and ran into an issue for these: sys/net/bpf_buffer.c:133: warning: variable 'dst' is never read sys/net/bpf_buffer.c:134: warning: variable 'count' is never read sys/net/bpf_buffer.c:142: warning: variable 'dst' is never read /* *

Re: blockable sleep lock (sleep mutex) 16

2009-02-04 Thread Nikola Knežević
On 2 Feb 2009, at 19:09 , Julian Elischer wrote: It says non-sleepable locks, yet it classifies click_instance as sleep mutex. I think witness code should emit messages which are more clear. It is confusing, but you can't do an M_WAITOK malloc while holding a mutex. Basically, sleeping

Re: write-only variables in src/sys/ - possible bugs

2009-02-04 Thread Christian Peron
On Wed, Feb 04, 2009 at 03:54:41PM +0100, Christoph Mallon wrote: [..] Yes, function arguments are considered being read. The problem is different here: mtod() should be a macro, but the macro declaration was missing (*cough* hacked build process *cough*). So the parser tried to parse

Re: write-only variables in src/sys/ - possible bugs

2009-02-04 Thread Christoph Mallon
Christian Peron schrieb: On Wed, Feb 04, 2009 at 03:54:41PM +0100, Christoph Mallon wrote: [..] Yes, function arguments are considered being read. The problem is different here: mtod() should be a macro, but the macro declaration was missing (*cough* hacked build process *cough*). So the

kobj methods (DEVMETHOD) that have differing signatures (in src/sys)

2009-02-04 Thread Andriy Gapon
This based on the (much) earlier proposal described here: http://lists.freebsd.org/pipermail/freebsd-arch/2008-April/007982.html The patch was applied to the recent current sources and LINT kernels for all architectures that have LINT/NOTES (i.e. arm excluded) were built. Here's a link to the

NO_WERROR vs kernel builds

2009-02-04 Thread Andriy Gapon
It seems that kernel builds ignore NO_WERROR. Is this on purpose or by accident? I think that this happens because of the following lines in sys/conf/kern.pre.mk: .if ${CC} != icc CFLAGS+= -fno-common -finline-limit=${INLINE_LIMIT} CFLAGS+= --param inline-unit-growth=100 CFLAGS+= --param

Re: kobj methods (DEVMETHOD) that have differing signatures (in src/sys)

2009-02-04 Thread M. Warner Losh
In message: 4989e87b.5010...@icyb.net.ua Andriy Gapon a...@icyb.net.ua writes: : : This based on the (much) earlier proposal described here: : http://lists.freebsd.org/pipermail/freebsd-arch/2008-April/007982.html : : The patch was applied to the recent current sources and LINT