Re: [patch] nmount ro, rw and negated option handling

On 2011-01-25, Jaakko Heinonen wrote: Another related bug is in vfs_domount_update(): if VFS_MOUNT() succeeds but vfs_export() fails, old mount flags and options are restored. I think this shouldn't happen when VFS_MOUNT() has been already successfully completed and this is the final reason

Re: [patch] nmount ro, rw and negated option handling

On 2011-01-19, Jaakko Heinonen wrote: On 2011-01-19, Craig Rodrigues wrote: I disagree with your patch and do not approve it. 1. Have mountd(8) running. 2. # mdconfig -a -t vnode -f ufsimg 3. # mount -o ro,rw /dev/md0 /mnt With your patch[1] after the third step the mount point

Re: [patch] nmount ro, rw and negated option handling

On Fri, Jan 14, 2011 at 02:24:54PM +0200, Jaakko Heinonen wrote: Hi, Hi, Currently nmount(2) allows a mount point to have ro, rw, and noro string options concurrently active. This can cause erratic behavior demonstrated by this example: 1. Have mountd(8) running. 2. # mdconfig -a -t

Re: [patch] nmount ro, rw and negated option handling

Hi, I disagree with your patch and do not approve it. I prefer something simpler: Index: vfs_mount.c === --- vfs_mount.c (revision 216607) +++ vfs_mount.c (working copy) @@ -522,10 +522,9 @@ struct vfsopt *opt, *noro_opt,

Re: [patch] nmount ro, rw and negated option handling

On 2011-01-19, Craig Rodrigues wrote: I disagree with your patch and do not approve it. I prefer something simpler: Thanks for your reply. However, your patch doesn't fix the bug(s) I tried to resolve. See below. ZFS can be changed to check for rw or noro. It's possible but I don't like to

[patch] nmount ro, rw and negated option handling

Hi, Currently nmount(2) allows a mount point to have ro, rw, and noro string options concurrently active. This can cause erratic behavior demonstrated by this example: 1. Have mountd(8) running. 2. # mdconfig -a -t vnode -f ufsimg 3. # mount -o ro,rw /dev/md0 /mnt After these steps the mount