Igor Podlesny wrote:
/*
* Macro for finding the interface (ifnet structure) corresponding to one
* of our IP addresses.
*/
#define INADDR_TO_IFP(addr, ifp) \
/* struct in_addr addr; */ \
/* struct ifnet *ifp; */ \
{ \
register struct in_ifaddr *ia;
Hello everybody!
This is relative to 4.3 for yet ;) so if you're using something older
you can skip it easily.
well, I came up with a patch
(http://www.morning.ru/~poige/patchzone/ip_fw.c.patch)
How it was started
--
For a long time I've been looking forward (and
Igor Podlesny [EMAIL PROTECTED] types:
// so here we start looking through the queue
ia != NULL
// sanity (I'd have written just (ia))
Yep, just (ia) would have worked, but style(9) mandates (ia != NULL),
which is much easier to understand
:)
Don't want to
Igor Podlesny wrote:
/*
* Macro for finding the interface (ifnet structure) corresponding to one
* of our IP addresses.
*/
#define INADDR_TO_IFP(addr, ifp) \
/* struct in_addr addr; */ \
/* struct ifnet *ifp; */ \
{ \
register struct in_ifaddr *ia; \
No real knowledge of the ipfw code or the motives behind it here,
but just a comment..
On Sat, Jun 30, 2001 at 06:51:33PM +0800, Igor Podlesny wrote:
[snip]
// so here we start looking through the queue
ia != NULL
// sanity (I'd have written just (ia))
Yep, just (ia) would
// so here we start looking through the queue
ia != NULL
// sanity (I'd have written just (ia))
Yep, just (ia) would have worked, but style(9) mandates (ia != NULL),
which is much easier to understand
:)
Don't want to dispute about the 'right' style :), but :))
I prefer
Igor Podlesny wrote:
/*
* Macro for finding the interface (ifnet structure) corresponding to one
* of our IP addresses.
*/
#define INADDR_TO_IFP(addr, ifp) \
/* struct in_addr addr; */ \
/* struct ifnet *ifp; */ \
{ \
register struct in_ifaddr *ia; \
Igor Podlesny [EMAIL PROTECTED] types:
// so here we start looking through the queue
ia != NULL
// sanity (I'd have written just (ia))
Yep, just (ia) would have worked, but style(9) mandates (ia != NULL),
which is much easier to understand
:)
Don't want to
8 matches
Mail list logo