Re: Increasing size of if_flags field in the ifnet structure [patch

2002-08-16 Thread Maxim Sobolev
Please take a look at this patch. It implement 1 more flag to if_flags and ofcourse it increases size of this flag field by using if_ipending which is unused. There is no much point in this patch, because it will increase size of struct ifreq, which means that no ioctl's from older apps

Re: Increasing size of if_flags field in the ifnet structure [patch

2002-08-16 Thread Iasen Kostov
On Fri, 16 Aug 2002, Maxim Sobolev wrote: Please take a look at this patch. It implement 1 more flag to if_flags and ofcourse it increases size of this flag field by using if_ipending which is unused. There is no much point in this patch, because it will increase size of struct

Re: Increasing size of if_flags field in the ifnet structure [patch

2002-08-16 Thread Maxim Sobolev
On Thu, 15 Aug 2002, Maxim Sobolev wrote: When implementing ability to switch interface into promisc mode using ifconfig(8) I've stumbled into the problem with already exhausted space in the `short if_flags' field in the ifnet structure. I need to allocate one new flag, while we

Re: Increasing size of if_flags field in the ifnet structure [patch

2002-08-16 Thread Maxim Sobolev
There is no much point in this patch, because it will increase size of struct ifreq, which means that no ioctl's from older apps will be accepted anyway. Therefore, there is no difference between those two, while my approach is obviously cleaner. It does not increase size of struct

Re: Increasing size of if_flags field in the ifnet structure [patch

2002-08-16 Thread Terry Lambert
Maxim Sobolev wrote: There is no much point in this patch, because it will increase size of struct ifreq, which means that no ioctl's from older apps will be accepted anyway. Therefore, there is no difference between those two, while my approach is obviously cleaner. It does

Re: Increasing size of if_flags field in the ifnet structure [patch

2002-08-16 Thread Iasen Kostov
On Fri, 16 Aug 2002, Maxim Sobolev wrote: On Thu, 15 Aug 2002, Maxim Sobolev wrote: When implementing ability to switch interface into promisc mode using ifconfig(8) I've stumbled into the problem with already exhausted space in the `short if_flags' field in the ifnet structure.

Re: Increasing size of if_flags field in the ifnet structure [patch

2002-08-16 Thread Harti Brandt
On Fri, 16 Aug 2002, Maxim Sobolev wrote: MSBTW, I've just realised that we can easily avoid breaking application MSABI by using currently unused ifr_ifru.ifru_flags[2] (aka. ifr_prevflags) MSfor storing another 16 flags. What do people think? The ifr_prevflags may be used by snmp daemons to

Re: Increasing size of if_flags field in the ifnet structure [patch

2002-08-16 Thread Maxim Sobolev
On Fri, 16 Aug 2002, Maxim Sobolev wrote: MSBTW, I've just realised that we can easily avoid breaking application MSABI by using currently unused ifr_ifru.ifru_flags[2] (aka. ifr_prevflags) MSfor storing another 16 flags. What do people think? The ifr_prevflags may be used by snmp

Re: Increasing size of if_flags field in the ifnet structure [patch

2002-08-16 Thread Harti Brandt
On Fri, 16 Aug 2002, Maxim Sobolev wrote: MS MS On Fri, 16 Aug 2002, Maxim Sobolev wrote: MS MS MSBTW, I've just realised that we can easily avoid breaking application MS MSABI by using currently unused ifr_ifru.ifru_flags[2] (aka. ifr_prevflags) MS MSfor storing another 16 flags. What do people

Re: Increasing size of if_flags field in the ifnet structure [patch

2002-08-16 Thread Maxim Sobolev
On Fri, 16 Aug 2002, Maxim Sobolev wrote: MS MS On Fri, 16 Aug 2002, Maxim Sobolev wrote: MS MS MSBTW, I've just realised that we can easily avoid breaking application MS MSABI by using currently unused ifr_ifru.ifru_flags[2] (aka. ifr_prevflags) MS MSfor storing another 16 flags. What

Re: Increasing size of if_flags field in the ifnet structure [patch

2002-08-16 Thread Harti Brandt
On Fri, 16 Aug 2002, Maxim Sobolev wrote: MS MS On Fri, 16 Aug 2002, Maxim Sobolev wrote: MS MS MS MS MS On Fri, 16 Aug 2002, Maxim Sobolev wrote: MS MS MS MS MSBTW, I've just realised that we can easily avoid breaking application MS MS MSABI by using currently unused ifr_ifru.ifru_flags[2]

Re: Increasing size of if_flags field in the ifnet structure [patch

2002-08-16 Thread Peter Wemm
Maxim Sobolev wrote: There is no much point in this patch, because it will increase size of struct ifreq, which means that no ioctl's from older apps will be accept ed anyway. Therefore, there is no difference between those two, while my approach is obviously cleaner. It

Increasing size of if_flags field in the ifnet structure [patch for review]

2002-08-15 Thread Maxim Sobolev
Folks, When implementing ability to switch interface into promisc mode using ifconfig(8) I've stumbled into the problem with already exhausted space in the `short if_flags' field in the ifnet structure. I need to allocate one new flag, while we already have 16 IFF_* flags, and even one

Re: Increasing size of if_flags field in the ifnet structure [patch for review]

2002-08-15 Thread Brooks Davis
On Thu, Aug 15, 2002 at 09:43:01PM +0300, Maxim Sobolev wrote: When implementing ability to switch interface into promisc mode using ifconfig(8) I've stumbled into the problem with already exhausted space in the `short if_flags' field in the ifnet structure. I need to allocate one new flag,