PLEASE REVIEW: loader fix for gzipped kernels

2001-08-29 Thread John Polstra
I would appreciate another pair of eyes on the attached patch before I commit it. I have been working with gzipped kernels a lot lately, and have noticed that when the loader tries to load certain kernels, it fails with the message elf_loadexec: cannot seek. I tracked this down to a bug in

Re: PLEASE REVIEW: loader fix for gzipped kernels

2001-08-29 Thread Garrett Rooney
On Wed, Aug 29, 2001 at 11:27:20AM -0700, John Polstra wrote: I would appreciate another pair of eyes on the attached patch before I commit it. I have been working with gzipped kernels a lot lately, and have noticed that when the loader tries to load certain kernels, it fails with the

RE: PLEASE REVIEW: loader fix for gzipped kernels

2001-08-29 Thread John Baldwin
On 29-Aug-01 John Polstra wrote: I would appreciate another pair of eyes on the attached patch before I commit it. Looks good to me, but I'm only somewhat familiar with libstand. :) -- John Baldwin [EMAIL PROTECTED] -- http://www.FreeBSD.org/~jhb/ PGP Key:

Re: PLEASE REVIEW: loader fix for gzipped kernels

2001-08-29 Thread John Polstra
In article [EMAIL PROTECTED], John Baldwin [EMAIL PROTECTED] wrote: Looks good to me, but I'm only somewhat familiar with libstand. :) Thanks for taking a look at it. Matt Dillon also reviewed it and gave it a clean bill of health. He made a suggestion for making the code a bit smaller.

Re: PLEASE REVIEW: loader fix for gzipped kernels

2001-08-29 Thread Matt Dillon
:In article [EMAIL PROTECTED], :John Baldwin [EMAIL PROTECTED] wrote: : : Looks good to me, but I'm only somewhat familiar with libstand. :) : :Thanks for taking a look at it. Matt Dillon also reviewed it and gave :it a clean bill of health. He made a suggestion for making the code a :bit

Re: PLEASE REVIEW: loader fix for gzipped kernels

2001-08-29 Thread John Polstra
In article [EMAIL PROTECTED], Matt Dillon [EMAIL PROTECTED] wrote: I'll give it a quick test after you commit it (I can combine the test with some other work I'm doing). Thanks. I've committed it, and it should hit the mirrors within the next hour. I tested it with both gzipped and