Re: [PATCH] Fix 'implicit declaration' warning and update vgone(9)

2010-10-29 Thread Robert Watson
On Wed, 27 Oct 2010, Benjamin Kaduk wrote: On Wed, 27 Oct 2010, Kostik Belousov wrote: On Wed, Oct 27, 2010 at 10:59:56AM -0400, Benjamin Kaduk wrote: [1] The old (racy) function is osi_TryEvictVCache, here:

Re: [PATCH] Fix 'implicit declaration' warning and update vgone(9)

2010-10-28 Thread Kostik Belousov
On Wed, Oct 27, 2010 at 11:57:31PM -0400, Benjamin Kaduk wrote: On Wed, 27 Oct 2010, Kostik Belousov wrote: On Wed, Oct 27, 2010 at 10:59:56AM -0400, Benjamin Kaduk wrote: [1] The old (racy) function is osi_TryEvictVCache, here:

Re: [PATCH] Fix 'implicit declaration' warning and update vgone(9)

2010-10-27 Thread Lars Hartmann
attached the fixed vgonel.patch -- Lars Hartmann l...@chaotika.org fix implicit declaration warning - found by Ben Kaduk ka...@mit.edu From: Lars Hartmann l...@chaotika.org --- sys/sys/vnode.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/sys/sys/vnode.h

Re: [PATCH] Fix 'implicit declaration' warning and update vgone(9)

2010-10-27 Thread Sergey Kandaurov
On 27 October 2010 10:23, Lars Hartmann l...@chaotika.org wrote: The vgonel function isnt declarated in any header, the vgonel prototype in vgone(9) isnt correct - found by Ben Kaduk ka...@mit.edu Hi. I'm afraid it's just an overlooked man page after many VFS changes in 5.x. As vgonel() is a

Re: [PATCH] Fix 'implicit declaration' warning and update vgone(9)

2010-10-27 Thread Sergey Kandaurov
On 27 October 2010 15:33, Sergey Kandaurov pluk...@gmail.com wrote: On 27 October 2010 10:23, Lars Hartmann l...@chaotika.org wrote: The vgonel function isnt declarated in any header, the vgonel prototype in vgone(9) isnt correct - found by Ben Kaduk ka...@mit.edu Hi. I'm afraid it's just

Re: [PATCH] Fix 'implicit declaration' warning and update vgone(9)

2010-10-27 Thread John Baldwin
On Wednesday, October 27, 2010 7:33:13 am Sergey Kandaurov wrote: On 27 October 2010 10:23, Lars Hartmann l...@chaotika.org wrote: The vgonel function isnt declarated in any header, the vgonel prototype in vgone(9) isnt correct - found by Ben Kaduk ka...@mit.edu Hi. I'm afraid it's just

Re: [PATCH] Fix 'implicit declaration' warning and update vgone(9)

2010-10-27 Thread Kostik Belousov
On Wed, Oct 27, 2010 at 05:26:13PM +0400, Sergey Kandaurov wrote: On 27 October 2010 15:33, Sergey Kandaurov pluk...@gmail.com wrote: On 27 October 2010 10:23, Lars Hartmann l...@chaotika.org wrote: The vgonel function isnt declarated in any header, the vgonel prototype in vgone(9) isnt

Re: [PATCH] Fix 'implicit declaration' warning and update vgone(9)

2010-10-27 Thread Benjamin Kaduk
On Wed, 27 Oct 2010, John Baldwin wrote: On Wednesday, October 27, 2010 7:33:13 am Sergey Kandaurov wrote: On 27 October 2010 10:23, Lars Hartmann l...@chaotika.org wrote: The vgonel function isnt declarated in any header, the vgonel prototype in vgone(9) isnt correct - found by Ben Kaduk

Re: [PATCH] Fix 'implicit declaration' warning and update vgone(9)

2010-10-27 Thread Benjamin Kaduk
On Wed, 27 Oct 2010, Kostik Belousov wrote: On Wed, Oct 27, 2010 at 10:59:56AM -0400, Benjamin Kaduk wrote: [1] The old (racy) function is osi_TryEvictVCache, here: http://git.openafs.org/?p=openafs.git;a=blob;f=src/afs/FBSD/osi_vcache.c;h=c2060c74f0155a610d2ea94f3c7f508e8ca4373a;hb=HEAD The