since you've tested the patch on 7-stable do think it's mature enough to be
committed to that branch?
alex
___
freebsd-hackers@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-hackers
To unsubscribe, send any mail to "freebsd-ha
Eygene Ryabinkin schrieb am 2009-11-03:
> Mon, Nov 02, 2009 at 10:32:29PM +0100, Alexander Best wrote:
> > ok. the pr stays in patched state. right now the patch is in HEAD,
> > 8-STABLE and 8.0-RELEASE. rafan is thinking about mfc'ing the patch
> > to
> > 6-stable and 7-stable. however if somebody
Mon, Nov 02, 2009 at 10:32:29PM +0100, Alexander Best wrote:
> ok. the pr stays in patched state. right now the patch is in HEAD,
> 8-STABLE and 8.0-RELEASE. rafan is thinking about mfc'ing the patch to
> 6-stable and 7-stable. however if somebody is willing to modify the
> patch so it applies to t
Dag-Erling Smørgrav schrieb am 2009-11-01:
> Alexander Best writes:
> > great news. so should the PR be closed or should it remain in
> > patched state in
> > order for 7.x to get patched?
> Set it to "patched" until you've merged the patch to 6, 7 and 8
> (IIRC, 6
> has the new ncurses as well)
Alexander Best writes:
> great news. so should the PR be closed or should it remain in patched state in
> order for 7.x to get patched?
Set it to "patched" until you've merged the patch to 6, 7 and 8 (IIRC, 6
has the new ncurses as well)
> another question: how about our ncurses base version in
Dag-Erling Smørgrav schrieb am 2009-10-26:
> Alexander Best writes:
> > the patch got committed by thomas and is included in
> > ncurses-5.7-20091024.patch.gz.
> > i guess it will be included in our base version of ncurses once 5.8
> > gets
> > released, but the patch should quickly make it into
Dag-Erling Smørgrav schrieb am 2009-10-26:
> Rong-En Fan writes:
> > devel/ncurses-devel will be updated this week. For base's ncurses,
> > I'll
> > check with Thomas Dickey to see if there will be 5.8 soon. If not,
> > we
> > can also import a recent snapshot.
> There is no reason to wait, nor t
Rong-En Fan writes:
> devel/ncurses-devel will be updated this week. For base's ncurses, I'll
> check with Thomas Dickey to see if there will be 5.8 soon. If not, we
> can also import a recent snapshot.
There is no reason to wait, nor to import an entire snapshot. Se my
earlier message to Alexan
On Mon, Oct 26, 2009 at 11:44:14AM +0100, Alexander Best wrote:
> Eygene Ryabinkin schrieb am 2009-10-24:
> > Ed, good day.
>
> > Fri, Oct 23, 2009 at 07:13:01PM +0200, Ed Schouten wrote:
> > > Have you sent it to Thomas Dickey as well?
>
> > Sent the patch to bug-ncur...@gnu.org. Do you think t
Alexander Best writes:
> the patch got committed by thomas and is included in
> ncurses-5.7-20091024.patch.gz.
>
> i guess it will be included in our base version of ncurses once 5.8 gets
> released, but the patch should quickly make it into the port version of
> ncurses.
Apply the upstream patch
Dag-Erling Smørgrav schrieb am 2009-10-25:
> Alexander Best writes:
> > i just tried building ee under linux without using new_curse.c and
> > linking the
> > executable against ncurses. running the binary is showing the same
> > problems
> > with SIGWINCH. so if this is in fact caused by a ncurse
Eygene Ryabinkin schrieb am 2009-10-24:
> Ed, good day.
> Fri, Oct 23, 2009 at 07:13:01PM +0200, Ed Schouten wrote:
> > Have you sent it to Thomas Dickey as well?
> Sent the patch to bug-ncur...@gnu.org. Do you think that I should
> send it to Thomas directly as well?
the patch got committed by
Alexander Best writes:
> i just tried building ee under linux without using new_curse.c and linking the
> executable against ncurses. running the binary is showing the same problems
> with SIGWINCH. so if this is in fact caused by a ncurses bug the bug appears
> in linux ncurses too.
No surprise,
Sat, Oct 24, 2009 at 02:04:34PM +0200, Jilles Tjoelker wrote:
> That should be:
> -
> do
> in = wgetch(text_win);
> while (in == -1 && errno == EINTR);
> if (in == -1)
> exit(0);
> -
>
> errno should only be checked after failed function calls or for
> functions where it is doc
On Fri, Oct 23, 2009 at 07:56:35PM +0400, Eygene Ryabinkin wrote:
> Hmm, we can transform this code to the following one:
> -
> errno = 0;
> do {
> in = wgetch(text_win);
> } while (errno == EINTR);
> if (in == -1)
> exit(0);
> -
> This won't help with FreeBSD's ncurses, but may
Hy Eygene,
* Eygene Ryabinkin wrote:
> Sent the patch to bug-ncur...@gnu.org. Do you think that I should
> send it to Thomas directly as well?
Probably not. bug-ncurses@ should be good enough. Thanks!
--
Ed Schouten
WWW: http://80386.nl/
pgp38kOKPpvEE.pgp
Description: PGP signature
Ed, good day.
Fri, Oct 23, 2009 at 07:13:01PM +0200, Ed Schouten wrote:
> Have you sent it to Thomas Dickey as well?
Sent the patch to bug-ncur...@gnu.org. Do you think that I should
send it to Thomas directly as well?
--
Eygene
____ _.--. #
\`.|\.....-'` `-._.-'
* Eygene Ryabinkin wrote:
> The problem should be healed with the attached patch.
Ah, thanks. I looked at this some time ago but I also discovered ncurses
was to blame. I didn't have any time to look at it back then, so I
obviously forgot.
Have you sent it to Thomas Dickey as well?
--
Ed Scho
Eygene Ryabinkin schrieb am 2009-10-23:
> Gentlemen, good day.
> Fri, Oct 23, 2009 at 02:02:38PM +0200, Dag-Erling Sm??rgrav wrote:
> > src/contrib/ee/ee.c in 8:
> > in = wgetch(text_win);
> > if (in == -1)
> > exit(0); /* without this exit
Fri, Oct 23, 2009 at 06:32:38PM +0200, Alexander Best wrote:
> thanks a million. for me the patch works great. :)
You're welcome ;))
> the sooner it gets committed the better. ;)
It may well break something else. I am not 100% sure that this patch
is the proper thing -- curses code is a bit new
Eygene Ryabinkin schrieb am 2009-10-23:
> Gentlemen, good day.
> Fri, Oct 23, 2009 at 02:02:38PM +0200, Dag-Erling Sm??rgrav wrote:
> > src/contrib/ee/ee.c in 8:
> > in = wgetch(text_win);
> > if (in == -1)
> > exit(0); /* without this exit
Gentlemen, good day.
Fri, Oct 23, 2009 at 02:02:38PM +0200, Dag-Erling Sm??rgrav wrote:
> src/contrib/ee/ee.c in 8:
>
> in = wgetch(text_win);
> if (in == -1)
> exit(0); /* without this exit ee will go into an
>
2009/10/23 Alexander Best :
> pluknet schrieb am 2009-10-23:
>> 2009/10/23 Alexander Best :
>> > Gary Jennejohn schrieb am 2009-10-23:
>> >> On Fri, 23 Oct 2009 12:58:43 +0400
>> >> pluknet wrote:
>
>> >> > 2009/10/23 Antony Mawer :
>> >> > > On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
>> >> >
pluknet schrieb am 2009-10-23:
> 2009/10/23 Alexander Best :
> > Gary Jennejohn schrieb am 2009-10-23:
> >> On Fri, 23 Oct 2009 12:58:43 +0400
> >> pluknet wrote:
> >> > 2009/10/23 Antony Mawer :
> >> > > On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
> >> > > wrote:
> >> > >> hi everyone,
> >
2009/10/23 Alexander Best :
> Gary Jennejohn schrieb am 2009-10-23:
>> On Fri, 23 Oct 2009 12:58:43 +0400
>> pluknet wrote:
>
>> > 2009/10/23 Antony Mawer :
>> > > On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
>> > > wrote:
>> > >> hi everyone,
>
>> > >> together with hugh mahon (the author of
Gary Jennejohn schrieb am 2009-10-23:
> On Fri, 23 Oct 2009 12:58:43 +0400
> pluknet wrote:
> > 2009/10/23 Antony Mawer :
> > > On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
> > > wrote:
> > >> hi everyone,
> > >> together with hugh mahon (the author of ee) i've been trying to
> > >> fix a na
Gary Jennejohn schrieb am 2009-10-23:
> On Fri, 23 Oct 2009 12:58:43 +0400
> pluknet wrote:
> > 2009/10/23 Antony Mawer :
> > > On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
> > > wrote:
> > >> hi everyone,
> > >> together with hugh mahon (the author of ee) i've been trying to
> > >> fix a na
[cc: ed for ee and rafan for ncurses]
Alexander Best writes:
> i'm not so sure this is entirely ee's fault.
It is *partly* ee's fault.
src/usr.bin/ee/ee.c in 7:
in = wgetch(text_win);
if (in == -1)
continue;
src/contrib/ee/ee.c in 8:
On Fri, 23 Oct 2009 13:50:24 +0200
Gary Jennejohn wrote:
> On Fri, 23 Oct 2009 12:58:43 +0400
> pluknet wrote:
>
> > 2009/10/23 Antony Mawer :
> > > On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
> > > wrote:
> > >> hi everyone,
> > >>
> > >> together with hugh mahon (the author of ee) i've b
On Fri, 23 Oct 2009 12:58:43 +0400
pluknet wrote:
> 2009/10/23 Antony Mawer :
> > On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
> > wrote:
> >> hi everyone,
> >>
> >> together with hugh mahon (the author of ee) i've been trying to fix a nasty
> >> bug in ee. for some reason ee exits (not crash
On 10/23/09, Alexander Best wrote:
> Nate Eldredge schrieb am 2009-10-23:
>> On Fri, 23 Oct 2009, Antony Mawer wrote:
>
>> >On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
>> > wrote:
>> >>hi everyone,
>
>> >>together with hugh mahon (the author of ee) i've been trying to
>> >>fix a nasty
>> >>bug
pluknet schrieb am 2009-10-23:
> 2009/10/23 Antony Mawer :
> > On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
> > wrote:
> >> hi everyone,
> >> together with hugh mahon (the author of ee) i've been trying to
> >> fix a nasty
> >> bug in ee. for some reason ee exits (not crashes) and leaves the
>
Nate Eldredge schrieb am 2009-10-23:
> On Fri, 23 Oct 2009, Antony Mawer wrote:
> >On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
> > wrote:
> >>hi everyone,
> >>together with hugh mahon (the author of ee) i've been trying to
> >>fix a nasty
> >>bug in ee. for some reason ee exits (not crashes)
2009/10/23 Antony Mawer :
> On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
> wrote:
>> hi everyone,
>>
>> together with hugh mahon (the author of ee) i've been trying to fix a nasty
>> bug in ee. for some reason ee exits (not crashes) and leaves the console
>> corrupted when receiving SIGWINCH (`
Antony Mawer skrev:
On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
wrote:
hi everyone,
together with hugh mahon (the author of ee) i've been trying to fix a nasty
bug in ee. for some reason ee exits (not crashes) and leaves the console
corrupted when receiving SIGWINCH (`killall -SIGWINCH ee`
On Fri, 23 Oct 2009, Antony Mawer wrote:
On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
wrote:
hi everyone,
together with hugh mahon (the author of ee) i've been trying to fix a nasty
bug in ee. for some reason ee exits (not crashes) and leaves the console
corrupted when receiving SIGWINCH (
On Fri, Oct 23, 2009 at 1:35 PM, Alexander Best
wrote:
> hi everyone,
>
> together with hugh mahon (the author of ee) i've been trying to fix a nasty
> bug in ee. for some reason ee exits (not crashes) and leaves the console
> corrupted when receiving SIGWINCH (`killall -SIGWINCH ee` should exit a
hi everyone,
together with hugh mahon (the author of ee) i've been trying to fix a nasty
bug in ee. for some reason ee exits (not crashes) and leaves the console
corrupted when receiving SIGWINCH (`killall -SIGWINCH ee` should exit all
running ee instances).
unfortunately we were unable to find t
38 matches
Mail list logo
