Re: bin/144214: zfsboot fails on gang block after upgrade to zfs v14

2010-06-03 Thread Andriy Gapon
on 28/05/2010 17:49 Doug Rabson said the following: On 27 May 2010 16:13, Andriy Gapon a...@icyb.net.ua mailto:a...@icyb.net.ua wrote: on 27/05/2010 17:40 Doug Rabson said the following: Excellent work - thanks for looking into this. I still think its easier to

Re: bin/144214: zfsboot fails on gang block after upgrade to zfs v14

2010-05-28 Thread Doug Rabson
On 27 May 2010 16:13, Andriy Gapon a...@icyb.net.ua wrote: on 27/05/2010 17:40 Doug Rabson said the following: Excellent work - thanks for looking into this. I still think its easier to debug this code in userland using a shim that redirects the zfsboot i/o calls to simple read system

Re: bin/144214: zfsboot fails on gang block after upgrade to zfs v14

2010-05-27 Thread Andriy Gapon
I think I nailed this problem now. What was additionally needed was the following change: if (!vdev || !vdev-v_read) return (EIO); - if (vdev-v_read(vdev, bp, zio_gb, offset, SPA_GANGBLOCKSIZE)) + if (vdev-v_read(vdev, NULL, zio_gb, offset, SPA_GANGBLOCKSIZE))

Re: bin/144214: zfsboot fails on gang block after upgrade to zfs v14

2010-05-27 Thread Robert Noland
Andriy Gapon wrote: I think I nailed this problem now. What was additionally needed was the following change: if (!vdev || !vdev-v_read) return (EIO); - if (vdev-v_read(vdev, bp, zio_gb, offset, SPA_GANGBLOCKSIZE)) + if (vdev-v_read(vdev, NULL, zio_gb,

Re: bin/144214: zfsboot fails on gang block after upgrade to zfs v14

2010-05-27 Thread Doug Rabson
On 27 May 2010 09:35, Andriy Gapon a...@freebsd.org wrote: I think I nailed this problem now. What was additionally needed was the following change: if (!vdev || !vdev-v_read) return (EIO); - if (vdev-v_read(vdev, bp, zio_gb, offset, SPA_GANGBLOCKSIZE)) +

Re: bin/144214: zfsboot fails on gang block after upgrade to zfs v14

2010-05-27 Thread Andriy Gapon
on 27/05/2010 17:40 Doug Rabson said the following: Excellent work - thanks for looking into this. I still think its easier to debug this code in userland using a shim that redirects the zfsboot i/o calls to simple read system calls... Absolutely! That should much easier. Do you have such a