Re: pf + vimage patch

2013-06-06 Thread Nikos Vassiliadis
Hi, Comments below. On 06/05/2013 10:52 AM, Mikolaj Golub wrote: 1) It looks like the patch can be split on several parts. A log message to every change describing why it is needed and what problem solves would be very helpful. As a tool to maintain such changes I personally prefer git. I'll

Re: pf + vimage patch

2013-06-06 Thread Mikolaj Golub
On Thu, Jun 06, 2013 at 12:35:33PM +0200, Nikos Vassiliadis wrote: -VNET_DEFINE(u_long, pf_srchashsize); -#define V_pf_srchashsizeVNET(pf_srchashsize) -SYSCTL_VNET_UINT(_net_pf, OID_AUTO, source_nodes_hashsize, CTLFLAG_RDTUN, -VNET_NAME(pf_srchashsize), 0, Size of pf(4)

Re: pf + vimage patch

2013-06-06 Thread Thibault Noel
Hi, I quite agree with Gleb Smirnoff on the possibility of avoiding a reboot after each compile. I don't now if it's a good moment to speak of this, but I observed that if pfsync is active in the kernel, it will use its state table even if nothing is set in the rc.conf. I think that if no

Re: pf + vimage patch

2013-06-06 Thread Nikos Vassiliadis
On 06/06/2013 02:28 PM, Gleb Smirnoff wrote: M module unload is broken:( Maybe it can be fixed at a (bit) later date? M M I don't think Gleb will be happy with this. Some time ago he removed M some vimage related stuff to prevent crashing on module unload (see M r229849). Actually your patch