[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

ale marked 5 inline comments as done. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D9270 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: ale, #manpages, wblock, #network, julian, mav, adrian, glebius Cc: glebius,

[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

ale updated this revision to Diff 27059. ale added a comment. Addressed latest comments, updated also the pppoe disconnect function. Please check the correctness, and commit the patch if you are satisfied. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE

[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

ale added a comment. The three mentioned comments apply also to the ng_pppoe_disconnect function at line 2030 from which I took inspiration, do you want me to change that function, too? REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D9270 EMAIL

[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

glebius requested changes to this revision. glebius added a comment. This revision now requires changes to proceed. I got few minor comments. INLINE COMMENTS > ng_pppoe.c:1135 > + /* Generate a packet of that type. */ > + MGETHDR(m, M_NOWAIT, MT_DATA);

[Bug 217637] One TCP connection accepted TWO times

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217637 --- Comment #80 from Michael Tuexen --- I put a patch under review: https://reviews.freebsd.org/D10272 If syncookies are used in case of an overflow of the syncache, its usage is restricted to the case where there was