Re: [CFT/Review] net byte order for AF_INET

2012-10-11 Thread Gleb Smirnoff
Olivier, thanks for help! On Fri, Oct 12, 2012 at 02:20:55AM +0200, Olivier Cochard-Labb? wrote: O> I've done some tests with this net byte ordered(NBO) patch: O> - I've compiled 2 i386 images of BSD Router Project (current branch O> rev241418): One with the patch, and the other without the p

Re: [CFT/Review] net byte order for AF_INET

2012-10-11 Thread Gleb Smirnoff
On Thu, Oct 11, 2012 at 06:07:12AM +0400, Maxim Dounin wrote: M> > This is de facto standard for raw sockets in most OS-es. Byte order M> > in raw socket is host. And this is the same behavior we had before M> > the patch. So no reason for extra comments. M> M> As I already pointed out (in an off-

Re: [CFT/Review] net byte order for AF_INET

2012-10-10 Thread Gleb Smirnoff
On Thu, Oct 11, 2012 at 02:06:11AM +0200, Luigi Rizzo wrote: L> > M> > @@ -504,6 +504,9 @@ L> > M> > if (ip->ip_id == 0) L> > M> > ip->ip_id = ip_newid(); L> > M> > L> > M> > + ip->ip_len = htons(ip->ip_len); L> > M> > + ip->ip_off = hto

Re: [CFT/Review] net byte order for AF_INET

2012-10-10 Thread Gleb Smirnoff
Maxim, On Thu, Oct 11, 2012 at 02:26:51AM +0400, Maxim Dounin wrote: M> > --- sys/netinet/raw_ip.c (revision 241405) M> > +++ sys/netinet/raw_ip.c (working copy) M> > @@ -292,7 +292,7 @@ M> > * not modify the packet except for some M> > * byte order swaps. M> > */ M> > - ip->ip_

Re: [CFT/Review] net byte order for AF_INET

2012-10-10 Thread Gleb Smirnoff
On Tue, Oct 09, 2012 at 07:41:28PM +0400, Gleb Smirnoff wrote: T> this is a patch that switches entire IPv4 stack to network T> byte order. That means, that at any layer any module should T> expect IP header in network byte order. Any host byte order T> values can be stored in loc

Re: [CFT/Review] net byte order for AF_INET

2012-10-10 Thread Gleb Smirnoff
Luigi, On Wed, Oct 10, 2012 at 02:46:37PM +0200, Luigi Rizzo wrote: L> I am really grataful you are doing this. A few comments: L> L> + as a strategy, i would probably suggest (something you mostly seem to do already) L> that arithmetic comparisons (even if just for equality) always use the

Re: [CFT/Review] net byte order for AF_INET

2012-10-10 Thread Gleb Smirnoff
On Wed, Oct 10, 2012 at 09:47:46AM -0500, Guy Helmer wrote: G> > this is a patch that switches entire IPv4 stack to network G> > byte order. That means, that at any layer any module should G> > expect IP header in network byte order. Any host byte order G> > values can be stored in local variables

Re: [CFT/Review] net byte order for AF_INET

2012-10-10 Thread Gleb Smirnoff
On Wed, Oct 10, 2012 at 01:41:39AM -0700, Adrian Chadd wrote: A> Can you please test on i386? :) I don't have any. If you are hinting at debugging printf from in_cksum code that is present on i386 and not on amd64, then don't worry, I've added similar printf to amd64 in_cksum in my tree. -- Tot

[CFT/Review] net byte order for AF_INET

2012-10-09 Thread Gleb Smirnoff
Hello, this is a patch that switches entire IPv4 stack to network byte order. That means, that at any layer any module should expect IP header in network byte order. Any host byte order values can be stored in local variables only and are never stored into a packet itself. The new code brin

Re: svn commit: r241245 - in head: . share/man/man9 sys/contrib/ipfilter/netinet sys/net sys/netinet sys/netpfil/ipfw sys/netpfil/pf sys/sys

2012-10-07 Thread Gleb Smirnoff
On Sun, Oct 07, 2012 at 06:49:51PM -0700, Adrian Chadd wrote: A> Hi, A> A> People have been reporting this: A> A> A> Oct 7 18:35:19 alix kernel: in_cksum_skip: out of data by 53295 A> Oct 7 18:35:19 alix kernel: in_cksum_skip: out of data by 55335 A> A> Would you please investigate this, or b

Re: [PATCH] resolve byte order mess in ip_input/ip_output/pfil(9)

2012-10-06 Thread Gleb Smirnoff
On Fri, Oct 05, 2012 at 05:05:16PM +0200, Ermal Lu?i wrote: E> > E> speaking of pf(4) side of things please do not loose the VIMAGE calls! E> > E> > Yeah, can you explain please why do we need them here? The pfil hooks E> > are always run already in some defined VNET context, don't they? E> E> fro

Re: [PATCH] resolve byte order mess in ip_input/ip_output/pfil(9)

2012-10-05 Thread Gleb Smirnoff
On Fri, Oct 05, 2012 at 05:05:16PM +0200, Ermal Lu?i wrote: E> > E> speaking of pf(4) side of things please do not loose the VIMAGE calls! E> > E> > Yeah, can you explain please why do we need them here? The pfil hooks E> > are always run already in some defined VNET context, don't they? E> > E> E

Re: [PATCH] resolve byte order mess in ip_input/ip_output/pfil(9)

2012-10-05 Thread Gleb Smirnoff
Ermal, On Fri, Oct 05, 2012 at 03:01:38PM +0200, Ermal Lu?i wrote: E> it would be better to switch to net byte order allover rather than E> trade one for the other. E> This makes it even more tricky to understand the code than it is. E> If you do the work its better to do the full thing in one s

[PATCH] resolve byte order mess in ip_input/ip_output/pfil(9)

2012-10-05 Thread Gleb Smirnoff
Hello, once the pfil(9) API was introduced in FreeBSD, our main packet filter, the ipfw(4) worked in host byte order, that's why the pfil(9) API was violated: the AF_INET hooks were entered with packet in host byte order. If you look into pfil(9) manpage you'll see that it still declares op

Re: [CFT] if_transmit method for lagg(4)

2012-09-20 Thread Gleb Smirnoff
Hi! On Thu, Sep 20, 2012 at 08:37:19PM +1200, Andrew Thompson wrote: A> > Yet another patch to test. Was suprising to me that lagg(4), which A> > aims at high-performance, still utilizes if_start. A> > A> > Attached is patch that converts lagg(4) to use if_transmit. I'd A> > appreciate if so

[CFT] if_transmit method for lagg(4)

2012-09-20 Thread Gleb Smirnoff
Hi, Yet another patch to test. Was suprising to me that lagg(4), which aims at high-performance, still utilizes if_start. Attached is patch that converts lagg(4) to use if_transmit. I'd appreciate if someone who do use lagg(4) tests the patch. If anyone benchmarks lagg(4) with and w/o patch

Re: What's the latest on fixing IFF_DRV_OACTIVE/if_start/etc?

2012-09-19 Thread Gleb Smirnoff
On Mon, Sep 17, 2012 at 01:16:45PM -0400, John Baldwin wrote: J> On Monday, September 17, 2012 11:49:59 am Ryan Stone wrote: J> > I know that there have been a lot of discussions about fixing how J> > packets are handed off to ifnets due to the current methods being J> > extremely race-prone. Has

Re: getting counters for a plenty of vlan ifaces

2012-09-19 Thread Gleb Smirnoff
On Sun, Sep 16, 2012 at 09:41:19PM +0700, Ivan Alexandrovich wrote: I> Hi I> I> We are running freebsd9.0 on a router with I> more than 1000 of subscriber's vlan interfaces. I> Outgoing packet rate is approximately 40 kpps. I> I> There's a need to collect bytes and packets I> counters for all tho

Re: moving pfil consumers to sys/netpfil

2012-09-14 Thread Gleb Smirnoff
On Fri, Sep 14, 2012 at 10:33:40AM +0200, Luigi Rizzo wrote: L> On Fri, Sep 14, 2012 at 11:23:50AM +0400, Gleb Smirnoff wrote: L> > On Thu, Sep 13, 2012 at 10:57:21PM +0200, Luigi Rizzo wrote: L> > L> On Thu, Sep 13, 2012 at 11:31:25PM +0400, Gleb Smirnoff wrote: L> > L>

Re: moving pfil consumers to sys/netpfil

2012-09-13 Thread Gleb Smirnoff
On Thu, Sep 13, 2012 at 07:41:05PM +0200, Luigi Rizzo wrote: L> Second: L>What i contest is the fact that you classify ipfw as a "pfil client", L>when pfil is just a tiny adaptation layer to access ipfw. L>I mentioned the three alternative APIs (netmap, netfilter, ndis) L>to witness

moving pfil consumers to sys/netpfil

2012-09-12 Thread Gleb Smirnoff
Hi, we (me and Bjoern) would like to establish a single place for all kinds of pfil(9) consumers, for current ones and for future as well. The place chosen is sys/netpfil. On first round we'd like to move there our Tier-1 firewalls: ipfw and pf. This also includes moving pf out of contri

Re: kernel: arpresolve: can't allocate llinfo for 65.59.233.102

2012-09-11 Thread Gleb Smirnoff
On Tue, Sep 11, 2012 at 01:03:56PM -0700, Vijay Singh wrote: V> > V> V> > V> Could this be http://svnweb.freebsd.org/base/head/sys/netinet/in.c?r1=226120&r2=226224&pathrev=226331 V> > V> > Why do you suspect this one? V> V> I was hitting a similar issue in 8.2. After down/up on the interface V> t

Re: kernel: arpresolve: can't allocate llinfo for 65.59.233.102

2012-09-11 Thread Gleb Smirnoff
On Tue, Sep 11, 2012 at 10:35:25AM -0700, Vijay Singh wrote: V> On Tue, Sep 11, 2012 at 10:29 AM, Adrian Chadd wrote: V> > On 11 September 2012 09:01, Dominic Blais wrote: V> >> I could do something about the route monitor but not the fstat | grep route... I mean, I would have to run it in a loo

Re: kernel: arpresolve: can't allocate llinfo for 65.59.233.102

2012-09-11 Thread Gleb Smirnoff
On Tue, Sep 11, 2012 at 09:19:59AM -0400, Dominic Blais wrote: D> Hi! D> D> I just noticed that it is my default route that is changing for the aforementioned in the subject IP address. What the "$?% could cause that? Could MPD push that route as default? For what reason? That IP address doesn't

Re: kernel: arpresolve: can't allocate llinfo for 65.59.233.102

2012-09-10 Thread Gleb Smirnoff
On Mon, Sep 10, 2012 at 09:29:44AM -0400, Dominic Blais wrote: D> Hi, D> D> We have a PPPoE server running FreeBSD 9.0-RELEASE-p3 with mpd-5.6. It used to work very well for 6 weeks and now the "Internet traffic" stops almost each day. D> D> Symptoms: D> D> - I still can ssh to the server from

Re: stable/9 igb(4) panic, udp_append

2012-09-07 Thread Gleb Smirnoff
On Fri, Sep 07, 2012 at 12:35:53AM -0700, Sean Bruno wrote: S> Just noted this happened today, running stable/9 ish from august 10th. S> It looks like I got a good and valid crashdump off of this if anyone is S> interested. ... S> --- trap 0xc, rip = 0x80731312, rsp = 0xff846c8977d0, rb

Re: [HEADS UP] merging projects/pf into head

2012-09-06 Thread Gleb Smirnoff
Ermal, On Wed, Sep 05, 2012 at 10:09:23PM +0200, Ermal Lu?i wrote: E> Its good to see results on your work and is good moving forward. E> Claiming better behavior, under DoS or other comparison without showing any data E> or technical reason is a bit over this RFC. Benchmark by authors are alw

[HEADS UP] merging projects/pf into head

2012-09-05 Thread Gleb Smirnoff
Hi! [announce goes both to net@ and pf@, but any discussion should go on on p...@freebsd.org only, please] As you already may now, last half a year I've been working on making pf SMP-scalable and faster in general. More info can be found here: http://lists.freebsd.org/pipermail/freebsd-

Re: ports/124825: tcpdump/print-pfsync feature request submitted to tcpdump on sourceforge

2012-09-03 Thread Gleb Smirnoff
On Sun, Sep 02, 2012 at 06:57:00PM +0200, Kurt Jaeger wrote: K> > I added some pointer to your PR at: K> > K> > https://sourceforge.net/tracker/?func=detail&atid=469576&aid=3467532&group_id=53066 K> K> The answer to that pointer was from K> http://sourceforge.net/users/guy_harris/ K> K> --

[CFT] if_transmit method for if_bridge(4)

2012-08-30 Thread Gleb Smirnoff
Hi, I have a patch laying around, that makes if_bridge(4) utilize if_transmit method. That should improvide performance. I'd appreciate if someone who actually do use if_bridge(4) tests this patch. -- Totus tuus, Glebius. Index: if_bridge.c

Re: kern/165863

2012-08-02 Thread Gleb Smirnoff
On Tue, Jul 31, 2012 at 10:43:42PM +0400, Andrey Zonov wrote: A> Please review attached patch. I used Gleb's ideas. He almost fixed the A> issue, but he didn't observe that entry can be safely unlocked in A> arptimer() because it has refcnt incremented and cannot be removed. I A> also fixed e

Re: svn commit: r238277 - in head: etc/defaults etc/rc.d sbin/ipfw share/man/man5 sys/netinet/ipfw

2012-07-10 Thread Gleb Smirnoff
Hiroki, On Tue, Jul 10, 2012 at 05:30:02AM +0900, Hiroki Sato wrote: H> Given that we add a new API to H> enumerate the interfaces including bpf-only providers with fake H> ifnets, which providers/utilities should be converted to use it? IMO H> usbusN would be a reasonable target but others

Re: mpd5/Netgraph issues after upgrading to 7.4

2012-07-09 Thread Gleb Smirnoff
On Tue, Jul 10, 2012 at 12:03:36PM +0700, Eugene Grosbein wrote: E> 10.07.2012 03:25, Ryan Stone пишет: E> > On Mon, Jul 9, 2012 at 4:12 AM, Gleb Smirnoff wrote: E> >> This looks very much related to a known race in ARP code. E> >> E> >> See this email

Re: mpd5/Netgraph issues after upgrading to 7.4

2012-07-09 Thread Gleb Smirnoff
On Sat, Jul 07, 2012 at 10:26:46AM +0200, Przemyslaw Frasunek wrote: P> > After reenabling IPv6, the crash occurred within 6 hours. This time, crashdump P> > was properly saved (thanks to patch suggested by Eugene). P> P> My PPPoE BRAS was stable for 17 days. This morning, it crashed in another

Re: mpd5/Netgraph issues after upgrading to 7.4

2012-06-15 Thread Gleb Smirnoff
On Fri, Jun 15, 2012 at 01:33:05PM +0200, Przemyslaw Frasunek wrote: P> unfortunately, one of my mpd5 PPPoE access servers started panicing every few P> hours. P> P> I'm running recent 8.3-STABLE (as of 23th May) with WITNESS, INVARIANTS and P> DEBUG_MEMGUARD compiled. Unfortunately, I'm unable to

[CFT] SMP-friendly pf

2012-06-07 Thread Gleb Smirnoff
Hello, networkers! [net@ in Cc, but further discussion should go on pf@] As you already probably know, or some may be don't yet know, the pf(4) subsystem in FreeBSD is currently working under a single mutex. This mutex is acquired right at the beginning of any packet processing, and is drop

CFR: if_group events Was: [gleb...@freebsd.org: svn commit: r236168 - projects/pf/head/sys/net]

2012-05-28 Thread Gleb Smirnoff
quot;group removal" event. Looks like an unneeded explicitness and tautology to me. Your opinions? - Forwarded message from Gleb Smirnoff - Date: Mon, 28 May 2012 08:50:01 + (UTC) From: Gleb Smirnoff To: src-committ...@freebsd.org, svn-src-proje...@freebsd.org Subject: svn commi

Re: kern/165863

2012-04-09 Thread Gleb Smirnoff
Thanks, Ryan! On Thu, Mar 29, 2012 at 05:59:38PM -0400, Ryan Stone wrote: R> Ok, I think that I have an approach that will work. This is heavily R> based off of glebius' proposal. The big difference is that instead of R> initializing the arptimer callout with the ll_entry's lock, I R> initiali

Re: kern/165863

2012-03-27 Thread Gleb Smirnoff
On Tue, Mar 27, 2012 at 04:36:59PM -0400, Ryan Stone wrote: R> > From: Gleb Smirnoff R> > To: Eric van Gyzen , R> >        Eric van Gyzen , ema...@freebsd.org R> > Cc: bug-follo...@freebsd.org R> > Subject: kern/165863 R> > Date: Fri, 9 Mar 2012 13:20:56 +

Re: kern/166255: [net] [patch] It should be possible to disable "promiscuous mode enabled" messages

2012-03-22 Thread Gleb Smirnoff
The following reply was made to PR kern/166255; it has been noted by GNATS. From: Gleb Smirnoff To: Eugene Grosbein Cc: freebsd-gnats-sub...@freebsd.org Subject: Re: kern/166255: [net] [patch] It should be possible to disable "promiscuous mode enabled" messages Date: Thu, 22 Mar 201

kern/165863

2012-03-09 Thread Gleb Smirnoff
The following reply was made to PR kern/165863; it has been noted by GNATS. From: Gleb Smirnoff To: Eric van Gyzen , Eric van Gyzen , ema...@freebsd.org Cc: bug-follo...@freebsd.org Subject: kern/165863 Date: Fri, 9 Mar 2012 13:20:56 +0400 --BXVAT5kNtrzKuDFl Content-Type: text/plain

Re: deleting an alias from interface cause the static route to be deleted

2012-02-23 Thread Gleb Smirnoff
On Tue, Feb 21, 2012 at 10:55:58PM +0200, Коньков Евгений wrote: К> >> vlan74: flags=8843 metric 0 mtu 1500 К> >>        options=3 К> >>        ether f4:6d:04:7c:7b:d3 К> >>        inet6 fe80::f66d:4ff:fe7c:7bd3%vlan74 prefixlen 64 scopeid 0xd К> >>        inet 10.1.26.1 netmask 0xfe00 broadca

Re: Assigning multiple IPs in the same network to an interface

2012-02-21 Thread Gleb Smirnoff
On Sat, Feb 18, 2012 at 05:28:22AM +, Li, Qing wrote: L> Yes, what you are trying to do is allowed and is supported. In fact several bugs L> were fixed to support such configuration properly. For example, see these commits: L> L> http://svnweb.freebsd.org/base?view=revision&revision=22

Re: Abstracting struct ifnet

2012-02-17 Thread Gleb Smirnoff
On Thu, Feb 16, 2012 at 08:16:22PM -0800, Marcel Moolenaar wrote: M> All, M> M> Juniper is in the final phases of creating a clean separation M> between FreeBSD and Junos, so as to make upgrades of FreeBSD M> easier. This also allows Juniper to track -current and be more M> active FreeBSD contribu

Re: [PATCH] multiple instances of ipfw(4)

2012-02-08 Thread Gleb Smirnoff
On Wed, Feb 08, 2012 at 03:04:09PM +0100, Ermal Lu?i wrote: E> 2012/2/8 Gleb Smirnoff : E> > On Tue, Jan 31, 2012 at 12:02:04PM +0100, Luigi Rizzo wrote: E> > L> if i understand what the patch does, i think it makes sense to be E> > L> able to hook ipfw instances to

Re: kern/161899: Repeating RTM_MISS packets causing high CPU load for ntpd

2012-02-08 Thread Gleb Smirnoff
On Wed, Feb 08, 2012 at 01:44:56PM -, Steven Hartland wrote: S> - Original Message - S> From: "Gleb Smirnoff" S> > > Any update on this, would have been nice to see a fix hit before S> > > 9.0. If you need any more information please let me know. S&g

Re: [PATCH] multiple instances of ipfw(4)

2012-02-08 Thread Gleb Smirnoff
On Tue, Jan 31, 2012 at 12:02:04PM +0100, Luigi Rizzo wrote: L> if i understand what the patch does, i think it makes sense to be L> able to hook ipfw instances to specific interfaces/sets of interfaces, L> as it permits the writing of more readable rulesets. Right now the L> workaround is start th

Re: m_pullup - fail

2012-02-08 Thread Gleb Smirnoff
On Fri, Feb 03, 2012 at 07:03:11AM +0900, rozhuk...@gmail.com wrote: r> I am writing a netgraph node for processing UDP packets passing through the r> router / bridge. r> Node must fully inspect the entire contents of the package, in some cases, r> change them. In this case you need something like

Re: [PATCH] if_lagg driver enhancements.

2012-02-08 Thread Gleb Smirnoff
On Tue, Feb 07, 2012 at 02:30:08PM +, Tushar Mulkar wrote: T> Hello, T> A patch is developed that has following enhancements in lagg driver T> T> - Sending a gratuitous ARP when link state changes on primary port of T> lag (kern/156226) T> - Support of new ioctl command to change primary po

Re: kern/161899: [route] ntpd(8): Repeating RTM_MISS packets causing high CPU load for ntpd

2012-02-08 Thread Gleb Smirnoff
Dmitrij, On Wed, Feb 08, 2012 at 10:50:11AM +, Dmitrij Tejblum wrote: D> I would suggest to remove RTM_MISS messages at all. I believe that there D> is no sofware that actually use it. OTOH, in some cases RTM_MISS D> messages are really disturbing. D> D> E.g., a router without defaul

Re: kern/161899: Repeating RTM_MISS packets causing high CPU load for ntpd

2012-02-08 Thread Gleb Smirnoff
The following reply was made to PR kern/161899; it has been noted by GNATS. From: Gleb Smirnoff To: Steven Hartland Cc: freebsd-gnats-sub...@freebsd.org Subject: Re: kern/161899: Repeating RTM_MISS packets causing high CPU load for ntpd Date: Wed, 8 Feb 2012 16:59:44 +0400 > Any update

Re: call for review: 802.11q QinQ netgraph support

2012-02-08 Thread Gleb Smirnoff
On Tue, Feb 07, 2012 at 03:27:10PM -0800, Adrian Chadd wrote: A> I've been working with the patch author on this and although I haven't A> yet had time to test it out myself, he's taken my suggestions on board A> and continued improving things. A> A> The patch can be found in the PR: A> A> http:/

Re: kern/164696: VIMAGE + carp panics the kernel

2012-02-06 Thread Gleb Smirnoff
The following reply was made to PR kern/164696; it has been noted by GNATS. From: Gleb Smirnoff To: Nikos Vassiliadis Cc: freebsd-gnats-sub...@freebsd.org Subject: Re: kern/164696: VIMAGE + carp panics the kernel Date: Mon, 6 Feb 2012 15:47:41 +0400 --TakKZr9L6Hm6aLOc Content-Type: text

Re: ng_bridge and locks

2012-01-24 Thread Gleb Smirnoff
On Tue, Jan 24, 2012 at 06:09:30AM +0900, rozhuk...@gmail.com wrote: r> I found a comment in the code: r> /* r> * This node has all kinds of stuff that could be screwed by SMP. r> * Until it gets it's own internal protection, we go through in r> * single file. This could hur

removing support for SIOCSIF{ADDR,NETMASK,BRDADDR,DSTADDR}

2012-01-12 Thread Gleb Smirnoff
Hello, networkers! I'd like to remove from kernel support for several really outdated ioctls: SIOCSIFADDR SIOCSIFNETMASK SIOCSIFBRDADDR SIOCSIFDSTADDR Actually their support was always only declared, you can trigger panics easily if you play with them. These ioctls were outdated eve

Re: ng_mppc_decompress: too many (4094) packets dropped, disabling node

2012-01-05 Thread Gleb Smirnoff
On Thu, Jan 05, 2012 at 03:43:45PM +0200, Sami Halabi wrote: S> Hmm.. S> S> Somthing strange, i did: S> net.graph.recvspace=8388608 S> net.graph.maxdgram=8388608 S> S> S> and i suddenly got disconnections and logs like: S> Jan 5 16:10:01 mpd2 mpd: L2TP: ppp_l2tp_ctrl_create: No buffer space S>

Re: ng_mppc_decompress: too many (4094) packets dropped, disabling node

2012-01-05 Thread Gleb Smirnoff
Sami, I am running not with the exact patch that I've sent to you, but with additional debugging printf, see attach. I'd like to make sure that after such a large rekeying event the PPP link is still valid. Since I can't cook this reordering case by hand, can you please eventually patch your

Re: ng_mppc_decompress: too many (4094) packets dropped, disabling node

2012-01-05 Thread Gleb Smirnoff
On Thu, Jan 05, 2012 at 01:21:12PM +0200, Sami Halabi wrote: S> Hi S> S> after i upgraded the recvspace here are the results: S> # ./a S> Rec'd response "getsessconfig" (4) from "[22995]:": S> Args: { session_id=0xcf4 peer_id=0x1bdc control_dseq=1 enable_dseq=1 } S> Rec'd response "getsessconfig

Re: ng_mppc_decompress: too many (4094) packets dropped, disabling node

2012-01-05 Thread Gleb Smirnoff
On Thu, Jan 05, 2012 at 12:48:05PM +0200, Sami Halabi wrote: S> Hi, S> there is a problem whith this script: S> S> # ngctl ls | awk '{ if ($4 == "l2tp") print $6}' S> ngctl: send msg: No buffer space available You have so much nodes, that 'ngctl ls' can't pass its reply to userland. Try to bump

Re: ng_mppc_decompress: too many (4094) packets dropped, disabling node

2012-01-05 Thread Gleb Smirnoff
Sami, I'm trying to reproduce a reordering problem with a new node, and I've found that: 1) PPTP uses sequencing, that would not pass out of sequence datagram to the PPP, and thus to MPPE. 2) L2TP uses sequencing optionally, so the problem in subject may appear only on an L2TP link with

Re: kernel: nd6_setmtu0: new link MTU on ng29 (1218) is too small for IPv6

2012-01-04 Thread Gleb Smirnoff
On Wed, Jan 04, 2012 at 12:59:18PM +0200, Sami Halabi wrote: S> I'm using a FreeBSD8.2-R-p5 in conjunction with MPD5.5 port for creating S> pptp/l2tp tunnels. S> S> I'm using MPPC (Compression & Encryption), my current onfiguration i use S> only IPv4. S> S> I keep getting in the logs the followin

Re: ng_mppc_decompress: too many (4094) packets dropped, disabling node

2011-12-30 Thread Gleb Smirnoff
Sami, On Tue, Dec 27, 2011 at 11:08:47PM +0200, Sami Halabi wrote: S> Thanks for your patch, i applied it and its production already. S> i had to stop mpd, and once started it i saw that all home routers S> connected immediatly. S> most of them don't use mppc, so I wonder why this problem happen

Re: Transitioning if_addr_lock to an rwlock

2011-12-29 Thread Gleb Smirnoff
On Thu, Dec 29, 2011 at 03:27:26PM -0500, John Baldwin wrote: J> - if_addr_uses.patch This changes callers of the existing macros to use J> either read or write locks. This is the patch that J> could use the most review. Reviewing your patch I

Re: Transitioning if_addr_lock to an rwlock

2011-12-29 Thread Gleb Smirnoff
On Thu, Dec 29, 2011 at 11:36:01AM -0500, John Baldwin wrote: J> On Monday, December 26, 2011 11:17:28 pm Gleb Smirnoff wrote: J> > On Thu, Dec 22, 2011 at 11:30:01AM -0500, John Baldwin wrote: J> > J> You can find the patch for 8.x at J> > J> http://w

Re: ng_mppc_decompress: too many (4094) packets dropped, disabling node

2011-12-27 Thread Gleb Smirnoff
On Tue, Dec 27, 2011 at 09:44:23AM +0200, Sami Halabi wrote: S> >1) Is the number always 4094? S> S> No, i see 4092, 4093 also: S> Dec 24 09:17:04 mpd2 kernel: ng_mppc_decompress: too many (4092) packets S> dropped S> , disabling node 0xff003051e400! S> Dec 24 09:17:04 mpd2 kernel: S> Dec 24 1

Re: Transitioning if_addr_lock to an rwlock

2011-12-27 Thread Gleb Smirnoff
On Tue, Dec 27, 2011 at 11:29:02AM +0100, Ermal Lu?i wrote: E> 2011/12/27 Gleb Smirnoff : E> > On Thu, Dec 22, 2011 at 11:30:01AM -0500, John Baldwin wrote: E> > J> You can find the patch for 8.x at E> > J> http://www.freebsd.org/~jhb/patches/if_addr_rwlock.patch E> &

Re: ng_mppc_decompress: too many (4094) packets dropped, disabling node

2011-12-27 Thread Gleb Smirnoff
Sami, On Tue, Dec 27, 2011 at 10:42:58AM +0200, Sami Halabi wrote: S> i see in the logs many 4092, and a bit 4093 and 4094 as the log shows. S> S> I applied the both patches (the one you sent and the on on the pr) but i S> didn't load the new module yet: S> # kldunload ng_mppc S> kldunload: can

Re: ng_mppc_decompress: too many (4094) packets dropped, disabling node

2011-12-26 Thread Gleb Smirnoff
On Thu, Dec 15, 2011 at 09:51:09PM +0200, Sami Halabi wrote: S> I've searched the net andfound basicly 2 threads talking about the message: S> S> ng_mppc_decompress: too many (4094) packets dropped, disabling node The 4094 value both in your report and in the old PR look suspicious. Can you plea

Re: ng_mppc_decompress: too many (4094) packets dropped, disabling node

2011-12-26 Thread Gleb Smirnoff
On Thu, Dec 15, 2011 at 09:51:09PM +0200, Sami Halabi wrote: S> Hi, S> S> I've searched the net andfound basicly 2 threads talking about the message: S> S> ng_mppc_decompress: too many (4094) packets dropped, disabling node S> S> in FBSD 6.3 S> http://lists.freebsd.org/pipermail/freebsd-bugs/200

Re: ng_mppc_decompress: too many (4094) packets dropped, disabling node

2011-12-26 Thread Gleb Smirnoff
On Thu, Dec 15, 2011 at 09:51:09PM +0200, Sami Halabi wrote: S> Hi, S> S> I've searched the net andfound basicly 2 threads talking about the message: S> S> ng_mppc_decompress: too many (4094) packets dropped, disabling node S> S> in FBSD 6.3 S> http://lists.freebsd.org/pipermail/freebsd-bugs/200

Re: Transitioning if_addr_lock to an rwlock

2011-12-26 Thread Gleb Smirnoff
On Thu, Dec 22, 2011 at 11:30:01AM -0500, John Baldwin wrote: J> You can find the patch for 8.x at J> http://www.freebsd.org/~jhb/patches/if_addr_rwlock.patch Just my two pennies: for head/ patching if ip_carp.c should be straightforward: 1) Using W in carp_alloc_if() and carp_free_if(). 2) Usin

Re: bsnmpd not showing out octets for vlan interfaces

2011-12-26 Thread Gleb Smirnoff
On Mon, Dec 26, 2011 at 07:25:29PM -0800, YongHyeon PYUN wrote: Y> Index: sys/net/if_vlan.c Y> === Y> --- sys/net/if_vlan.c(revision 228906) Y> +++ sys/net/if_vlan.c(working copy) Y> @@ -1012,10 +1012,12 @@ Y> { Y>

Re: Bug in MPD maybe Netgraph related?

2011-11-29 Thread Gleb Smirnoff
Dominic, On Tue, Nov 29, 2011 at 10:55:33AM -0500, Dominic Blais wrote: D> On a PPPoE server running MPD (using netgraph) I got a bunch of logs < from unknown hook "M-^B^C^H" > at an incredible pace... Then MPD closed every connections and stopped. I provided a log just before it started. You

Re: arprequest triggered panic

2011-11-23 Thread Gleb Smirnoff
On Wed, Nov 23, 2011 at 01:09:34PM +0200, Nikos Vassiliadis wrote: N> On 11/22/2011 9:48 PM, Gleb Smirnoff wrote: N> > Can't reproduce this on head. May be some additional measures are needed? Traffic? N> N> Just noticed that the panic does not happen using GENERIC.

Re: arprequest triggered panic

2011-11-22 Thread Gleb Smirnoff
Nikos, On Fri, Nov 18, 2011 at 01:10:47PM +0200, Nikos Vassiliadis wrote: N> I was playing with lagg and found out a kernel panic. Here is N> the backtrace: N> > #5 0xc0a65613 in kdb_trap (type=12, code=0, tf=0xc3f1bb1c) at /usr/src/sys/kern/subr_kdb.c:625 N> > #6 0xc0dbbc1f in trap_fatal (fr

Re: FreeBSD 9 and ARP multicast source address error messages

2011-11-21 Thread Gleb Smirnoff
Alexander, On Thu, Nov 10, 2011 at 12:42:15PM -0500, Alexander Wittig wrote: A> > Can you try attached patch. It reduces severity level of all ARP A> > messages, that can be triggered by packet on network, with expection to A> > "using my IP address". A> > A> > With default syslog.conf, now ARP

Re: Possible MROUTING regression in 9.0 RC1

2011-11-10 Thread Gleb Smirnoff
On Thu, Nov 10, 2011 at 12:15:11PM +0400, Pavel Timofeev wrote: P> Thank you! I'll try! P> I'm going crazy. P> Now I can crash even FreeBSD 8.2 RELEASE with igmpproxy in some coincidence. P> P> I can get kernel dump on 8.2, and can try to get dump on 9.0-RC1. Is P> it interesting? Backtrace and d

Re: FreeBSD 9 and ARP multicast source address error messages

2011-11-09 Thread Gleb Smirnoff
Alexander, On Tue, Nov 08, 2011 at 05:14:45PM -0500, Alexander Wittig wrote: A> I upgraded one of my machines from FreeBSD 8 to 9.0-RC1 (FreeBSD bt.pa.msu.edu 9.0-RC1 FreeBSD 9.0-RC1 #3: Fri Oct 28 16:45:28 EDT 2011 r...@bt.pa.msu.edu:/usr/obj/usr/src/sys/ALEX i386), and ever since that

Re: mbuf leak in icmp6 code??

2011-11-07 Thread Gleb Smirnoff
Kristof, On Thu, Nov 03, 2011 at 01:07:52PM +0100, Kristof Provost wrote: K> > For example: K> > K> > icmp6_input calls icmp6_redirect_input and right after it returns it K> > makes m=NULL. Inside icmp6_redirect_input there are checks for ifp and K> > for the message being short (which probably

Re: Undocumented netgraph `cmd' flags ?

2011-11-07 Thread Gleb Smirnoff
On Mon, Oct 31, 2011 at 10:31:25PM -0700, Julian Elischer wrote: J> NGM_HASREPLY is not used that I can see in the kernel. It may be a J> historical artifact or J> maybe only used in the library as a hint. I introduced NGM_HASREPLY. Yes, it is used in library, to make repliable messages synchrono

Re: kern/162110: Releng_9 panics on boot in IGB driver - regression from 8.2

2011-10-31 Thread Gleb Smirnoff
The following reply was made to PR kern/162110; it has been noted by GNATS. From: Gleb Smirnoff To: Frank Terhaar-Yonkers Cc: freebsd-gnats-sub...@freebsd.org, j...@freebsd.org Subject: Re: kern/162110: Releng_9 panics on boot in IGB driver - regression from 8.2 Date: Mon, 31 Oct 2011 22:37:28

Re: misc/162201: [patch] multicast forwarding cache hash always allocated with size 0, resulting in buffer overrun

2011-10-31 Thread Gleb Smirnoff
The following reply was made to PR kern/162201; it has been noted by GNATS. From: Gleb Smirnoff To: Stevan Markovic Cc: freebsd-gnats-sub...@freebsd.org, z...@freebsd.org, b...@freebsd.org, b...@freebsd.org Subject: Re: misc/162201: [patch] multicast forwarding cache hash always

Re: new CARP implementation

2011-10-26 Thread Gleb Smirnoff
Hello networkers, I've rolled out a new patch & README here: http://people.freebsd.org/~glebius/newcarp/ The most important change since last version is not sending spurious graturious ARP announce on startup. -- Totus tuus, Glebius. ___ freeb

Re: kern/155604: [flowtable] Flowtable excessively caches dest MAC addresses for outgoing traffic

2011-10-17 Thread Gleb Smirnoff
The following reply was made to PR kern/155604; it has been noted by GNATS. From: Gleb Smirnoff To: Steve Polyack Cc: bug-follo...@freebsd.org Subject: Re: kern/155604: [flowtable] Flowtable excessively caches dest MAC addresses for outgoing traffic Date: Mon, 17 Oct 2011 21:45:56 +0400 On

kern/155604: [flowtable] Flowtable excessively caches dest MAC addresses for outgoing traffic

2011-10-17 Thread Gleb Smirnoff
The following reply was made to PR kern/155604; it has been noted by GNATS. From: Gleb Smirnoff To: Steve Polyack Cc: bug-follo...@freebsd.org Subject: kern/155604: [flowtable] Flowtable excessively caches dest MAC addresses for outgoing traffic Date: Mon, 17 Oct 2011 19:59:42 +0400 Steve

kern/155030: [igb] igb(4) DEVICE_POLLING does not work with carp(4)

2011-10-15 Thread Gleb Smirnoff
The following reply was made to PR kern/155030; it has been noted by GNATS. From: Gleb Smirnoff To: Martin Matuska Cc: bug-follo...@freebsd.org Subject: kern/155030: [igb] igb(4) DEVICE_POLLING does not work with carp(4) Date: Sat, 15 Oct 2011 18:31:25 +0400 Martin, it isn't clear

kern/144572: [carp] CARP preemption mode traffic partially goes to backup node

2011-10-15 Thread Gleb Smirnoff
The following reply was made to PR kern/144572; it has been noted by GNATS. From: Gleb Smirnoff To: "Eugene M. Zheganin" Cc: bug-follo...@freebsd.org Subject: kern/144572: [carp] CARP preemption mode traffic partially goes to backup node Date: Sat, 15 Oct 2011 18:17:49 +0400

kern/129508: [carp] [panic] Kernel panic with EtherIP (may be related to SVN commit 178025)

2011-10-15 Thread Gleb Smirnoff
The following reply was made to PR kern/129508; it has been noted by GNATS. From: Gleb Smirnoff To: Boris Kochergin Cc: bug-follo...@freebsd.org Subject: kern/129508: [carp] [panic] Kernel panic with EtherIP (may be related to SVN commit 178025) Date: Sat, 15 Oct 2011 12:41:07 +0400 Boris

Re: new CARP implementation

2011-10-14 Thread Gleb Smirnoff
On Fri, Oct 14, 2011 at 09:06:57PM +0200, Andre Oppermann wrote: A> > Won't ifconfig it down work? A> A> Not if I want to continue to use the primary or other non-carp address. Well, the best idea for that case would be switch them to backup mode. In presense of active master, they won't show up

Re: new CARP implementation

2011-10-14 Thread Gleb Smirnoff
On Fri, Oct 14, 2011 at 08:14:34PM +0200, Andre Oppermann wrote: A> On 14.10.2011 20:02, Gleb Smirnoff wrote: A> > On Fri, Oct 14, 2011 at 07:43:33PM +0200, Andre Oppermann wrote: A> > A> On 13.10.2011 18:02, Gleb Smirnoff wrote: A> > A> > Hello networkers,

Re: new CARP implementation

2011-10-14 Thread Gleb Smirnoff
On Fri, Oct 14, 2011 at 07:43:33PM +0200, Andre Oppermann wrote: A> On 13.10.2011 18:02, Gleb Smirnoff wrote: A> >Hello networkers, A> > A> >I've updated patch& README here: A> > A> >http://people.freebsd.org/~glebius/newcarp/ A> > A&

Re: new CARP implementation

2011-10-13 Thread Gleb Smirnoff
Hello networkers, I've updated patch & README here: http://people.freebsd.org/~glebius/newcarp/ Going to commit it to head/ soon. Then I'd like to make a run through carp-related PRs, update documentation, settle things a bit... and then make more hacking to restore the arpbalance featur

Re: new CARP implementation

2011-08-15 Thread Gleb Smirnoff
On Mon, Aug 15, 2011 at 07:56:14AM -0500, David Duchscher wrote: D> > On Sun, Aug 14, 2011 at 03:56:28PM -0500, David Duchscher wrote: D> > D> > On Sat, Aug 13, 2011 at 07:32:06PM -0500, David Duchscher wrote: D> > D> > D> My two cents. D> > D> > D> D> > D> > D> We rely on the arp load balance fea

Re: new CARP implementation

2011-08-15 Thread Gleb Smirnoff
Hi David and networkers, On Sun, Aug 14, 2011 at 03:56:28PM -0500, David Duchscher wrote: D> > On Sat, Aug 13, 2011 at 07:32:06PM -0500, David Duchscher wrote: D> > D> My two cents. D> > D> D> > D> We rely on the arp load balance feature. We certainly don't find it useless. Looking at ip loa

Re: new CARP implementation

2011-08-14 Thread Gleb Smirnoff
On Sat, Aug 13, 2011 at 07:32:06PM -0500, David Duchscher wrote: D> My two cents. D> D> We rely on the arp load balance feature. We certainly don't find it useless. Looking at ip load balancing, it would also mean that we would no longer be able to grow bandwidth with additional systems since

Re: new CARP implementation

2011-08-14 Thread Gleb Smirnoff
On Fri, Aug 12, 2011 at 11:04:14PM -0700, Rudy (bulk) wrote: R> > I'd like to present for review and early testing (for brave ones) R> > a new CARP implementation. R> R> Super! I'll use it but am not brave enough for alpha. Maybe beta. :) R> R> Will this support multiple VHID per interface?

Re: new CARP implementation

2011-08-11 Thread Gleb Smirnoff
On Thu, Aug 11, 2011 at 02:47:08PM -0700, Freddie Cash wrote: F> > On Wed, Aug 10, 2011 at 09:38:04AM -0700, Freddie Cash wrote: F> > F> However, I'm not sure I understand the reasoning for removing the carpX F> > F> pseudo-interface. It's really nice having the symmetry between carpX, F> > F> vla

Re: new CARP implementation

2011-08-11 Thread Gleb Smirnoff
On Wed, Aug 10, 2011 at 09:38:04AM -0700, Freddie Cash wrote: F> However, I'm not sure I understand the reasoning for removing the carpX F> pseudo-interface. It's really nice having the symmetry between carpX, F> vlanX, brX, and other pseudo-interfaces, and keeping the configuration F> details sep

new CARP implementation

2011-08-10 Thread Gleb Smirnoff
Hello networkers, I'd like to present for review and early testing (for brave ones) a new CARP implementation. The reason for this rewrite was that CARP protocol actually doesn't bring a new interface, but is a property of interface address. Rewriting it in this way helps to remove several hac

Re: m_pkthdr.rcvif dangling pointer problem

2011-07-25 Thread Gleb Smirnoff
On Sun, Jul 24, 2011 at 09:43:59AM +0100, Robert N. M. Watson wrote: R> Instead, I think we should go for a more radical notion, which is a bit harder to implement in our stack: the network stack needs a race-free way to "drain" all mbufs referring to a particular ifnet, which does not cause exi

<    1   2   3   4   5   6   7   8   >