[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

glebius added a comment. In D23788#523247 , @neel_neelc.org wrote: > I still get "ngctl: send msg: Invalid argument" errors with the commands in the Test Plan. Am I doing anything wrong? Well, you've added 3 new places that could return EIN

[Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE

glebius requested changes to this revision. glebius added a comment. This revision now requires changes to proceed. I got few minor comments. INLINE COMMENTS > ng_pppoe.c:1135 > + /* Generate a packet of that type. */ > + MGETHDR(m, M_NOWAIT, MT_DATA);

[Differential] D9345: ifnet: move the new ifnet_event EVENTHANDLER_DECLARE to net/if_var.h

glebius accepted this revision. This revision has a positive review. REVISION DETAIL https://reviews.freebsd.org/D9345 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: decui_microsoft.com, hselasky, sepherosa_gmail.com, cem, np, kmacy, kib, honzhan_microsof

[Differential] D8904: inet: Fix routing issue by calling if_up()

glebius added a comment. I don't think that the patch is in the right direction. The problem comes from historical behavior that assigning an address is implicit UP. For a modern networking equipment it is a normal administrative situation that sysadmin wants to assign an address or an alias

[Differential] D8740: remove network mask calculation for Classful network

glebius accepted this revision. glebius added a comment. This revision has a positive review. This looks correct to me. But I haven't reviewed the consequences of writing directly to the "netmask", which is also shared with rarp.c and udp.c Thanks! REVISION DETAIL https://reviews.freeb

[Differential] [Requested Changes To] D1944: PF and VIMAGE fixes

glebius requested changes to this revision. glebius added a comment. This revision now requires changes to proceed. Thanks a lot, Nikos. I've fixed the problem of sleeping in UMA on kldunload. It was out the scope of the patch. I also committed the first part of the patch - mutexes initializati

[Differential] [Commented On] D1944: PF and VIMAGE fixes

glebius added a comment. Recently Nikos has asked questions on kernel debugging. So, I guess, he is working. REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, zec, trociny, glebius, rodri

[Differential] [Accepted] D1982: Fix return errors in tcp_usrreq.c

glebius added a subscriber: glebius. glebius accepted this revision. glebius added a reviewer: glebius. glebius added a comment. And I second on jch@ comment. REVISION DETAIL https://reviews.freebsd.org/D1982 To: harrison.grundy-astrodoggroup.com, gnn, adrian, jch, glebius Cc: glebius, freebsd

[Differential] [Updated] D1944: PF and VIMAGE fixes

glebius added a comment. Nikos, acking that I see the patches. Right now I'm waiting for pf to stablize after recent patches to fragment handling. Kristof is working on the known problem. Meanwhile you can finish your patch moving from "almost there" to "there" :) If you got any questions about

[Differential] [Commented On] D1965: Add extended media types to if_media.h and ifconfig

glebius added a comment. Is it possible to add Mike Karels to this discussion? REVISION DETAIL https://reviews.freebsd.org/D1965 To: erj, gnn, jfvogel, adrian Cc: glebius, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/

[Differential] [Changed Subscribers] D1965: Add extended media types to if_media.h and ifconfig

glebius added a subscriber: glebius. glebius added a comment. We can't and don't plan to preserve the driver KPI for the 11 branch. We actually plan to change it very much, in sake of keeping it stable there on. Please see on what is going on in the projects/ifnet branch. So, I'd suggest to intro

[Differential] [Updated] D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets

glebius added a reviewer: ken. glebius added a comment. This is Ken's code, we probably want him to look at. Looks like a remnant from zero copy era. REVISION DETAIL https://reviews.freebsd.org/D1893 To: hselasky, pluknet, ae, np, melifaro, glebius, hrs, wollman, bryanv, rpaulo, adrian, bz,

[Differential] [Accepted] D1766: Factor out ip6_fragment()

glebius accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1766 To: kristof, glebius Cc: glebius, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/

[Differential] [Accepted] D1765: PF: Handle fragmented IPv6 packets

glebius accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1765 To: kristof, glebius Cc: glebius, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/

[Differential] [Commented On] D1765: PF: Handle fragmented IPv6 packets

glebius added a comment. Thanks. Now let me complete universe with anonymous structs/unions on. INLINE COMMENTS sys/netpfil/pf/pf_norm.c:88 This line looks like cut-n-paste typo. Don't hurry to fix, I am about to improve the code to use anonymous structure, which, I hope, will be enabled for

[Differential] [Commented On] D1764: Factor out ip6_deletefraghdr()

glebius added a comment. Damn f*ckbrikator doesn't allow me to close the revision, since I don't own it. Kristof, looks like you will need to manually close all your revisions as I commit them. Or we can just leave some trash in this "pretty" software. REVISION DETAIL https://reviews.freebsd.

[Differential] [Accepted] D1764: Factor out ip6_deletefraghdr()

glebius accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1764 To: kristof, ae, glebius Cc: ae, glebius, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/

[Differential] [Accepted] D1766: Factor out ip6_fragment()

glebius added a subscriber: glebius. glebius accepted this revision. glebius added a reviewer: glebius. glebius added a comment. This revision is now accepted and ready to land. Thanks. We also need someone working in netinet6 look into this. INLINE COMMENTS sys/netinet6/ip6_output.c:225 uint32

[Differential] [Accepted] D1765: PF: Handle fragmented IPv6 packets

glebius accepted this revision. glebius added a reviewer: glebius. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1765 To: kristof, glebius Cc: glebius, freebsd-net ___ freebsd-net@freebsd.org mailing lis

[Differential] [Changed Subscribers] D1765: PF: Handle fragmented IPv6 packets

glebius added a subscriber: glebius. glebius added a comment. Kristof, big thanks for working on this. See my comments. INLINE COMMENTS sys/netpfil/pf/pf.c:366 This function can also be used not only for fragment rbtree, but can also substitute the PF_ANEQ, PF_AEQ and could be considered to s

[Differential] [Accepted] D1764: Factor out ip6_deletefraghdr()

glebius added a subscriber: glebius. glebius accepted this revision. glebius added a reviewer: glebius. glebius added a comment. This revision is now accepted and ready to land. Thanks. Patch looks good to me, but see comments. We probably need a nod from a IPv6 expert. I'll send link to ae@. IN