[Differential] D6148: tcp/syncache: Add comment for syncache_respond

2016-05-06 Thread sbruno (Sean Bruno)
sbruno accepted this revision. REVISION DETAIL https://reviews.freebsd.org/D6148 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, transport, adrian, rwatson, gnn, lstewart, glebius, delphij, mike-karels.net, jtl, hiren,

[Differential] D6120: tcp/syncache: Set flowid and hash type properly for SYN|ACK

2016-04-27 Thread sbruno (Sean Bruno)
sbruno accepted this revision. sbruno added a reviewer: sbruno. REVISION DETAIL https://reviews.freebsd.org/D6120 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, transport, adrian, rwatson, gnn, lstewart, glebius, delphij,

[Differential] [Updated] D5853: dhclient: Log a warning instead of bailing upon "illegal" options

2016-04-18 Thread sbruno (Sean Bruno)
sbruno added reviewers: pkelsey, jhb, gnn. sbruno added a comment. spam a few more reviewers who have poked at dhclient in the past. REVISION DETAIL https://reviews.freebsd.org/D5853 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com,

[Differential] [Commented On] D1986: Teach lagg(4) to change MTU

2015-10-01 Thread sbruno (Sean Bruno)
sbruno added a subscriber: sbruno. sbruno added a comment. In https://reviews.freebsd.org/D1986#77466, @lakshmi.n_msystechnologies.com wrote: > We (Panasas) tried reproducing the problem by applying the patch and enabled > WITNESS in freebsd stable (10.1) kernel. > While testing with this

[Differential] [Commented On] D1777: Associated fix for arp/nd6 timer usage.

2015-06-06 Thread sbruno (Sean Bruno)
sbruno added a comment. Should this be closed? REVISION DETAIL https://reviews.freebsd.org/D1777 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rrs, imp, gnn, rwatson, lstewart, kib, adrian, jhb, bz, sbruno Cc: ae, bz, freebsd-net-list, emaste, hiren,

[Differential] [Accepted] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests).

2015-03-24 Thread sbruno (Sean Bruno)
sbruno accepted this revision. sbruno added a comment. This revision is now accepted and ready to land. Randall: I think this needs to be manually closed as the svn commit hook didn't fire when r278469 hit the tree. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson,

[Differential] [Updated] D1777: Associated fix for arp/nd6 timer usage.

2015-03-24 Thread sbruno (Sean Bruno)
sbruno added a comment. Randall: Do you want to close this review as committed? The commit hook doesn't seem to have fired to close this when comitted at svn r278472 REVISION DETAIL https://reviews.freebsd.org/D1777 To: rrs, imp, gnn, rwatson, lstewart, kostikbel, adrian, jhb, bz, sbruno

[Differential] [Accepted] D1777: Associated fix for arp/nd6 timer usage.

2015-03-24 Thread sbruno (Sean Bruno)
sbruno accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1777 To: rrs, imp, gnn, rwatson, lstewart, kostikbel, adrian, jhb, bz, sbruno Cc: ae, bz, emaste, hiren, julian, hselasky, freebsd-net

[Differential] [Updated] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests).

2015-02-03 Thread sbruno (Sean Bruno)
sbruno added a comment. We're dubious over here in actually running this on live systems land. We're seeing pretty chaotic panics, unsure what we should dig into here. Within minutes of running live on a machine, we see various panics in cam or the network stack running this against

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

2015-02-03 Thread sbruno (Sean Bruno)
sbruno added a comment. Sanitized panic #2 Dump header from device /dev/da0s1b Architecture: amd64 Architecture Version: 2 Dump Length: 6752395264B (6439 MB) Blocksize: 512 Dumptime: Mon Feb 2 14:42:05 2015 Hostname: Magic: FreeBSD Kernel

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

2015-02-03 Thread sbruno (Sean Bruno)
sbruno added a comment. Sanitized panic #1 Dump header from device /dev/da0s1b Architecture: amd64 Architecture Version: 2 Dump Length: 6451576832B (6152 MB) Blocksize: 512 Dumptime: Sat Jan 31 21:30:37 2015 Hostname: Magic: FreeBSD Kernel Dump Version