[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

neel_neelc.org updated this revision to Diff 69103. neel_neelc.org added a comment. I forgot a "return(0)" in the IPv6 unparsing. This does not solve the "Invalid argument" errors. However, the issue is not with my code. I tried printfs in the same statements as the EINVAL returns and

[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

neel_neelc.org edited the test plan for this revision. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D23788/new/ REVISION DETAIL https://reviews.freebsd.org/D23788 EMAIL PREFERENCES

[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

glebius added a comment. In D23788#523247 , @neel_neelc.org wrote: > I still get "ngctl: send msg: Invalid argument" errors with the commands in the Test Plan. Am I doing anything wrong? Well, you've added 3 new places that could return

[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

bcr accepted this revision as: manpages. bcr added a comment. OK from manpages. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D23788/new/ REVISION DETAIL https://reviews.freebsd.org/D23788 EMAIL PREFERENCES

[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

neel_neelc.org updated this revision to Diff 68850. neel_neelc.org edited the summary of this revision. neel_neelc.org added a comment. Herald added a reviewer: manpages. Let's include a man page. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE

[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

neel_neelc.org marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D23788/new/ REVISION DETAIL https://reviews.freebsd.org/D23788 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: neel_neelc.org, hrs Cc: hrs, imp,

[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

neel_neelc.org updated this revision to Diff 68730. neel_neelc.org edited the summary of this revision. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D23788?vs=68729=68730 CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D23788/new/ REVISION DETAIL

[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

neel_neelc.org updated this revision to Diff 68729. neel_neelc.org edited the summary of this revision. neel_neelc.org edited the test plan for this revision. neel_neelc.org added a comment. Here, I use inet_pton and inet_ntop. I didn't know this was possible in the kernel, so that's why the

[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

neel_neelc.org edited the summary of this revision. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D23788/new/ REVISION DETAIL https://reviews.freebsd.org/D23788 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/

[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

hrs requested changes to this revision. hrs added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ng_ksocket.c:319 > + > + for (i = 0; i < 8; i++) { > + u_long val; inet_pton in libkern should be used to parse an IPv6 address.

[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

neel_neelc.org updated this revision to Diff 68662. neel_neelc.org added a comment. Remove testing printfs. REPOSITORY rS FreeBSD src repository CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D23788?vs=68661=68662 CHANGES SINCE LAST ACTION

[Differential] D23788: DRAFT: ng_ksocket: IPv6 address parsing and unparsing

neel_neelc.org retitled this revision from "DRAFT: ng_ksocket IPv6 address parsing and unparsing" to "DRAFT: ng_ksocket: IPv6 address parsing and unparsing". neel_neelc.org edited the summary of this revision. neel_neelc.org edited the test plan for this revision. REPOSITORY rS FreeBSD src

[Differential] D23788: DRAFT: ng_ksocket IPv6 address parsing and unparsing

neel_neelc.org created this revision. neel_neelc.org added a project: network. Herald added subscribers: Contributor Reviews (base), melifaro, lutz_donnerhacke.de, imp. REVISION SUMMARY Add IPv6 support to address parsing and unparsing to ng_ksocket. Submitted by: Neel Chauhan Keep