Re: RFC: removing redundant checks in ether_input_internal()

2013-05-29 Thread John Baldwin
On Wednesday, May 22, 2013 10:53:29 am Andre Oppermann wrote: > On 22.05.2013 14:58, Luigi Rizzo wrote: > > if_ethersubr.c :: ether_input_internal() is only called as follows: > > > > static void > > ether_nh_input(struct mbuf *m) > > { > > > > ether_input_internal(m->m_pkth

Re: RFC: removing redundant checks in ether_input_internal()

2013-05-22 Thread Andre Oppermann
On 22.05.2013 14:58, Luigi Rizzo wrote: if_ethersubr.c :: ether_input_internal() is only called as follows: static void ether_nh_input(struct mbuf *m) { ether_input_internal(m->m_pkthdr.rcvif, m); } hence the following checks in the body are unnecessary:

RFC: removing redundant checks in ether_input_internal()

2013-05-22 Thread Luigi Rizzo
if_ethersubr.c :: ether_input_internal() is only called as follows: static void ether_nh_input(struct mbuf *m) { ether_input_internal(m->m_pkthdr.rcvif, m); } hence the following checks in the body are unnecessary: if (m->m_pkthdr.rcvif == NULL) {