Re: iflib tx watchdog doesn't appear that it can work anymore

2020-12-10 Thread Ryan Stone
So what's the plan with the iflib watchdog? If it's not going to be fixed, should it just be removed entirely? I don't think that's a great idea but I remember that the Intel watchdogs got a lot of rototilling to try and get them right so I'm nervous about going in and just trying to reimplement

Re: iflib tx watchdog doesn't appear that it can work anymore

2020-11-10 Thread Ryan Stone
We hit the bug of the watchdog firing on idle NICs and were working on merging r356310 into our tree when we noticed the problem through code inspection. I don't think that it's really a bug with r356310, just a latent one that has become exposed. On Mon, Nov 9, 2020 at 2:48 PM Eric Joyner

Re: iflib tx watchdog doesn't appear that it can work anymore

2020-11-09 Thread Eric Joyner
I'll add Piotr, the author of your linked patch, to this thread. Are you seeing a problem connected to the watchdog? Piotr tells me that IFLIB_QUEUE_WORKING isn't used now, but it wasn't even used before his patch. - Eric On Wed, Nov 4, 2020 at 8:47 AM Ryan Stone wrote: >