Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Julian Elischer
On Fri, 28 May 2004, Gleb Smirnoff wrote: > On Fri, May 28, 2004 at 06:31:18PM +0400, Roman Kurakin wrote: > R> >On Fri, May 28, 2004 at 05:50:21PM +0400, Roman Kurakin wrote: > R> >R> >Here is the first one - convert all ng_type initializers to C99 sparse > R> >R> >type. > R> >R> > > R> >R> H

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Gleb Smirnoff
On Fri, May 28, 2004 at 02:35:35PM -0700, Julian Elischer wrote: J> there are some more nodes in the tree that are not in the J> netgraph directory. Roman already pointed me to them. This mail with small diffs is dealing with them. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE _

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Julian Elischer
there are some more nodes in the tree that are not in the netgraph directory. On Fri, 28 May 2004, Gleb Smirnoff wrote: > On Fri, May 28, 2004 at 01:31:09AM -0700, Julian Elischer wrote: > J> > JE>> If you do that, I suppose you need to edit all the nodes, right?. In that > J> > JE>> case could

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Gleb Smirnoff
On Fri, May 28, 2004 at 07:14:45PM +0400, Roman Kurakin wrote: R> >On Fri, May 28, 2004 at 06:31:18PM +0400, Roman Kurakin wrote: R> >R> >On Fri, May 28, 2004 at 05:50:21PM +0400, Roman Kurakin wrote: R> >R> >R> >Here is the first one - convert all ng_type initializers to C99 R> >sparse R> >R> >ty

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Roman Kurakin
Gleb Smirnoff wrote: On Fri, May 28, 2004 at 06:31:18PM +0400, Roman Kurakin wrote: R> >On Fri, May 28, 2004 at 05:50:21PM +0400, Roman Kurakin wrote: R> >R> >Here is the first one - convert all ng_type initializers to C99 sparse R> >R> >type. R> >R> > R> >R> Hey guys, it seems all of you forgot

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Gleb Smirnoff
On Fri, May 28, 2004 at 06:31:18PM +0400, Roman Kurakin wrote: R> >On Fri, May 28, 2004 at 05:50:21PM +0400, Roman Kurakin wrote: R> >R> >Here is the first one - convert all ng_type initializers to C99 sparse R> >R> >type. R> >R> > R> >R> Hey guys, it seems all of you forgot about device nodes :-

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Roman Kurakin
Gleb Smirnoff wrote: On Fri, May 28, 2004 at 05:50:21PM +0400, Roman Kurakin wrote: R> >Here is the first one - convert all ng_type initializers to C99 sparse R> >type. R> > R> Hey guys, it seems all of you forgot about device nodes :-) Which ones? Just point me and I'll send diffs. My fingers c

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Gleb Smirnoff
On Fri, May 28, 2004 at 05:50:21PM +0400, Roman Kurakin wrote: R> >Here is the first one - convert all ng_type initializers to C99 sparse R> >type. R> > R> Hey guys, it seems all of you forgot about device nodes :-) Which ones? Just point me and I'll send diffs. My fingers can already convert ng

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Roman Kurakin
Hi, Gleb Smirnoff wrote: [...] Here is the first one - convert all ng_type initializers to C99 sparse type. Hey guys, it seems all of you forgot about device nodes :-) rik ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/fre

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Gleb Smirnoff
On Fri, May 28, 2004 at 01:31:09AM -0700, Julian Elischer wrote: J> It'd be best to make the change to sparse initialisers a separate patch J> that I cold commit separatly, J> so reduce teh size of the functionality change patch. ... and describe this behavior in manpage. -- Totus tuus, Glebius.

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Gleb Smirnoff
On Fri, May 28, 2004 at 01:31:09AM -0700, Julian Elischer wrote: J> It'd be best to make the change to sparse initialisers a separate patch J> that I cold commit separatly, J> so reduce teh size of the functionality change patch. And here is next patch, that must be applied after c99-patch. It int

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Gleb Smirnoff
As always I've forgot to attach file to previous mail. Here it is. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE ? ng_ipfw.c ? ng_ipfw.h Index: ng_UI.c === RCS file: /home/ncvs/src/sys/netgraph/ng_UI.c,v retrieving revision 1.17 dif

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Gleb Smirnoff
On Fri, May 28, 2004 at 01:31:09AM -0700, Julian Elischer wrote: J> > JE>> If you do that, I suppose you need to edit all the nodes, right?. In that J> > JE>> case could you please convert the initialisation of the typestructs J> > JE>> to use C99 sparse initialisation? In that case future changes

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Julian Elischer
On Fri, 28 May 2004, Harti Brandt wrote: > On Fri, 28 May 2004, Julian Elischer wrote: > > JE>> If you do that, I suppose you need to edit all the nodes, right?. In that > JE>> case could you please convert the initialisation of the typestructs > JE>> to use C99 sparse initialisation? In that c

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Harti Brandt
On Fri, 28 May 2004, Julian Elischer wrote: JE>> If you do that, I suppose you need to edit all the nodes, right?. In that JE>> case could you please convert the initialisation of the typestructs JE>> to use C99 sparse initialisation? In that case future changes will be a good JE>> deal easier. JE

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Gleb Smirnoff
On Fri, May 28, 2004 at 01:15:06AM -0700, Julian Elischer wrote: J> > JE>> So, what about adding one more netgraph method into struct ng_type, say J> > JE>> ng_preshutdown_t? This method is called first in ng_rmnode(), and then J> > JE>> current shutdown sequence is followed. We will set it to N

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Julian Elischer
On Fri, 28 May 2004, Harti Brandt wrote: > > [Sorry, I just deleted the original mail, so I use Julian's to answer] > > On Thu, 27 May 2004, Julian Elischer wrote: > > JE>On Fri, 28 May 2004, Gleb Smirnoff wrote: > JE> > JE>> So, what about adding one more netgraph method into struct ng_typ

Re: shutdown node VS disconnect all hooks

2004-05-28 Thread Harti Brandt
[Sorry, I just deleted the original mail, so I use Julian's to answer] On Thu, 27 May 2004, Julian Elischer wrote: JE>On Fri, 28 May 2004, Gleb Smirnoff wrote: JE> JE>> So, what about adding one more netgraph method into struct ng_type, say JE>> ng_preshutdown_t? This method is called first in

Re: shutdown node VS disconnect all hooks

2004-05-27 Thread Julian Elischer
On Fri, 28 May 2004, Gleb Smirnoff wrote: > Hi collegues, > > I'm again with the issue about node destruction process. If you > already forgot the problem, I'll remind you: in RELENG_4 node cuts down > all its hooks itself from shutdown method, while in HEAD it is done > in ng_rmnode() _be