Re: Relatively deterministic panic with sendfile(2) when running tests in the sxlock code

2018-10-15 Thread Enji Cooper (yaneurabeya)
> On Oct 15, 2018, at 6:10 AM, Gleb Smirnoff wrote: > > Enji, > > can you please check that with this patch all your tests pass? Hi Gleb! It almost compiled. I just needed to dereference the `so` pointer: $ git diff /usr/src/sys/kern/kern_sendfile.c diff --git a/sys/kern/kern_sendfil

Re: Relatively deterministic panic with sendfile(2) when running tests in the sxlock code

2018-10-15 Thread Gleb Smirnoff
Enji, can you please check that with this patch all your tests pass? -- Gleb Smirnoff Index: sys/kern/kern_sendfile.c === --- sys/kern/kern_sendfile.c (revision 339098) +++ sys/kern/kern_sendfile.c (working copy) @@ -526,6 +526,8

Re: Relatively deterministic panic with sendfile(2) when running tests in the sxlock code

2018-10-15 Thread Gleb Smirnoff
On Sun, Oct 14, 2018 at 10:17:28PM -0700, Enji Cooper (yaneurabeya) wrote: E> Oh yipes. I guess passing in a server socket (a bound and listening socket) instead of a client socket (connect’ed to a server socket) for `s` will result in a crash? Oh, thanks enough info. Thanks! Isn't related to se

Re: Relatively deterministic panic with sendfile(2) when running tests in the sxlock code

2018-10-14 Thread Enji Cooper (yaneurabeya)
> On Oct 14, 2018, at 10:17 PM, Enji Cooper (yaneurabeya) > wrote: ... > Oh yipes. I guess passing in a server socket (a bound and listening socket) > instead of a client socket (connect’ed to a server socket) for `s` will > result in a crash? > > From > https://github.com/ngie-eign/freebs

Re: Relatively deterministic panic with sendfile(2) when running tests in the sxlock code

2018-10-14 Thread Enji Cooper (yaneurabeya)
> On Oct 14, 2018, at 10:12 PM, Enji Cooper (yaneurabeya) > wrote: > >> On Oct 14, 2018, at 9:45 PM, Enji Cooper (yaneurabeya) >> mailto:yaneurab...@gmail.com>> wrote: >> >> >> >>> On Oct 14, 2018, at 7:25 PM, Gleb Smirnoff >> > wrote: >>> >>> Hi Enji, >>> >>>

Re: Relatively deterministic panic with sendfile(2) when running tests in the sxlock code

2018-10-14 Thread Enji Cooper (yaneurabeya)
> On Oct 14, 2018, at 9:45 PM, Enji Cooper (yaneurabeya) > wrote: > > > >> On Oct 14, 2018, at 7:25 PM, Gleb Smirnoff > > wrote: >> >> Hi Enji, >> >> On Sun, Oct 14, 2018 at 06:51:42PM -0700, Enji Cooper (yaneurabeya) wrote: >> E> Hi, >> E> I’m seeing a semi-

Re: Relatively deterministic panic with sendfile(2) when running tests in the sxlock code

2018-10-14 Thread Enji Cooper (yaneurabeya)
> On Oct 14, 2018, at 7:25 PM, Gleb Smirnoff wrote: > > Hi Enji, > > On Sun, Oct 14, 2018 at 06:51:42PM -0700, Enji Cooper (yaneurabeya) wrote: > E> Hi, > E>I’m seeing a semi-deterministic panic on 12.0-ALPHA9 related to > sendfile(2) when running sendfile_test on the host: > https://pa

Re: Relatively deterministic panic with sendfile(2) when running tests in the sxlock code

2018-10-14 Thread Gleb Smirnoff
Hi Enji, On Sun, Oct 14, 2018 at 06:51:42PM -0700, Enji Cooper (yaneurabeya) wrote: E> Hi, E> I’m seeing a semi-deterministic panic on 12.0-ALPHA9 related to sendfile(2) when running sendfile_test on the host: https://pastebin.com/raw/6Y7xg0ki; it looks like it’s crashing in the sxlock c

Relatively deterministic panic with sendfile(2) when running tests in the sxlock code

2018-10-14 Thread Enji Cooper (yaneurabeya)
Hi, I’m seeing a semi-deterministic panic on 12.0-ALPHA9 related to sendfile(2) when running sendfile_test on the host: https://pastebin.com/raw/6Y7xg0ki; it looks like it’s crashing in the sxlock code when calling sblock on a sockbuf. Are there any commands in gdb you would like me to