[Bug 218517] ppp fails adding route with error Value too large to be stored in data type

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218517

--- Comment #24 from emiku...@gmail.com ---
(In reply to Eugene Grosbein from comment #23)

Yes, I actually use IPv6 over PPPoE. :) I suspect my situation is the same as
Kris's in #1.

I'm not sure what the correct solution is. For now I pull
remotes/origin/stable/10 and git revert the r326012 commit. This gets me a
10-STABLE system with working IPv6.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 218517] ppp fails adding route with error Value too large to be stored in data type

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218517

--- Comment #25 from emiku...@gmail.com ---
(In reply to Eugene Grosbein from comment #22)

I applied the patch but it doesn't produce anything useful with a working
kernel. I can try it later with a not-working kernel but I'm pretty sure you're
going to get the same results as #16 and #18: where errno=17.

Your patch fixes a real logging bug in PPP so I hope it gets committed to
mainline.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


Review: Fix regression that did not allow "route change" that didn't re-specify the gateway

2018-02-09 Thread Ryan Stone
A change a while back (r264986) broke the ability to change a route's
parameters if the gateway wasn't explicitly specified again.  For
example, you used to be able to run "route change 10.0.0.0/8 -mtu
9000" to change the MTU without having to provide the gateway IP to
the command.  I have a review open to restore the existing behaviour.
In cases where the gateway is not specified, the gateway on the route
remains unchanged.

Anyone interested in reviewing this change should add themselves as a
reviewer to https://reviews.freebsd.org/D14291.

Thanks,
Ryan
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 218517] ppp fails adding route with error Value too large to be stored in data type

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218517

--- Comment #23 from Eugene Grosbein  ---
(In reply to emikulic from comment #9)

Do you actually use IPv6 within this system? If not, does ppp actually work for
IPv4 connectivity, so that is just bad logging problem?

If you do actually use IPv6, you seem to be already having mentioned IPv6
address, right?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 223835] BGP session not established with md5 password via FRRouting

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223835

--- Comment #24 from Marek Zarychta  ---
Thank you for the patch. I also confirm that it fixes the issue on 11.1-STABLE
for inet4. 
This with "options IPSEC_SUPPORT" default in GENERIC is going to make upcoming
11.2 the most TCP-MD5-friendly FreeBSD release ever.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 218517] ppp fails adding route with error Value too large to be stored in data type

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218517

--- Comment #22 from Eugene Grosbein  ---
(In reply to emikulic from comment #20)

Please try a patch for /usr/sbin/ppp I've just attached that fixes cosmetic
problem preventing clobbering errno value while producing logs.

To apply:

cd /usr/src
patch < /path/to/path
cd usr.sbin/ppp
make obj depend && make all install

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 218517] ppp fails adding route with error Value too large to be stored in data type

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218517

--- Comment #21 from Eugene Grosbein  ---
Created attachment 190463
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=190463&action=edit
save errno and fix buffer size for copies of ncpaddr_ntoa/ncprange_ntoa result

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 218517] ppp fails adding route with error Value too large to be stored in data type

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218517

Rodney W. Grimes  changed:

   What|Removed |Added

 CC||freebsd-net@FreeBSD.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 218517] ppp fails adding route with error Value too large to be stored in data type

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218517

Eugene Grosbein  changed:

   What|Removed |Added

   Assignee|freebsd-net@FreeBSD.org |eu...@freebsd.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 223835] BGP session not established with md5 password via FRRouting

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223835

Felipe N. Oliva  changed:

   What|Removed |Added

 CC||fel...@felipeoliva.eti.br

--- Comment #23 from Felipe N. Oliva  ---
(In reply to Olivier Cochard from comment #21)
I have the same problem, but with OpenBGPd.

I will try the patch!

Thanks,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 223835] BGP session not established with md5 password via FRRouting

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223835

--- Comment #22 from Alexey  ---
(In reply to Olivier Cochard from comment #21)
Thank you for testing and positive result

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 223835] BGP session not established with md5 password via FRRouting

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223835

--- Comment #21 from Olivier Cochard  ---

Thanks for this patch!

It fixes my problem  (applied on -stable):

[root@router]~# netstat -ss | grep sign
40 packets with matching signature received

and now my inet4 TCP MD5 works:

[root@router]~# birdcl
BIRD 2.0.1 ready.
bird> show protocol R2inet4
Name   Proto  Table  State  Since Info
R2inet4BGP---up 15:58:36.337  Established

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 218517] ppp fails adding route with error Value too large to be stored in data type

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218517

--- Comment #20 from emiku...@gmail.com ---
Bisecting:

revision=326006 works
revision=326012 doesn't

https://svnweb.freebsd.org/base?view=revision&revision=326012

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 223835] BGP session not established with md5 password via FRRouting

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223835

Rodney W. Grimes  changed:

   What|Removed |Added

 CC||freebsd-net@FreeBSD.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 223835] BGP session not established with md5 password via FRRouting

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223835

Andrey V. Elsukov  changed:

   What|Removed |Added

   Assignee|freebsd-net@FreeBSD.org |a...@freebsd.org

--- Comment #19 from Andrey V. Elsukov  ---
Created attachment 190461
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=190461&action=edit
Proposed patch

Can you try this patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"


[Bug 218517] ppp fails adding route with error Value too large to be stored in data type

2018-02-09 Thread bugzilla-noreply
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218517

--- Comment #19 from emiku...@gmail.com ---
This version kernel works:

# uname -K
1003507

Log looks weird though:

ppp[440]: tun0: IPV6CP: deflink: LayerUp.
ppp[440]: tun0: ID0: 2 = socket(28, 2, 0)
ppp[440]: tun0: ID0: 0 = ioctl(2, 2166384921, 0x7fffd900)
ppp[440]: tun0: ID0: bug 218517: errno = 4 (Interrupted system call)
ppp[440]: tun0: ID0: 0 = ioctl(2, 2156423451, 0x7fffd370)
ppp[440]: tun0: ID0: bug 218517: errno = 4 (Interrupted system call)
ppp[440]: tun0: ID0: 2 = socket(17, 3, 0)
ppp[440]: tun0: ID0: -1 = write(2, data, 248)
ppp[440]: tun0: ID0: 248 = write(2, data, 248)
ppp[440]: tun0: ID0: 2 = socket(17, 3, 0)
ppp[440]: tun0: ID0: -1 = write(2, data, 200)
ppp[440]: tun0: ID0: 200 = write(2, data, 200)
ppp[440]: tun0: ID0: 2 = socket(17, 3, 0)
ppp[440]: tun0: ID0: -1 = write(2, data, 248)
ppp[440]: tun0: ID0: 248 = write(2, data, 248)
ppp[440]: tun0: ID0: 2 = socket(2, 2, 0)
ppp[440]: tun0: ID0: 0 = ioctl(2, 3223349521, 0x7fffdd40)
ppp[440]: tun0: ID0: bug 218517: errno = 17 (File exists)
ppp[440]: tun0: ID0: 0 = ioctl(2, 2149607696, 0x7fffdd40)
ppp[440]: tun0: ID0: bug 218517: errno = 17 (File exists)
ppp[440]: tun0: IPV6CP: myaddr  hisaddr = 

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"