[Differential] [Request, 225 lines] D1643: Implement resetting a VF

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY Add the ability to do a full reset of a VF's state. This involves stopping the VF in hardware, releasing all resources, re-allocating a new VSI, and finally allocating

[Differential] [Request, 1, 330 lines] D1640: Refactor network stack state separate from VSI state

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY Currently the ixl driver has a struct ixl_vsi that it uses to track both network stack interface state (e.g. the ifnet) and Virtual Station Interface (VSI) state in the

[Differential] [Request, 32 lines] D1647: Add support for GET_VF_RESOURCES VC message

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY This message is sent by the VF driver to discover the capabilities of the VF, like the number of rx/tx queues supported. REVISION DETAIL

[Differential] [Request, 152 lines] D1644: Add infrastructure for handling the VC msg channel from VFs

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY The VF drivers do not have unrestricted access to the hardware. To configure the VF (e.g. set the MAC address), they are required to send a message the PF requesting the

[Differential] [Request, 226 lines] D1641: Implement PCI SR-IOV initialization methods

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY Implement the two new PCI methods used to initialize and uninitialize SR-IOV on a PF. On initialization, the PF must allocate a VEB, which is a virtual switch instance

[Differential] [Request, 118 lines] D1642: Implement PCI SR-IOV method to initialize individual VFs

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY For each VF that has been allocated, the PF driver must allocate a Virtual Switch Interface (VSI), which is a virtual port on the virtual Fortville switch (VEB). In

[Differential] [Request, 21 lines] D1645: Add support for VERSION VC message

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY The VC message format is versioned. Implement the VERSION VC message, which the VF uses to discover the version of the VC protocol implemented by the PF. The VF will

[Differential] [Request, 68 lines] D1651: Add support for ENABLE/DISABLE_QUEUES VC messages

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY These messages are sent by the VF to enable or disable packet reception and transmission from its queues. Despite the fact that a bitmask of queues is provided in the

[Differential] [Request, 38 lines] D1648: Add stubs for deprecated VC messages

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY There are a couple of VC message types defined in the enum that seem to have been deprecated early in the Fortville SR-IOV development process. Explicitly implement them

[Differential] [Request, 19 lines] D1646: Add support for RESET_VF VC message

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY This VC message is used by the VF driver to request a full reset of the VF state. Unlike all other VC messages, no response is sent to the message. REVISION DETAIL

[Differential] [Request, 21 lines] D1660: Add support for mac-addr parameter

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY Implement a mac-addr SR-IOV configuration parameter, which the administrator can specify to force a VF to use a particular MAC address. By default, the VF driver cannot

[Differential] [Closed] D1648: Add stubs for deprecated VC messages

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1648 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Request, 7 lines] D1868: Make libnv headers includable from C++

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1868 AFFECTED FILES lib/libnv/dnv.h lib/libnv/nv.h To: rstone, jfvogel Cc: freebsd-net, pjd

[Differential] [Request, 309 lines] D1869: Tests of basic nvlist add functions

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1869 AFFECTED FILES lib/libnv/Makefile lib/libnv/tests/Makefile lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd

[Differential] [Request, 185 lines] D1871: Add tests for nvlist_pack/unpack

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1871 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd ___

[Differential] [Closed] D1660: Add support for mac-addr parameter

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1660 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1661: Add some security-related config parameters

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1661 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1644: Add infrastructure for handling the VC msg channel from VFs

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1644 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Request, 120 lines] D1870: Add tests for nvlist_clone

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1870 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd ___

[Differential] [Request, 206 lines] D1874: Add tests for nvlist_free* functions

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1874 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd ___

[Differential] [Request, 82 lines] D1872: Add test cases for nvlist_move_*

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1872 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd ___

[Differential] [Closed] D1643: Implement resetting a VF

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1643 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1649: Add support for CONFIG_VSI_QUEUES VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1649 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1650: Add support for CONFIG_IRQ_MAP VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1650 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1641: Implement PCI SR-IOV initialization methods

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1641 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1642: Implement PCI SR-IOV method to initialize individual VFs

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1642 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1647: Add support for GET_VF_RESOURCES VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1647 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1645: Add support for VERSION VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1645 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Request, 292 lines] D1873: Add tests for nvlist_take_*

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1873 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd ___

[Differential] [Closed] D1659: Register ixl as an SR-IOV-capable driver during attach

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1659 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1656: Handle VFLR events from VFs

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1656 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Request, 290 lines] D1875: Add tests for dnv_get_*

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1875 AFFECTED FILES lib/libnv/tests/Makefile lib/libnv/tests/dnv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd

[Differential] [Closed] D1655: Add support for GET_STATS VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1655 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Request, 259 lines] D1881: Allow Illumos code to co-exist with nv(9)

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1881 AFFECTED FILES sys/cddl/compat/opensolaris/sys/nvpair.h To: rstone, jfvogel Cc: freebsd-net, pjd

[Differential] [Request, 395 lines] D1879: Don't allocate memory for operations that do not insert

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY Almost every operation performed on an nvlist was allocating a new string to hold the key name. The nvlist_exists* family of functions would always return false if

[Differential] [Request, 39 lines] D1880: Prevent creation of an invalid nvlist

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY If an nvlist is set as a child of another nvlist with nvlist_move_nvlist then fail the operation and set the parent nvlist to the error state. REVISION DETAIL

[Differential] [Request, 82 lines] D1877: Implement asprintf in libkern

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1877 AFFECTED FILES sys/conf/files sys/libkern/asprintf.c sys/sys/systm.h To: rstone, jfvogel Cc: freebsd-net, pjd

[Differential] [Closed] D1654: Add support for CONFIG_PROMISCUOUS_MODE VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1654 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Request, 60 lines] D1878: Add function to force an nvlist into the error state

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY Add an nvlist_set_error() function that can be used to force an nvlist into the error state. This is useful both for writing tests and for writing APIs that use

[Differential] [Closed] D1658: Add sysctls for per-VF hardware counters

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1658 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Request, 288 lines] D1876: Add tests for dnvlist_take_*

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1876 AFFECTED FILES lib/libnv/tests/dnv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd ___

[Differential] [Closed] D1652: Add support for ADD/DEL_ETHER_ADDRESS VC messages

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1652 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Request, 1, 516 lines] D1883: Move libnv into the kernel and hook it into the kernel build

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1883 AFFECTED FILES lib/libnv/Makefile lib/libnv/dnv.h lib/libnv/dnvlist.c lib/libnv/nv.h lib/libnv/nv_impl.h lib/libnv/nvlist.c

[Differential] [Closed] D1651: Add support for ENABLE/DISABLE_QUEUES VC messages

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1651 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1653: Add support for ADD/DEL_VLAN VC messages

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1653 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1657: Allow VFs to run while the PF is admin down

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1657 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Request, 471 lines] D1882: Add macros to make code compile in kernel

rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY Make it possible to compile libnv in the kernel. Mostly this involves wrapping functions that have a different signature in the kernel and in userland (e.g.

[Differential] [Closed] D1646: Add support for RESET_VF VC message

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1646 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1640: Refactor network stack state separate from VSI state

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1640 To: rstone, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9)

rstone added a comment. Err, that was supposed to be installed it into a couple of *VMs* REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: will, emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list

[Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9)

rstone added a comment. Ok, I did a full buildworld/buildkernel (with device zfs in my kernel config) and installed it into a couple of zfs. I tested creating a zpool out of a mfs disk, creating filesystems, setting some properties, doing a git clone into a file system, and then doing a zfs

[Differential] [Closed] D1881: Allow Illumos code to co-exist with nv(9)

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel, will Cc: will, emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe,

[Differential] [Updated, 281 lines] D1640: Refactor network stack state separate from VSI state

rstone updated this revision to Diff 3458. rstone added a comment. Remove the ifx/vsi separation and just refactor out the necessary functions CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1640?vs=3393id=3458 BRANCH review_D1640 REVISION DETAIL https://reviews.freebsd.org/D1640

[Differential] [Updated, 118 lines] D1642: Implement PCI SR-IOV method to initialize individual VFs

rstone updated this revision to Diff 3466. rstone added a comment. revert ifx/vsi split CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1642?vs=3395id=3466 BRANCH review_D1642 REVISION DETAIL https://reviews.freebsd.org/D1642 AFFECTED FILES sys/dev/ixl/if_ixl.c

[Differential] [Updated, 34 lines] D1658: Add sysctls for per-VF hardware counters

rstone updated this revision to Diff 3464. rstone added a comment. Revert ifx/vsi split CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1658?vs=3411id=3464 BRANCH review_D1658 REVISION DETAIL https://reviews.freebsd.org/D1658 AFFECTED FILES sys/dev/ixl/if_ixl.c

[Differential] [Updated, 41 lines] D1655: Add support for GET_STATS VC message

rstone updated this revision to Diff 3465. rstone added a comment. revert ifx/vsi split CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1655?vs=3408id=3465 BRANCH review_D1655 REVISION DETAIL https://reviews.freebsd.org/D1655 AFFECTED FILES sys/dev/ixl/if_ixl.c To: rstone,

[Differential] [Updated, 227 lines] D1641: Implement PCI SR-IOV initialization methods

rstone updated this revision to Diff 3461. rstone added a comment. Undo ifx/vsi split CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1641?vs=3394id=3461 BRANCH review_D1641 REVISION DETAIL https://reviews.freebsd.org/D1641 AFFECTED FILES sys/dev/ixl/if_ixl.c

[Differential] [Updated, 161 lines] D1652: Add support for ADD/DEL_ETHER_ADDRESS VC messages

rstone updated this revision to Diff 3462. rstone added a comment. Revert vsi/ifx split CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1652?vs=3405id=3462 BRANCH review_D1652 REVISION DETAIL https://reviews.freebsd.org/D1652 AFFECTED FILES sys/dev/ixl/if_ixl.c

[Differential] [Updated, 36 lines] D1657: Allow VFs to run while the PF is admin down

rstone updated this revision to Diff 3463. rstone added a comment. Revert ifx/vsi split CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1657?vs=3410id=3463 BRANCH review_D1657 REVISION DETAIL https://reviews.freebsd.org/D1657 AFFECTED FILES sys/dev/ixl/if_ixl.c To: rstone,

[Differential] [Updated, 36 lines] D1657: Allow VFs to run while the PF is admin down

rstone updated this revision to Diff 3467. rstone added a comment. Missed part of the ifx/vsi split CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1657?vs=3463id=3467 BRANCH review_D1657 REVISION DETAIL https://reviews.freebsd.org/D1657 AFFECTED FILES sys/dev/ixl/if_ixl.c To:

[Differential] [Request, 34 lines] D1657: Allow VFs to run while the PF is admin down

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY Ensure that the admin queue interrupt stays enabled as long as we have VFs. It is a requirement that the VFs be able to keep running correctly even if the PF ifnet is

[Differential] [Request, 65 lines] D1656: Handle VFLR events from VFs

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY If a VF resets itself via a Function Level Reset (FLR) bit, the PF receives an interrupt with a VFLR event. The PF is required to re-initialize the VF state when this

[Differential] [Request, 165 lines] D1650: Add support for CONFIG_IRQ_MAP VC message

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY This message is used by the VF to request that its RX and TX queues be associated with particular MSI-X vectors. This configuration is performed via a fairly complicated

[Differential] [Request, 161 lines] D1652: Add support for ADD/DEL_ETHER_ADDRESS VC messages

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY The ADD message is sent by the VF to request that a MAC address filter be added to the Fortville switch to direct packets destined to that MAC be routed to the VF's VSI.

[Differential] [Request, 49 lines] D1654: Add support for CONFIG_PROMISCUOUS_MODE VC message

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY This message is sent by the VF driver to request that the VSI be placed in or taken out of promiscuous mode. REVISION DETAIL https://reviews.freebsd.org/D1654 AFFECTED

[Differential] [Request, 177 lines] D1649: Add support for CONFIG_VSI_QUEUES VC message

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY This message is sent by the VF to request that the PF configure its RX and TX queues. The PF is required to validate that the request is sane before applying the

[Differential] [Request, 41 lines] D1655: Add support for GET_STATS VC message

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY The Fortville hardware tracks a small number of per-VSI counters, like packet and byte counters. The GET_STATS message is sent by the VF driver to request a copy of the

[Differential] [Request, 121 lines] D1653: Add support for ADD/DEL_VLAN VC messages

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY These messages are sent by the PF to change configuration related to the hardware vlan filtering and stripping. If a VF is subscribed to one or more vlans then the vlan

[Differential] [Request, 24 lines] D1659: Register ixl as an SR-IOV-capable driver during attach

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY Now that the driver's SR-IOV implementation is complete, during attach register the device as being SR-IOV capable. This will cause the SR-IOV infrastructure to create

[Differential] [Request, 34 lines] D1658: Add sysctls for per-VF hardware counters

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY For debugging purposes, add sysctls that reflect the value of each VF's hardware counters. REVISION DETAIL https://reviews.freebsd.org/D1658 AFFECTED FILES

[Differential] [Request, 23 lines] D1661: Add some security-related config parameters

rstone created this revision. rstone added a reviewer: jfvogel. rstone added a subscriber: freebsd-net. REVISION SUMMARY Allow the administrator to prevent VFs from sending packets with a source MAC that is not the VF's MAC (anti-spoof). Default this to on. Allow the administrator to

[Differential] [Updated, 4 lines] D1648: Add stubs for deprecated VC messages

rstone updated this revision to Diff 3772. rstone added a comment. Remove unnecessary code and remove reference to Linux driver CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1648?vs=3401id=3772 BRANCH review_D1648 REVISION DETAIL https://reviews.freebsd.org/D1648 AFFECTED FILES

[Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9)

rstone added a comment. The primary testing that I did was to ensure that a kernel with device zfs would still link. However, I suppose that doesn't exclude the possibility of their being an zfs source file that is built wrong and doesn't include this header. Is there a zfs test suite that I

[Differential] [Closed] D1877: Implement asprintf in libkern

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1877 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1869: Tests of basic nvlist add functions

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: emaste, pjd, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any

[Differential] [Closed] D1874: Add tests for nvlist_free* functions

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1874 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail

[Differential] [Closed] D1876: Add tests for dnvlist_take_*

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1876 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail

[Differential] [Closed] D1875: Add tests for dnv_get_*

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1875 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail

[Differential] [Closed] D1872: Add test cases for nvlist_move_*

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1872 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail

[Differential] [Closed] D1873: Add tests for nvlist_take_*

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1873 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail

[Differential] [Closed] D1871: Add tests for nvlist_pack/unpack

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1871 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail

[Differential] [Closed] D1878: Add function to force an nvlist into the error state

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1878 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Closed] D1868: Make libnv headers includable from C++

rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1868 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Updated, 120 lines] D1870: Add tests for nvlist_clone

rstone updated this revision to Diff 3862. rstone added a comment. This revision now requires review to proceed. Fix the test case to actually test the clone CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1870?vs=3813id=3862 BRANCH review_D1870 REVISION DETAIL

[Differential] [Changed Subscribers] D1986: Teach lagg(4) to change MTU

rstone added a subscriber: freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1986 To: rpokala-panasas.com, rstone Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe,

[Differential] [Closed] D1882: Add macros to make code compile in kernel

rstone closed this revision. rstone updated this revision to Diff 4041. rstone added a comment. Closed by commit rS279438 (authored by @rstone). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1882?vs=3825id=4041#toc REVISION DETAIL https://reviews.freebsd.org/D1882 AFFECTED FILES

[Differential] [Closed] D1883: Move libnv into the kernel and hook it into the kernel build

rstone closed this revision. rstone updated this revision to Diff 4043. rstone added a comment. Closed by commit rS279439 (authored by @rstone). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1883?vs=3826id=4043#toc REVISION DETAIL https://reviews.freebsd.org/D1883 AFFECTED FILES

[Differential] [Closed] D1870: Add tests for nvlist_clone

rstone closed this revision. rstone updated this revision to Diff 4038. rstone added a comment. Closed by commit rS279425 (authored by @rstone). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1870?vs=3862id=4038#toc REVISION DETAIL https://reviews.freebsd.org/D1870 AFFECTED FILES

[Differential] [Closed] D1880: Prevent creation of an invalid nvlist

rstone closed this revision. rstone updated this revision to Diff 4040. rstone added a comment. Closed by commit rS279436 (authored by @rstone). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1880?vs=3823id=4040#toc REVISION DETAIL https://reviews.freebsd.org/D1880 AFFECTED FILES

[Differential] [Closed] D1879: Don't allocate memory for operations that do not insert

rstone closed this revision. rstone updated this revision to Diff 4039. rstone added a comment. Closed by commit rS279435 (authored by @rstone). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D1879?vs=3822id=4039#toc REVISION DETAIL https://reviews.freebsd.org/D1879 AFFECTED FILES

[Differential] [Updated] D1986: Teach lagg(4) to change MTU

rstone added a comment. RLOCK only gets a read lock. You want WLOCK to get a write lock to ensure serialization. REVISION DETAIL https://reviews.freebsd.org/D1986 To: rpokala-panasas.com, rstone Cc: ae, freebsd-net ___ freebsd-net@freebsd.org

[Differential] [Commented On] D1986: Teach lagg(4) to change MTU

rstone added inline comments. INLINE COMMENTS sys/net/if_lagg.c:1772 style(9) says to not include unnecessary braces (which I personally disagree with, but what can you do?) sys/net/if_lagg.c:1773 style(9): put brackets around the return value: return (0); sys/net/if_lagg.c:1811 I

[Differential] D8685: Fix a false positive in a buf_ring assert

rstone added a subscriber: freebsd-net-list. REVISION DETAIL https://reviews.freebsd.org/D8685 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rstone Cc: freebsd-net-list, emaste ___ freebsd-net@freebsd.org

[Differential] D8685: Fix a false positive in a buf_ring assert

This revision was automatically updated to reflect the committed changes. rstone marked an inline comment as done. Closed by commit rS309372: Fix a false positive in a buf_ring assert (authored by rstone). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D8685?vs=22633=22651#toc REPOSITORY

[Differential] D8685: Fix a false positive in a buf_ring assert

rstone marked an inline comment as done. rstone added inline comments. INLINE COMMENTS > hselasky wrote in buf_ring.h:71 > should "br->br_cons_head + 1" be masked by br->br_cons_mask ?? Absolutely correct. Nice catch, thank you REVISION DETAIL https://reviews.freebsd.org/D8685 EMAIL

[Differential] D8685: Fix a false positive in a buf_ring assert

rstone updated this revision to Diff 22633. rstone added a comment. Ensure we don't walk off the end of the ring CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D8685?vs=22631=22633 REVISION DETAIL https://reviews.freebsd.org/D8685 AFFECTED FILES sys/sys/buf_ring.h CHANGE