[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #19 from commit-h...@freebsd.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=bc9107f8c405ce83f47abc915ae95baadb770d6d

commit bc9107f8c405ce83f47abc915ae95baadb770d6d
Author: Gleb Smirnoff 
AuthorDate: 2024-02-15 18:48:44 +
Commit: Gleb Smirnoff 
CommitDate: 2024-02-15 18:48:44 +

socket tests: add listener_wakeup

This test runs several scenarios when sleep(9) on a listen(2)ing socket is
interrupted by shutdown(2) or by close(2).  What should happen in that
case is not specified, neither is documented.  However, there is certain
behavior that we have and this test makes sure it is preserved.  There is
software that relies on it, see bug 227259.  This test is based on
submission with this bug, bugzilla attachment 192260.

The test checks TCP and unix(4) stream socket behavior and SCTP can be
added easily if needed.

The test passes on FreeBSD 11 to 15.  It won't pass on FreeBSD 10,
although the wakeup behavior of shutdown(2) is the same, but it doesn't
return error.

PR: 227259

 tests/sys/kern/Makefile|   2 +
 tests/sys/kern/listener_wakeup.c (new) | 293 +
 2 files changed, 295 insertions(+)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

Jonathan T. Looney  changed:

   What|Removed |Added

  Flags|mfc-stable11?   |mfc-stable11+
 Resolution|--- |FIXED
 Status|In Progress |Closed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #18 from commit-h...@freebsd.org ---
A commit references this bug:

Author: glebius
Date: Wed Oct  3 17:40:05 UTC 2018
New revision: 339170
URL: https://svnweb.freebsd.org/changeset/base/339170

Log:
  In PR 227259, a user is reporting that they have code which is using
  shutdown() to wakeup another thread blocked on a stream listen socket.
  This code is failing, while it used to work on FreeBSD 10 and still
  works on Linux.

  It seems reasonable to add another exception to support something users are
  actually doing, which used to work on FreeBSD 10, and still works on Linux.
  And, it seems like it should be acceptable to POSIX, as we still return
  ENOTCONN.

  This patch is different to what had been committed to stable/11, since
  code around listening sockets is different. Patch in D15019 is written
  by jtl@, slightly modified by me.

  PR:   227259
  Obtained from:jtl
  Approved by:  re (kib)
  Differential Revision:  D15019

Changes:
  head/sys/kern/uipc_socket.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #17 from commit-h...@freebsd.org ---
A commit references this bug:

Author: jtl
Date: Sat May 12 01:55:24 UTC 2018
New revision: 333511
URL: https://svnweb.freebsd.org/changeset/base/333511

Log:
  r285910 attempted to make shutdown() be POSIX compliant by returning
  ENOTCONN when shutdown() is called on unconnected sockets.  This change was
  slightly modified by r316874, which returns ENOTCONN in the case of an
  unconnected datagram socket, but still runs the shutdown code for the
  socket.  This specifically supports the case where the user-space code is
  using the shutdown() call to wakeup another thread blocked on the socket.

  In PR 227259, a user is reporting that they have code which is using
  shutdown() to wakup another thread blocked on a stream listen socket.  This
  code is failing, while it used to work on FreeBSD 10 and still works on
  Linux.

  It seems reasonable to add another exception to support something users are
  actually doing, which used to work on FreeBSD 10, and still works on Linux.
  And, it seems like it should be acceptable to POSIX, as we still return
  ENOTCONN.

  This is a direct commit to stable/11.  The listen socket code changed
  substantially in head, and the code change there will be substantially
  more complex.  In the meantime, it seems to make sense to commit this
  trivial fix to stable/11 given the fact that users appear to depend on
  this behavior, this appears to have been an unintended change in stable/11,
  and we did not announce the change.

  PR:   227259
  Reviewed by:  ed
  Approved by:  re (gjb)
  Sponsored by: Netflix, Inc.
  Differential Revision:https://reviews.freebsd.org/D15021
  Tested by:Eric Masson (emss at free.fr)

Changes:
  stable/11/sys/kern/uipc_socket.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #16 from e...@free.fr ---
*** Bug 225863 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

Kubilay Kocak  changed:

   What|Removed |Added

URL|jtl |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #15 from Kubilay Kocak  ---
If bug 225863 and this issue are two symptoms of the same underlying cause,
fixed by either of the two commits (reviews) referenced here, we should close
one of the issue reports.

In this case this issue has been more fleshed out (has more
activity/references), even though it was created later, so bug 225863 should be
closed.


In the normal case, the later bug(s) are closed duplicates of the earliest
reported bug.

@Éric Thank you for confirming the stable/11 code fixes your issue

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #14 from e...@free.fr ---
Hi

11.2-PRERELEASE :
https://reviews.freebsd.org/D15021 seems to fix
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225863

Freeswitch now shuts down properly.

Regards

Éric Masson

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

Kubilay Kocak  changed:

   What|Removed |Added

   See Also||https://reviews.freebsd.org
   ||/D15021,
   ||https://reviews.freebsd.org
   ||/D15019
  Flags||mfc-stable11?
URL||jtl
   Keywords||needs-qa, patch, regression
   Assignee|b...@freebsd.org|j...@freebsd.org

--- Comment #13 from Kubilay Kocak  ---
Assign to committer resolving (authoring the in progress code)

Can re-assign if necessary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

Jonathan T. Looney  changed:

   What|Removed |Added

 Status|New |In Progress

--- Comment #12 from Jonathan T. Looney  ---
See D15019 and D15021. I think we're waiting for reviewers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #11 from e...@free.fr ---
Hi,

Any news on this subject, please ?

Regards

Éric Masson

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #10 from rozhuk...@gmail.com ---
IMHO:
 - shutdown() and close() should wakes up all thread on all descriptors that
wait blocking i/o.
 - shutdown() should generate EOF for all syscals:
read()/recv/write()/send()/accept()/poll()/kqueue()/etc...
 - close() should generate BADFD for all syscals:
read()/recv/write()/send()/accept()/poll() and kqueue() (on close kqueue fd)
for all descriptors types

See linux: if you call shutdown() then you know that everything wakes up, it is
very useful.

Well, at lest return old behavior from FreeBSD 10.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #9 from Jonathan T. Looney  ---
My best guess is that this is due to a new check in soshutdown() added in
stable/11:

sys/kern/uipc_socket.c:

2351if ((so->so_state &
2352(SS_ISCONNECTED | SS_ISCONNECTING | SS_ISDISCONNECTING)) ==
0) {
2353/*
2354 * POSIX mandates us to return ENOTCONN when
shutdown(2) is
2355 * invoked on a datagram sockets, however historically
we would
2356 * actually tear socket down. This is known to be
leveraged by
2357 * some applications to unblock process waiting in
recvXXX(2)
2358 * by other process that it shares that socket with.
Try to meet
2359 * both backward-compatibility and POSIX requirements
by forcing
2360 * ENOTCONN but still asking protocol to perform
pru_shutdown().
2361 */
2362if (so->so_type != SOCK_DGRAM)
2363return (ENOTCONN);
2364soerror_enotconn = 1;
2365}

I don't think I ever really considered someone calling shutdown() on a
listening socket. I would have expected them to use close(). My guess is that
whoever added this didn't consider that case, either.

FWIW, this check was added in r285910.

I suppose the simple fix is to add a check for SOLISTENING(so) (head) or
so->so_options & SO_ACCEPTCON (stable/11). However, we should consult with
someone to see what POSIX requires in this case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

e...@free.fr changed:

   What|Removed |Added

 CC||e...@free.fr

--- Comment #8 from e...@free.fr ---
Hello,

Could this issue be related to
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225863 please ?

In last comment on https://freeswitch.org/jira/browse/FS-10580 M. Jerris states
the following :
"so the way that is supposed to work is the close_socket(_list.sock);
line from the shutdown function would close the socket causing the accpet to
stop blocking in the runtime function. For some reason that is not happening.
This is going to be something with either freebsd or your network settings on
the box causing that close to fail. I'm not sure how to troubleshoot that issue
further, but add some logging around that accept in the runtime and the close
in shutdown and look at open sockets and see what is happening at shutdown."

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #7 from rozhuk...@gmail.com ---
DragonFly  5.0-RELEASE DragonFly v5.0.2-RELEASE #4: Sun Dec  3 17:42:25 EST
2017

./acc_test | grep "chk OK"
0:  socket(AF_INET, block)  ... lskt  accept  shutdown  chk OK, ret code:
53 - Software caused connection abort
1:  socket(AF_INET, block)  ... rskt  accept  shutdown  chk OK, ret code:
53 - Software caused connection abort
4:  socket(AF_INET, block)  ... lskt  poll  shutdown  chk OK
5:  socket(AF_INET, block)  ... rskt  poll  shutdown  chk OK
16: socket(AF_INET, block)  ... lskt  shutdown  accept  chk OK, ret code:
53 - Software caused connection abort
20: socket(AF_INET, block)  ... lskt  shutdown  poll  chk OK
36: socket(AF_INET, nblock) ... lskt  poll  shutdown  chk OK
37: socket(AF_INET, nblock) ... rskt  poll  shutdown  chk OK
42: socket(AF_INET, nblock) ... lskt  shutdown  poll  chk OK

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

rozhuk...@gmail.com changed:

   What|Removed |Added

 Attachment #192208|0   |1
is obsolete||
 Attachment #192260|text/x-csrc |text/plain
  mime type||

--- Comment #6 from rozhuk...@gmail.com ---
Created attachment 192260
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=192260=edit
test tool

I do few modifications to run on linux, also add epoll() to kqueue() place.

Linux ubuntux64 4.4.0-57-generic #78-Ubuntu SMP Fri Dec 9 23:50:32 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux

./acc_test | grep "chk OK"
0:  socket(AF_INET, block)  ... lskt  accept  shutdown  chk OK, ret code:
22 - Invalid argument
1:  socket(AF_INET, block)  ... rskt  accept  shutdown  chk OK, ret code:
22 - Invalid argument
4:  socket(AF_INET, block)  ... lskt  poll  shutdown  chk OK
5:  socket(AF_INET, block)  ... rskt  poll  shutdown  chk OK
6:  socket(AF_INET, block)  ... lskt  epoll  shutdown  chk OK
7:  socket(AF_INET, block)  ... rskt  epoll  shutdown  chk OK
16: socket(AF_INET, block)  ... lskt  shutdown  accept  chk OK, ret code:
22 - Invalid argument
20: socket(AF_INET, block)  ... lskt  shutdown  poll  chk OK
22: socket(AF_INET, block)  ... lskt  shutdown  epoll  chk OK
36: socket(AF_INET, nblock) ... lskt  poll  shutdown  chk OK
37: socket(AF_INET, nblock) ... rskt  poll  shutdown  chk OK
38: socket(AF_INET, nblock) ... lskt  epoll  shutdown  chk OK
39: socket(AF_INET, nblock) ... rskt  epoll  shutdown  chk OK
42: socket(AF_INET, nblock) ... lskt  shutdown  poll  chk OK
43: socket(AF_INET, nblock) ... lskt  shutdown  epoll  chk OK

shutdown() work every where!
close() does not work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #5 from rozhuk...@gmail.com ---
FreeBSD rimwks 11.1-STABLE FreeBSD 11.1-STABLE  r331113M  amd64
I do not try 12.
You can run test from attach and see results.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #4 from Gleb Smirnoff  ---
Can you please confirm that behavior changed for FreeBSD 11, not 12? I would
expect to have a regression in 12, since there was a big change to listening
sockets there, but not in 11.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

rozhuk...@gmail.com changed:

   What|Removed |Added

Version|11.0-STABLE |11.1-STABLE

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #3 from rozhuk...@gmail.com ---
Why close() does not wakes thread that sleep on accept()?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

--- Comment #2 from rozhuk...@gmail.com ---
I do not understand why shutdown() does not generates POLLHUP/EV_EOF (EV_ERROR
then add shutdowned socket) for poll() and kqueue().

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 227259] accept()/poll() and shutdown()/close() - not work as in FreeBSD10, may broke many apps

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227259

rozhuk...@gmail.com changed:

   What|Removed |Added

Summary|accept() does not wakeup on |accept()/poll() and
   |shutdown()/close()  |shutdown()/close() - not
   ||work as in FreeBSD10, may
   ||broke many apps

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"