RE: Some question about DCTCP implementation in FreeBSD

2019-06-06 Thread Scheffenegger, Richard
error = EINVAL; else V_dctcp_slowstart = new; @@ -454,7 +515,7 @@ SYSCTL_NODE(_net_inet_tcp_cc, OID_AUTO, dctcp, CTLFLAG_RW, NULL, SYSCTL_PROC(_net_inet_tcp_cc_dctcp, OID_AUTO, alpha, CTLFLAG_VNET|CTLTYPE_UINT|CTLFLAG_RW, _NAME(dctcp_alpha

Re: Some question about DCTCP implementation in FreeBSD

2019-06-04 Thread Lars Eggert
Hi, glad to see interest in DCTCP! On 2019-6-4, at 11:05, Yu He via freebsd-net wrote: > In line 387 of file cc_tcp.c, the update of alpha is calculated by following > code: > > dctcp_data->alpha = min(alpha_prev - (alpha_prev >> V_dctcp_shift_g) + > (dctcp_data->bytes_ecn << (10

Some question about DCTCP implementation in FreeBSD

2019-06-04 Thread Yu He via freebsd-net
Greetings! I’m a graduate student from Carnegie Mellon University, and currently an intern in VMware. I’m now working on some internal project about implementing DCTCP algorithm and coming across the implementation in https://reviews.freebsd.org/rS277054. There is one thing I’m quite curious