Looking for feedback on change to iflib and transmit queuing

2022-07-29 Thread Eric Joyner
Hi, I have a Phabricator review here that I was hoping to get some feedback on: https://reviews.freebsd.org/D34742 In short, there's already some functionality in current and 13.1-RELEASE that allows a driver to pick a TX queue for a packet, but this extends that support to have iflib do some limi

Re: 25/100 G performance on freebsd

2022-08-11 Thread Eric Joyner
I think Benoit may be referring to this bug? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265207 >From that, it looks like his cards are QLogic ones that use the qlnxe driver. As for who would know what to do about that ioctl issue, I don't know. I'm not sure if the driver has an active maint

Re: Intel E810-C-Q2 adapter with 13.1-RELEASE

2023-02-24 Thread Eric Joyner
Hi, I'm not sure how to help here; it looks like there's either an issue with the firmware or a physical issue with the cage. Though, another option you could try would be to download the latest driver from the Intel Download Center and see if that works. If not, then also try the NVMupdate utilit

Re: Support for Firebox M270 and the Intel X553 MDIO

2023-12-15 Thread Eric Joyner
On Fri, Dec 15, 2023 at 12:51 AM Peter A Barlow wrote: > I’m looking at running FreeBSD on an old Firebox M270. > It has a C3558 CPU with integrated X553 LAN controller which connects over > MDIO to a Marvell 88E6190 switch. > Out of the box the X553 backplane is detected but there doesn’t seem t

Re: ixgbe i2c interface

2014-08-16 Thread Eric Joyner
I unofficially approve of it! --- Eric Joyner On Aug 16, 2014 12:21 PM, "Alexander V. Chernikov" wrote: > Hello Jack! > > Can you please commit (or let me commit) the following one-liner? > > ___ > freebsd-net@fre

Re: [RFC] Patch to improve TSO limitation formula in general

2014-09-05 Thread Eric Joyner
see if a segment in a TSO spans more than six mbufs and then m_defrag()'s the entire chain if one exists; it's less than optimal but necessary to prevent errors. - Eric --- - Eric Joyner On Fri, Sep 5, 2014 at 11:37 AM, Hans Petter Selasky wrote: > Hi, > > I've tested

Re: ixgbe CRITICAL: ECC ERROR!! Please Reboot!!

2014-09-08 Thread Eric Joyner
Getting local / remote faults is strange; are these stats from after you rebooted? --- - Eric Joyner On Fri, Sep 5, 2014 at 8:39 PM, Marcelo Gondim wrote: > On 05/09/2014 17:17, Marcelo Gondim wrote: > >> On 05/09/2014 16:49, Adrian Chadd wrote: >> >>> Hi, >&g

Re: [RFC] Patch to improve TSO limitation formula in general

2014-09-08 Thread Eric Joyner
Let me remove my concerns earlier in the thread -- this patch won't negatively affect any of our drivers; and the problem I mentioned with ixl would require a change somewhere further up the stack. --- - Eric Joyner On Mon, Sep 8, 2014 at 5:05 AM, Rick Macklem wrote: > Hans Petter

Re: [igb] add DROP_EN to each RX queue config if TX flow control is disabled

2014-09-13 Thread Eric Joyner
This looks good to me. The only comment I have is that according to the I350 datasheet, DROP_EN is already set on all the queues but 0 by default, but I haven't checked for the other adapters covered by igb. --- - Eric Joyner On Mon, Sep 8, 2014 at 10:12 PM, Adrian Chadd wrote: > Hi,

Re: Multipath TCP for FreeBSD v0.4

2014-09-17 Thread Eric Joyner
As a random person without commit privileges, I hope so, too. --- - Eric Joyner On Wed, Sep 17, 2014 at 8:44 AM, Sean Bruno wrote: > On Wed, 2014-09-17 at 12:58 +1000, Nigel Williams wrote: > > On 17/09/14 08:48, Sean Bruno wrote: > > > On Mon, 2014-09-08 at 11:32 +1000, Ni

Re: [PATCH] Convert ixl(4) and ixlv(4) to ifcounters, and fix some counter bugs

2014-09-26 Thread Eric Joyner
I approve of this patch -- I tested it on ixl and ixlv on stable/10, and at least the sysctl stats still look good. --- - Eric Joyner On Thu, Sep 25, 2014 at 5:08 AM, Gleb Smirnoff wrote: > On Tue, Sep 23, 2014 at 07:18:51PM -0400, Ryan Stone wrote: > R> The patch below converts the i

Media types in ifconfig

2014-10-20 Thread Eric Joyner
So, what are the two fields on the media line for? AFAICT, it looks like the first field is the media the user wants to use (so the driver typically sets it to Ethernet autoselect by default?), and the second field is for the media that's active in the interface. --- - Eric J

Re: ixgbe ifmedia handling

2014-10-22 Thread Eric Joyner
Hi, On Wed, Oct 22, 2014 at 3:43 AM, Alexander V. Chernikov < melif...@freebsd.org> wrote: > There is a problem with correct media reporting in ixgbe: > > ixgbe_setup_optics() is called only at ixgbe_attach(). > This means that: > 1) if SFP slot was empty at the attach() time, "media" part will b

Re: Adding new media types to if_media.h

2014-12-11 Thread Eric Joyner
Any other thoughts, or should I start looking at seeing what I can take copy from net80211? Also adding -net, since this is pretty relevant. On Tue, Dec 9, 2014 at 10:40 AM, Adrian Chadd wrote: > > On 9 December 2014 at 07:27, Rui Paulo wrote: > > On Dec 9, 2014, at 01:05, Eric J

Re: Adding new media types to if_media.h

2015-01-06 Thread Eric Joyner
Then going with what Mike says about leaving backwards compatibility, I suppose we should do something like what Adrian suggested, and add a separate struct. We can indicate that the separate struct exists by setting the media type value in the if_media word to 0xc0, since that's the last unused va

Re: Adding new media types to if_media.h

2015-02-19 Thread Eric Joyner
It does look good! We already have at least a half-dozen new media types to add. --- - Eric Joyner On Tue, Feb 17, 2015 at 9:26 AM, Adrian Chadd wrote: > Looks good to me. > > Thanks for doing this! > > > -a > > > On 16 February 2015 at 17:50, Mike Karels wro

Re: Adding new media types to if_media.h

2015-02-25 Thread Eric Joyner
nging the KPI so much, it'd be important to consider the "do we need an ethtool-equivalent" discussion. And I think we've lost a bunch of people who were in the original discussion from the to:/cc: list. --- - Eric Joyner On Wed, Feb 25, 2015 at 2:29 PM, Gleb Smirnoff wrote:

Re: FreeBSD 9.3 - Intel X520-SR2 stops passing packets

2015-05-21 Thread Eric Joyner
Are there any log messages printed out by the driver? The sysctls don't really look out of the ordinary, other than the number of sub-64 byte packets. On Thu, May 21, 2015 at 9:10 AM Guy Helmer wrote: > > > On May 21, 2015, at 8:52 AM, Christopher Forgeron > wrote: > > > > A few things: > > > >

Re: FreeBSD-head ixgbe build failed

2015-06-22 Thread Eric Joyner
I guess I could reverse-MFC r283668, then, to make that work on HEAD. On Mon, Jun 22, 2015, 12:07 PM Stefano Garzarella < stefanogarzare...@gmail.com> wrote: > Hi all, > I tried to compile FreeBSD-head with only "device ix" (without "device > ixv") but the build failed. > > I fixed this behavior

Re: FreeBSD-head ixgbe build failed

2015-06-24 Thread Eric Joyner
I made the change in r284767. It leaves out the backwards compatibility ixgbe build target that the stable/10 commit allowed, but you can now build the modules seperately. On Mon, Jun 22, 2015 at 2:29 PM Eric Joyner wrote: > I guess I could reverse-MFC r283668, then, to make that work on H

Re: Exposing full 32bit RSS hash from card for ixgbe(4)

2015-07-13 Thread Eric Joyner
Sorry for the delay; it looked fine to me, but I never got back to you. - Eric On Mon, Jul 13, 2015 at 3:16 PM Adrian Chadd wrote: > Hi, > > It's fine by me. Please do it! > > > -a > > > On 13 July 2015 at 13:05, hiren panchasara wrote: > > Here is the patch I'd like to push which exposes 32bi

Re: Displaying the supported module types of a network adapter

2015-07-17 Thread Eric Joyner
ixl(4) will list all of the supported module types for the device if you use ifconfig -m, but I know that isn't the intended purpose of the -m flag. I wouldn't mind moving all of that to another function whose purpose is to just list all supported module types. - Eric On Wed, Jul 15, 2015 at 3:26

Re: FreeBSD 10.2-STABLE + Intel XL710 - free queues

2015-08-19 Thread Eric Joyner
The IXLV_MAX_QUEUES value is for the VF driver; the standard driver should be able to allocate and properly use up to 64 queues. That said, you're only getting rx traffic on the first 16 queues, so that looks like a bug in the driver. I'll take a look at it. - Eric On Wed, Aug 19, 2015 at 11:00

Re: FreeBSD 10.2-STABLE + Intel XL710 - free queues

2015-08-19 Thread Eric Joyner
ude "opt_rss.h" > > #endif > > > > because RSS for is only in HEAD > > Could I break smth by doing this? > > > > Best regards, > > Evgeny Khorokhorin > > > > 19.08.2015 21:17, Eric Joyner пишет: > >> > >> The IXLV_MAX_Q

Re: FreeBSD 10.2-STABLE + Intel XL710 - free queues

2015-08-25 Thread Eric Joyner
Not yet; I think I will be able to get to it soon. - Eric On Mon, Aug 24, 2015 at 12:09 AM Evgeny Khorokhorin wrote: > Hi Eric, > > Did you manage to try this problem? > > - Evgeny > > 19.08.2015 23:16, Eric Joyner пишет: > > Yeah; it should be able to do up to 6

Re: pf+TSO patch

2015-10-02 Thread Eric Joyner
I don't know where that email goes, either. You should really open a bug report; it'll be something to start off of in investigating the issue. On Fri, Oct 2, 2015 at 5:01 AM Sossi Andrej wrote: > Kristof Provost je 02. 10. 2015 ob 13:24 napisal: > > On 2015-10-02 12:28:12 (+0200), Sossi Andrej

Re: nice stuff from cloudflare (and, we need something like ethtool!)

2015-10-23 Thread Eric Joyner
Bump -- I'd be okay with adding hooks to at least one Intel ethernet driver for whatever comes out of this. On Mon, Oct 19, 2015 at 1:47 AM Sepherosa Ziehau wrote: > On Fri, Oct 16, 2015 at 1:25 PM, Jim Thompson wrote: > > > > > > > >> On Oct 16, 2015, at 12:06 AM, Ian Smith wrote: > >> > >>>

Re: ixl 40G bad performance?

2015-10-23 Thread Eric Joyner
Bruce mostly has it right -- ITR is the minimum latency between interrupts. But, it does actually guarantee a minimum period between interrupts. Though, Fortville actually is unique a little bit in that there is another ITR setting that can ensure a certain average number of interrupts per second (

Re: ixl(4) RSS hash type

2017-09-11 Thread Eric Joyner
I think that sounds right; but Adrian is the one who put the code in the #ifdef RSS blocks in. We don't have it enabled/defined in our testing here. - Eric On Sun, Sep 10, 2017 at 8:01 PM Sepherosa Ziehau wrote: > Hi all, > > I am on the way to cleanup the UDP_IPV4_EX bit. The only effective >

Re: Intel XL710 broken link down detection?

2015-11-11 Thread Eric Joyner
I think the early versions of the description of the command were vague, so that's why it got everyone. We caught it and fixed it a few days ago internally. On Wed, Nov 11, 2015, 8:37 AM Jack Vogel wrote: > LOL, Damn, what's the world coming to when you can't trust them Linux guys > :) > > Jack

Re: [Patch] Changing mac address does not always work

2016-06-08 Thread Eric Joyner
I think a better fix here is to have the driver not call init_locked() when the driver is not running when setting the MTU. It looks like all the other Intel network drivers do the same thing as this for the MTU. On Wed, Jun 8, 2016 at 2:47 AM Arnaud YSMAL wrote: > Hi, > > Configuring the netwo

Re: Slow performance with Intel X540-T2 10Gb NIC

2016-07-21 Thread Eric Joyner
(Replying-all this time) Did you try to set these settings that ESnet recommends? https://fasterdata.es.net/host-tuning/freebsd/ We don't use iperf3 here at Intel (we use netperf instead), so I'm not sure I can be much help diagnosing what's wrong. On Wed, Jul 20, 2016 at 5:39 PM Chris Dunbar w

Re: X540 + arista switch

2016-08-22 Thread Eric Joyner
I'll add Jeff to this conversation since he might know more about specific interactions between our cards and switches. I'll see if anyone else internally knows something, too. As for where to go from here, I don't know what else you can do other than contact Intel support. - Eric On Mon, Aug 22

Re: Will this card (probably) work?

2016-09-20 Thread Eric Joyner
There are SFP i350 cards, but hopefully this one has a valid eeprom and isn't counterfeit. I remember someone submitted a bug for ixgbe where the device ID showed up as 0x0001 and they wanted to patch that into the driver. On Tue, Sep 20, 2016 at 9:02 AM Jack Vogel wrote: > On Tue, Sep 20, 2016

Re: Will this card (probably) work?

2016-09-20 Thread Eric Joyner
Other OEMs can make their own designs that use Intel chips -- e.g. Silicom makes a 6-port full height SFP card that combines a 4-port I350AM4 with a 2-port I350 AM2. It's just that the further away you get from an Intel design, the less support we'll be able to give you if something goes wrong. An

Differential review to add new media types to if_media.h

2017-04-18 Thread Eric Joyner
https://reviews.freebsd.org/D10425 I didn't add any reviewers yet because we have yet to test this, and I didn't have a good idea of who would be interested in these. Suggestions on the string to give the active optical/copper cable types would be welcome; I gave them the acronyms I saw in SFF-802

Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-01-29 Thread Eric Joyner
Hi freebsd-net, We've encountered an issue with unloading the iavf(4) driver on FreeBSD 12.1 (and stable). On a VM with two iavf(4) interfaces, if we send heavy traffic to iavf1 and try to kldunload the driver, the kldunload process hangs on iavf0 until iavf1 stops receiving traffic. After some d

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-01-29 Thread Eric Joyner
On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky wrote: > On 2020-01-29 22:30, Eric Joyner wrote: > > Hi freebsd-net, > > > > We've encountered an issue with unloading the iavf(4) driver on FreeBSD > > 12.1 (and stable). On a VM with two iavf(4) interfaces,

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-01-29 Thread Eric Joyner
On Wed, Jan 29, 2020 at 5:12 PM Hans Petter Selasky wrote: > On 2020-01-29 22:44, Eric Joyner wrote: > > On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky > wrote: > > > >> On 2020-01-29 22:30, Eric Joyner wrote: > >>> Hi freebsd-net, > >>>

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-01-31 Thread Eric Joyner
On Wed, Jan 29, 2020 at 7:09 PM Mark Johnston wrote: > On Thu, Jan 30, 2020 at 02:12:05AM +0100, Hans Petter Selasky wrote: > > On 2020-01-29 22:44, Eric Joyner wrote: > > > On Wed, Jan 29, 2020 at 1:41 PM Hans Petter Selasky > wrote: > > > > > > &

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-02-10 Thread Eric Joyner
On Fri, Jan 31, 2020 at 11:44 AM Eric Joyner wrote: > On Wed, Jan 29, 2020 at 7:09 PM Mark Johnston wrote: > >> On Thu, Jan 30, 2020 at 02:12:05AM +0100, Hans Petter Selasky wrote: >> > On 2020-01-29 22:44, Eric Joyner wrote: >> > > On Wed, Jan 29, 2020 at 1:41

Re: How to work with in 1GbE network ?

2020-02-19 Thread Eric Joyner
Have you tried turning off jumbo frames? - Eric On Tue, Feb 18, 2020 at 10:04 PM KIRIYAMA Kazuhiko wrote: > Hi, all > > I wonder how to work ixgbe in 1GbE network. I tried to test > in below: > > internet > | > +---++ > | Netgear JGS516 | > +---+-+--+ +-

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-03-11 Thread Eric Joyner
On Wed, Feb 12, 2020 at 2:22 PM Mark Johnston wrote: > On Mon, Feb 10, 2020 at 01:30:47PM -0800, Eric Joyner wrote: > > On Fri, Jan 31, 2020 at 11:44 AM Eric Joyner wrote: > > > Hi Mark, > > > > > > I applied your patch to a FreeBSD-current VM and reran the

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-03-30 Thread Eric Joyner
On Sat, Mar 28, 2020 at 3:52 PM Mark Johnston wrote: > On Wed, Mar 11, 2020 at 04:32:40PM -0700, Eric Joyner wrote: > > Mark, > > > > I did get some time to get back and retry this; however your second patch > > still doesn't solve the problem. Looking

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-03-31 Thread Eric Joyner
ic On Mon, Mar 30, 2020 at 1:19 PM Eric Joyner wrote: > On Sat, Mar 28, 2020 at 3:52 PM Mark Johnston wrote: > >> On Wed, Mar 11, 2020 at 04:32:40PM -0700, Eric Joyner wrote: >> > Mark, >> > >> > I did get some time to get back and retry this; however your sec

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-06 Thread Eric Joyner
On Tue, Mar 31, 2020 at 12:28 PM Mark Johnston wrote: > On Tue, Mar 31, 2020 at 12:14:20PM -0700, Eric Joyner wrote: > > Mark, > > > > I tried out a kernel with the tip of CURRENT with both D24214 and D24215 > > applied, and I still see the problem. As

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-06 Thread Eric Joyner
On Mon, Apr 6, 2020 at 2:29 PM Mark Johnston wrote: > On Mon, Apr 06, 2020 at 02:19:25PM -0700, Eric Joyner wrote: > > Mark, > > > > I think I was mistaken about the backtrace looking the same. I was > looking > > at it from within ddb

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-09 Thread Eric Joyner
On Tue, Apr 7, 2020 at 4:24 PM Mark Johnston wrote: > On Mon, Apr 06, 2020 at 02:34:50PM -0700, Eric Joyner wrote: > > On Mon, Apr 6, 2020 at 2:29 PM Mark Johnston wrote: > > > > > On Mon, Apr 06, 2020 at 02:19:25PM -0700, Eric Joyner wrote: > > > > Mark, &g

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-09 Thread Eric Joyner
On Thu, Apr 9, 2020 at 2:02 PM Eric Joyner wrote: > On Tue, Apr 7, 2020 at 4:24 PM Mark Johnston wrote: > >> On Mon, Apr 06, 2020 at 02:34:50PM -0700, Eric Joyner wrote: >> > On Mon, Apr 6, 2020 at 2:29 PM Mark Johnston wrote: >> > >> > > On Mon, Apr

Re: Issue with epoch_drain_callbacks and unloading iavf(4) [using iflib]

2020-04-20 Thread Eric Joyner
On Thu, Apr 9, 2020 at 2:29 PM Eric Joyner wrote: > On Thu, Apr 9, 2020 at 2:02 PM Eric Joyner wrote: > >> On Tue, Apr 7, 2020 at 4:24 PM Mark Johnston wrote: >> >>> I spent some time looking at the core. It looks like we have yet >>> another problem: th

Re: HW timestamping e1000

2020-06-11 Thread Eric Joyner
Like Konstantin said, it might only be possible on some e1000 cards. Could you tell me which card you're using? If the device name shows up as igb, then it's likely it does support it. That said, I'm not an expert on HW timestamping, so I'm not sure what features are supported or how well they're

Re: iflib tx watchdog doesn't appear that it can work anymore

2020-11-09 Thread Eric Joyner
I'll add Piotr, the author of your linked patch, to this thread. Are you seeing a problem connected to the watchdog? Piotr tells me that IFLIB_QUEUE_WORKING isn't used now, but it wasn't even used before his patch. - Eric On Wed, Nov 4, 2020 at 8:47 AM Ryan Stone wrote: > https://svnweb.freebs

Re: igb fc (aka flowcontrol) issue...

2021-08-01 Thread Eric Joyner
On Sun, Aug 1, 2021 at 6:59 PM John-Mark Gurney wrote: > I have a dual port igb card: > igb0: port 0x2020-0x203f mem > 0xd102-0xd103,0xd0c0-0xd0ff,0xd1044000-0xd1047fff irq 17 at > device 0.0 on pci3 > igb0: Using 1024 TX descriptors and 1024 RX descriptors > igb0: Using 4 RX que

Re: debugnet_any_ifnet_update: Bad dn_init result

2022-03-07 Thread Eric Joyner
On Mon, Feb 28, 2022 at 7:01 AM Franco Fichtner wrote: > Hi Mark, > > On 28. Feb 2022, at 15:51, Mark Johnston wrote: > > Do you have any idea what triggers the message in the first place? I > haven't seen it on my igb-using systems. > > > No but I have hardware here that does this. Short dmesg

[Differential] [Changed Subscribers] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other

2015-01-28 Thread erj (Eric Joyner)
erj added a subscriber: erj. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, imp, hselasky, adrian, sbruno, lstewart Cc: erj, freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freeb

[Differential] [Changed Subscribers] D1965: Add extended media types to if_media.h and ifconfig

2015-02-25 Thread erj (Eric Joyner)
erj added a subscriber: freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1965 To: erj, gnn, jfvogel Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail t

[Differential] [Updated] D1965: Add extended media types to if_media.h and ifconfig

2015-02-25 Thread erj (Eric Joyner)
erj added a reviewer: adrian. REVISION DETAIL https://reviews.freebsd.org/D1965 To: erj, gnn, jfvogel, adrian Cc: freebsd-net ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail

[Differential] D6688: net: Use M_HASHTYPE_OPAQUE_HASH if the mbuf flowid has hash properties

2016-06-02 Thread erj (Eric Joyner)
___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"