[Bug 220198] igb stats double counting in 12-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220198

--- Comment #5 from Daniel Ponte  ---
Oops, disregard.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 220198] igb stats double counting in 12-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220198

Daniel Ponte  changed:

   What|Removed |Added

 CC||ami...@gmail.com

--- Comment #4 from Daniel Ponte  ---
I have cherry-picked this into my local stable/13 and can also confirm that
this fixes the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 220198] igb stats double counting in 12-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220198

Kaho Toshikazu  changed:

   What|Removed |Added

 CC||k...@elam.kais.kyoto-u.ac.j
   ||p

--- Comment #3 from Kaho Toshikazu  ---
(In reply to commit-hook from comment #1)

I think the bug is fixed by this commit, but it is not a good way.

1. Every driver using iflib should set IFCAP_HWSTATS flag within the driver.
For example, in the em(4) driver, add IFCAP_HWSTATS flag
into #define EM_CAPS and #define IGB_CAPS lines of if_em.c.

2. The IFCAP_FLAGS in iflib.c seems to hold flags which can be changed by
a ioctl function. Who want to set or unset the IFCAP_HWSTATS flag
by a function?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 220198] igb stats double counting in 12-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220198

--- Comment #2 from Ben Woods  ---
Hi Sean,
I can confirm this has fixed the error.
Thanks for your help!
-Ben

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 220198] igb stats double counting in 12-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220198

Sean Bruno  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|New |Closed

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 220198] igb stats double counting in 12-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220198

--- Comment #1 from commit-h...@freebsd.org ---
A commit references this bug:

Author: sbruno
Date: Thu Aug 10 03:11:05 UTC 2017
New revision: 322337
URL: https://svnweb.freebsd.org/changeset/base/322337

Log:
  Export IFCAP_HWSTATS so that we don't experience double stats counting
  on iflib enabled devices.

  PR:   220198
  Submitted by: Matt Macy 
  Reported by:  Ben Woods 
  Sponsored by: Limelight Networks

Changes:
  head/sys/net/iflib.c

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 220198] igb stats double counting in 12-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220198

Ben Woods  changed:

   What|Removed |Added

   Keywords||IntelNetworking

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Bug 220198] igb stats double counting in 12-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220198

Ben Woods  changed:

   What|Removed |Added

 CC||sbr...@freebsd.org
   Assignee|freebsd-b...@freebsd.org|freebsd-net@FreeBSD.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"