Re: Request for new port review: TortoiseHG.

2011-02-10 Thread arrowdodger
I've updated port. The only thing left - setting dependency on py-gobject by USE_GNOME variable. But if i run pkg_info -f on installed port, i see: Dependency: py26-gobject-2.26.0 dependency origin: devel/py-gobject So, maybe this dependency is implicit and i should not care? Updated

Re: Request for new port review: TortoiseHG.

2011-02-10 Thread Sunpoet Po-Chuan Hsieh
On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote: I've updated port. The only thing left - setting dependency on py-gobject by USE_GNOME variable. But if i run pkg_info -f on installed port, i see: Dependency: py26-gobject-2.26.0 dependency origin: devel/py-gobject

Re: Request for new port review: TortoiseHG.

2011-02-10 Thread arrowdodger
On Thu, Feb 10, 2011 at 5:35 PM, Sunpoet Po-Chuan Hsieh sunp...@freebsd.org wrote: On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote: I've updated port. The only thing left - setting dependency on py-gobject by USE_GNOME variable. But if i run pkg_info -f on installed port, i

Re: Request for new port review: TortoiseHG.

2011-02-10 Thread Eitan Adler
How should i submit new port? Open an PR? There are two easy ways to submit the port. The first is to use send-pr(1) or the web base form to submit the problem report. Please make sure to submit it as a shar and use the change-request option. The second way does the above for you. Install

Re: Request for new port review: TortoiseHG.

2011-02-10 Thread Koop Mast
On Thu, 2011-02-10 at 18:21 +0300, arrowdodger wrote: On Thu, Feb 10, 2011 at 5:35 PM, Sunpoet Po-Chuan Hsieh sunp...@freebsd.org wrote: On Thu, Feb 10, 2011 at 04:36:40PM +0300, arrowdodger wrote: I've updated port. The only thing left - setting dependency on py-gobject by

Re: Request for new port review: TortoiseHG.

2011-02-09 Thread arrowdodger
On Tue, Feb 8, 2011 at 9:29 PM, Sunpoet Hsieh sunp...@sunpoet.net wrote: Hi, First of all, I suggest to set PORTNAME=tortoisehg If you do want to add -hgtk suffix, you may set PKGNAMESUFFIX=-hgtk instead. It makes portlint happier. It also simplifies Makefile since DISTNAME is already the

Re: Request for new port review: TortoiseHG.

2011-02-09 Thread Sunpoet Hsieh
On Wed, Feb 9, 2011 at 5:15 PM, arrowdodger 6year...@gmail.com wrote: On Tue, Feb 8, 2011 at 9:29 PM, Sunpoet Hsieh sunp...@sunpoet.net wrote: Hi, First of all, I suggest to set PORTNAME=tortoisehg If you do want to add -hgtk suffix, you may set PKGNAMESUFFIX=-hgtk instead. It makes

Re: Request for new port review: TortoiseHG.

2011-02-09 Thread arrowdodger
On Wed, Feb 9, 2011 at 4:42 PM, Sunpoet Hsieh sunp...@sunpoet.net wrote: It looks like you'll have two ports, version 1 and 2, and these two ports do not conflict with each other. IMHO, I would simply use devel/tortoisehg1 for version 1 and devel/tortoisehg for upcoming version 2. You do not

Re: Request for new port review: TortoiseHG.

2011-02-09 Thread Sunpoet Hsieh
On Wed, Feb 09, 2011 at 06:24:34PM +0300, arrowdodger wrote: On Wed, Feb 9, 2011 at 4:42 PM, Sunpoet Hsieh sunp...@sunpoet.net wrote: It looks like you'll have two ports, version 1 and 2, and these two ports do not conflict with each other. IMHO, I would simply use devel/tortoisehg1 for

Request for new port review: TortoiseHG.

2011-02-08 Thread arrowdodger
Hello. I've made a port for TortoiseHG (in fact, for its hgtk script). It is my first attempt in port creation, so i want someone to review it. The current problems are following: 1. The user can choose to not install nautilus extension and translation files (if defined(WITHOUT_NLS)). To prevent

Re: Request for new port review: TortoiseHG.

2011-02-08 Thread Ruslan Mahmatkhanov
Hi, 08.02.2011 14:40, arrowdodger пишет: Hello. I've made a port for TortoiseHG (in fact, for its hgtk script). It is my first attempt in port creation, so i want someone to review it. The current problems are following: 1. The user can choose to not install nautilus extension and translation

Re: Request for new port review: TortoiseHG.

2011-02-08 Thread arrowdodger
On Tue, Feb 8, 2011 at 4:05 PM, Ruslan Mahmatkhanov cvs-...@yandex.ruwrote: It shouldn't be listed in pkg-plist, because it will be removed automatically on port deinstall. Well, if i 'make PREFIX=/home/arr/prefix install make PREFIX=/home/arr/prefix deinstall' then this file is not deleted.

Re: Request for new port review: TortoiseHG.

2011-02-08 Thread Ruslan Mahmatkhanov
08.02.2011 16:29, arrowdodger пишет: On Tue, Feb 8, 2011 at 4:05 PM, Ruslan Mahmatkhanovcvs-...@yandex.ruwrote: It shouldn't be listed in pkg-plist, because it will be removed automatically on port deinstall. Well, if i 'make PREFIX=/home/arr/prefix install make PREFIX=/home/arr/prefix

Re: Request for new port review: TortoiseHG.

2011-02-08 Thread Eitan Adler
On Tue, Feb 8, 2011 at 6:40 AM, arrowdodger 6year...@gmail.com wrote: Hello. I've made a port for TortoiseHG (in fact, for its hgtk script). It is my first attempt in port creation, so i want someone to review it. Hi, Congrats on your first attempt! Here are a few issues with the port. Please