Re: blanket portmgr approval vs. non-fixing changes

2016-06-29 Thread Baptiste Daroussin
On Wed, Jun 29, 2016 at 06:35:46PM +0200, Michelle Sullivan wrote: > Mathieu Arnold wrote: > > +--On 29 juin 2016 13:15:44 +0200 Michelle Sullivan > > wrote: > > | Baptiste Daroussin wrote: > > |> On Tue, Jun 28, 2016 at 11:15:56PM +0200, Matthias Andree wrote: > > |>> > > |>> And I do think we sh

Re: blanket portmgr approval vs. non-fixing changes

2016-06-29 Thread Michelle Sullivan
Mathieu Arnold wrote: +--On 29 juin 2016 13:15:44 +0200 Michelle Sullivan wrote: | Baptiste Daroussin wrote: |> On Tue, Jun 28, 2016 at 11:15:56PM +0200, Matthias Andree wrote: |>> |>> And I do think we should, opposite to what you are proposing, make the |>> committer spend extra time for high-

Re: blanket portmgr approval vs. non-fixing changes

2016-06-29 Thread Mathieu Arnold
+--On 29 juin 2016 13:15:44 +0200 Michelle Sullivan wrote: | Baptiste Daroussin wrote: |> On Tue, Jun 28, 2016 at 11:15:56PM +0200, Matthias Andree wrote: |>> |>> And I do think we should, opposite to what you are proposing, make the |>> committer spend extra time for high-profile ports that enta

Re: blanket portmgr approval vs. non-fixing changes

2016-06-29 Thread Michelle Sullivan
Baptiste Daroussin wrote: On Tue, Jun 28, 2016 at 11:15:56PM +0200, Matthias Andree wrote: And I do think we should, opposite to what you are proposing, make the committer spend extra time for high-profile ports that entail sweeping changes to chase down the breaking change to, say, a library p

Re: blanket portmgr approval vs. non-fixing changes

2016-06-28 Thread Baptiste Daroussin
On Tue, Jun 28, 2016 at 11:15:56PM +0200, Matthias Andree wrote: > Am 28.06.2016 um 11:17 schrieb Baptiste Daroussin: > > > What you are asking is part of the blanket in particular when changing > > things in > > individual ports, we expect committers to have a look at pending PR (yes I > > know

Re: blanket portmgr approval vs. non-fixing changes

2016-06-28 Thread Matthias Andree
Am 28.06.2016 um 11:17 schrieb Baptiste Daroussin: > What you are asking is part of the blanket in particular when changing things > in > individual ports, we expect committers to have a look at pending PR (yes I > know > I have been guilty of individual port change without sometime checking abo

Re: blanket portmgr approval vs. non-fixing changes

2016-06-28 Thread Matthias Andree
Am 27.06.2016 um 18:07 schrieb Cy Schubert: > Mathias, Cy, Mind the double t please. > I'm surprised at your position. I recall a commit you made to one of my > ports a few years ago, to which I objected. Your position now is a complete > reversal of your arguments then. Quite possible. Thi

Re: blanket portmgr approval vs. non-fixing changes

2016-06-28 Thread Matthias Andree
Am 27.06.2016 um 12:02 schrieb Guido Falsi: >> 2. What I was meaning to state was that (and I'll not pick at the >> kind soul who has modernized the port) we should only apply the >> blanket approval if ports have fallen into disrepair. > > I'd say that it's a matter of urgency for the change. Ne

Re: blanket portmgr approval vs. non-fixing changes

2016-06-28 Thread Kubilay Kocak
On 28/06/2016 9:03 PM, Alphons van Werven wrote: > Maintainers are already notified by e-mail of commits resulting from PRs > because they are put on the CC list. Maybe it's just me, but I think it > would be very nice if maintainers were *always* automagically notified of > *any* commits to their

Re: blanket portmgr approval vs. non-fixing changes

2016-06-28 Thread Alphons van Werven
Kevin Golding wrote: > and about the same time someone did a blanket update of RUN_DEPENDS in > my ports. Including a PORTREVISION bump. It's easy to argue that's a > very trivial change that doesn't needs maintainer involvement, but it > also impacted my day. [snip] > Had I known about the blanke

Re: blanket portmgr approval vs. non-fixing changes

2016-06-28 Thread Baptiste Daroussin
On Tue, Jun 28, 2016 at 09:12:46AM +0100, Kevin Golding wrote: > On Mon, 27 Jun 2016 21:21:31 +0100, Cy Schubert > wrote: > > > In message <57716d89.1050...@sorbs.net>, Michelle Sullivan writes: > > > > Don't forget that many people see their name/email in the maintainer > > > line as being resp

Re: blanket portmgr approval vs. non-fixing changes

2016-06-28 Thread Kevin Golding
On Mon, 27 Jun 2016 21:21:31 +0100, Cy Schubert wrote: In message <57716d89.1050...@sorbs.net>, Michelle Sullivan writes: Don't forget that many people see their name/email in the maintainer line as being responsible for the port.. so someone goes makes blanket changes which actually break

Re: blanket portmgr approval vs. non-fixing changes

2016-06-27 Thread Cy Schubert
In message <57716d89.1050...@sorbs.net>, Michelle Sullivan writes: > Kubilay Kocak wrote: > > > > All: How did you feel the first time you saw your email on a maintainer > > line? That is priceless and shouldn't be confused with the 'bad' kind of > > ownership. > > > > Don't forget that many peopl

Re: blanket portmgr approval vs. non-fixing changes

2016-06-27 Thread Michelle Sullivan
Kubilay Kocak wrote: All: How did you feel the first time you saw your email on a maintainer line? That is priceless and shouldn't be confused with the 'bad' kind of ownership. Don't forget that many people see their name/email in the maintainer line as being responsible for the port.. so so

Re: blanket portmgr approval vs. non-fixing changes (was: svn commit: r417590 - in head/databases/db6: . files and 417595 (revert))

2016-06-27 Thread Cy Schubert
In message <5770eed4.1070...@tu-dortmund.de>, Matthias Andree writes: > [Sorry for this re-send, I feel we need to re-send thisto ports@ so the > discussion goes to a public and archived list.] > > Am 27.06.2016 um 10:16 schrieb Mathieu Arnold: > > > > > > +--On 27 juin 2016 16:10:36 +0800 Marce

Re: blanket portmgr approval vs. non-fixing changes

2016-06-27 Thread Adam Weinberger
> On 27 Jun, 2016, at 9:22, Kubilay Kocak wrote: > > On 28/06/2016 12:25 AM, Adam Weinberger wrote: >>> On 27 Jun, 2016, at 3:27, Marcelo Araujo >>> wrote: >>> >>> >>> >>> 2016-06-27 16:58 GMT+08:00 Matthias Andree >>> : Am 27.06.2016 um 10:16 schrieb >>> Mathieu Arnold: +--O

Re: blanket portmgr approval vs. non-fixing changes

2016-06-27 Thread Kubilay Kocak
On 28/06/2016 12:25 AM, Adam Weinberger wrote: >> On 27 Jun, 2016, at 3:27, Marcelo Araujo >> wrote: >> >> >> >> 2016-06-27 16:58 GMT+08:00 Matthias Andree >> : Am 27.06.2016 um 10:16 schrieb >> Mathieu Arnold: >>> >>> >>> +--On 27 juin 2016 16:10:36 +0800 Marcelo Araujo >>> wrote: | 2016-06

Re: blanket portmgr approval vs. non-fixing changes (was: svn commit: r417590 - in head/databases/db6: . files and 417595 (revert))

2016-06-27 Thread Kurt Jaeger
Hi! [adamw] > Maintainership too often means that change requests get ignored > for two weeks before they're committed. That is the case sometimes, yes. But oftern maintainership provides identification with the project and proud of achievement etc, which causes people to invest time and skills

Re: blanket portmgr approval vs. non-fixing changes (was: svn commit: r417590 - in head/databases/db6: . files and 417595 (revert))

2016-06-27 Thread Adam Weinberger
> On 27 Jun, 2016, at 3:27, Marcelo Araujo wrote: > > > > 2016-06-27 16:58 GMT+08:00 Matthias Andree : > Am 27.06.2016 um 10:16 schrieb Mathieu Arnold: > > > > > > +--On 27 juin 2016 16:10:36 +0800 Marcelo Araujo > > wrote: > > | 2016-06-27 16:02 GMT+08:00 Mathieu Arnold : > > |> | Read here f

Re: blanket portmgr approval vs. non-fixing changes

2016-06-27 Thread Guido Falsi
On 06/27/16 11:16, Matthias Andree wrote: > [Sorry for this re-send, I feel we need to re-send thisto ports@ so the > discussion goes to a public and archived list.] > > Am 27.06.2016 um 10:16 schrieb Mathieu Arnold: >> >> >> +--On 27 juin 2016 16:10:36 +0800 Marcelo Araujo >> wrote: >> | 2016-06

Re: blanket portmgr approval vs. non-fixing changes (was: svn commit: r417590 - in head/databases/db6: . files and 417595 (revert))

2016-06-27 Thread Marcelo Araujo
2016-06-27 16:58 GMT+08:00 Matthias Andree : > Am 27.06.2016 um 10:16 schrieb Mathieu Arnold: > > > > > > +--On 27 juin 2016 16:10:36 +0800 Marcelo Araujo < > araujobsdp...@gmail.com> > > wrote: > > | 2016-06-27 16:02 GMT+08:00 Mathieu Arnold : > > |> | Read here for reference: > > |> | > > |> > h

blanket portmgr approval vs. non-fixing changes (was: svn commit: r417590 - in head/databases/db6: . files and 417595 (revert))

2016-06-27 Thread Matthias Andree
[Sorry for this re-send, I feel we need to re-send thisto ports@ so the discussion goes to a public and archived list.] Am 27.06.2016 um 10:16 schrieb Mathieu Arnold: > > > +--On 27 juin 2016 16:10:36 +0800 Marcelo Araujo > wrote: > | 2016-06-27 16:02 GMT+08:00 Mathieu Arnold : > |> | Read here