Re: ioquake3 support more platforms

2009-12-19 Thread Doug Barton
Dominic Fandrey wrote: But that's not different for any port. E.g. sysutils/bsdadminscripts is all mine, I create the distfiles and maintain the port, their is no guarantee that I don't do evil apart from me being quite certain that I don't. Mark already pointed out that maintainers and

Re: ioquake3 support more platforms

2009-12-19 Thread Dominic Fandrey
Doug Barton wrote: Dominic Fandrey wrote: But that's not different for any port. E.g. sysutils/bsdadminscripts is all mine, I create the distfiles and maintain the port, their is no guarantee that I don't do evil apart from me being quite certain that I don't. Mark already pointed out that

Re: ioquake3 support more platforms

2009-12-19 Thread Dominic Fandrey
b. f. wrote: On Fri, Dec 18, 2009 at 02:50:31PM +0100, Dominic Fandrey wrote: So when I submitted ioquake3-1.36 I condemned some poor committer to read 366609 lines of code? We expect them to test-install the initial code to make sure it's not malware. We expect them to scan the diffs to

Re: ioquake3 support more platforms

2009-12-19 Thread Mark Linimon
On Sat, Dec 19, 2009 at 04:02:31PM +0100, Dominic Fandrey wrote: I don't see the wiggle room for anything spontaneously changing when properly checksummed distfiles are involved. Alright, then I misread it. mcl ___ freebsd-ports@freebsd.org mailing

Re: ioquake3 support more platforms

2009-12-19 Thread Doug Barton
Dominic Fandrey wrote: But this is not the case we're talking about (I explained the process in sufficient detail, I think). I take an up to date snapshot, apply my patch set, make a couple of test builds and runs, update the patch set until everything works as expected. Than I wrap the whole

Re: ioquake3 support more platforms

2009-12-19 Thread Dominic Fandrey
Doug Barton wrote: Dominic Fandrey wrote: But this is not the case we're talking about (I explained the process in sufficient detail, I think). I take an up to date snapshot, apply my patch set, make a couple of test builds and runs, update the patch set until everything works as expected.

Re: ioquake3 support more platforms

2009-12-18 Thread Dominic Fandrey
Mark Linimon wrote: On Thu, Dec 17, 2009 at 04:48:43PM +0100, Dominic Fandrey wrote: A committer explained to me that he doesn't want to deal with SVN snapshot based ports. Is that a common attitude and what should I do to remedy this? Well, the problem is that we (FreeBSD) can't guarantee

Re: ioquake3 support more platforms

2009-12-18 Thread Mark Linimon
On Fri, Dec 18, 2009 at 12:31:38PM +0100, Dominic Fandrey wrote: But that's not different for any port. E.g. sysutils/bsdadminscripts is all mine, I create the distfiles and maintain the port, their is no guarantee that I don't do evil apart from me being quite certain that I don't. Sure

Re: ioquake3 support more platforms

2009-12-18 Thread Dominic Fandrey
Mark Linimon wrote: On Fri, Dec 18, 2009 at 12:31:38PM +0100, Dominic Fandrey wrote: But that's not different for any port. E.g. sysutils/bsdadminscripts is all mine, I create the distfiles and maintain the port, their is no guarantee that I don't do evil apart from me being quite certain that

Re: ioquake3 support more platforms

2009-12-18 Thread Mark Linimon
On Fri, Dec 18, 2009 at 01:43:20PM +0100, Dominic Fandrey wrote: Are committers really supposed to read the code? Yes. mcl ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail

Re: ioquake3 support more platforms

2009-12-18 Thread Dominic Fandrey
Mark Linimon wrote: On Fri, Dec 18, 2009 at 01:43:20PM +0100, Dominic Fandrey wrote: Are committers really supposed to read the code? Yes. So when I submitted ioquake3-1.36 I condemned some poor committer to read 366609 lines of code? ___

Re: ioquake3 support more platforms

2009-12-18 Thread Mark Linimon
On Fri, Dec 18, 2009 at 02:50:31PM +0100, Dominic Fandrey wrote: So when I submitted ioquake3-1.36 I condemned some poor committer to read 366609 lines of code? We expect them to test-install the initial code to make sure it's not malware. We expect them to scan the diffs to make sure the

Re: ioquake3 support more platforms

2009-12-18 Thread b. f.
On Fri, Dec 18, 2009 at 02:50:31PM +0100, Dominic Fandrey wrote: So when I submitted ioquake3-1.36 I condemned some poor committer to read 366609 lines of code? We expect them to test-install the initial code to make sure it's not malware. We expect them to scan the diffs to make sure the

ioquake3 support more platforms

2009-12-17 Thread Dominic Fandrey
Hello, I'm maintaining games/ioquake3 and games/ioquake3-devel and I'd like to support more platforms than i386 and amd64. If anyone would like to support me, please apply the patch from ports/141453: http://www.freebsd.org/cgi/query-pr.cgi?pr=141453 Remove the ONLY_FOR_ARCHS line in

Re: ioquake3 support more platforms

2009-12-17 Thread Mark Linimon
On Thu, Dec 17, 2009 at 04:48:43PM +0100, Dominic Fandrey wrote: A committer explained to me that he doesn't want to deal with SVN snapshot based ports. Is that a common attitude and what should I do to remedy this? Well, the problem is that we (FreeBSD) can't guarantee whether the contents of