[Patch] Proposal: USE_GNU89 switch

2009-05-30 Thread Ed Schouten
Hi, I'm proposing the following patch: --- bsd.port.mk +++ bsd.port.mk @@ -2180,6 +2180,10 @@ .endif .endif +.if defined(USE_CSTD) +CFLAGS+= -std=${USE_CSTD} +.endif + # Multiple make jobs support .if defined(DISABLE_MAKE_JOBS) || defined(MAKE_JOBS_UNSAFE) _MAKE_JOBS=#

Re: [Patch] Proposal: USE_GNU89 switch

2009-05-30 Thread Ed Schouten
* Gabor Kovesdan ga...@freebsd.org wrote: I don't think it's a good idea. This knob is completely superfluous and thus should be avoided. One can just add -std to CFLAGS from a port Makefile. Forced build are also possible without this stuff, you can set this in /etc/make.conf. So how

Re: [Patch] Proposal: USE_GNU89 switch

2009-05-30 Thread Gabor Kovesdan
Ed Schouten escribió: * Gabor Kovesdan ga...@freebsd.org wrote: I don't think it's a good idea. This knob is completely superfluous and thus should be avoided. One can just add -std to CFLAGS from a port Makefile. Forced build are also possible without this stuff, you can set this in

Re: [Patch] Proposal: USE_GNU89 switch

2009-05-30 Thread Gabor Kovesdan
Ed Schouten escribió: Hi, I'm proposing the following patch: --- bsd.port.mk +++ bsd.port.mk @@ -2180,6 +2180,10 @@ .endif .endif +.if defined(USE_CSTD) +CFLAGS+= -std=${USE_CSTD} +.endif + # Multiple make jobs support .if defined(DISABLE_MAKE_JOBS) || defined(MAKE_JOBS_UNSAFE)

Re: [Patch] Proposal: USE_GNU89 switch

2009-05-30 Thread Ed Schouten
* Gabor Kovesdan ga...@freebsd.org wrote: As for LLVM, probably it won't work out for the whole ports tree. I don't know what's the portmgr opinion on this, if we start to use LLVM in Ports Collection, we should reconsider the knob, though. LLVM/Clang support is trivial. Erwin Lansing

Re: [Patch] Proposal: USE_GNU89 switch

2009-05-30 Thread Diane Bruce
Hi, On Sat, May 30, 2009 at 04:34:43PM +0200, Ed Schouten wrote: * Gabor Kovesdan ga...@freebsd.org wrote: As for LLVM, probably it won't work out for the whole ports tree. I don't know what's the portmgr opinion on this, if we start to use LLVM in Ports Collection, we should reconsider

Re: [Patch] Proposal: USE_GNU89 switch

2009-05-30 Thread Mel Flynn
On Saturday 30 May 2009 16:21:52 Ed Schouten wrote: Really, I really don't care how it's done, whether it's a flag or added to the compiler flags directly. I'm just saying adding it to CFLAGS directly sounds like a very bad idea. Adding it to /etc/make.conf sounds even worse, because it

Re: [Patch] Proposal: USE_GNU89 switch

2009-05-30 Thread Ed Schouten
* Mel Flynn mel.flynn+fbsd.po...@mailing.thruhere.net wrote: Are there any edge cases of (antiquated) ports that (indirectly) use bsd.sys.mk and as such get hit by: 11 # the default is gnu99 for now 12 CSTD?= gnu99 In other words should one clean CFLAGS of -std before

Re: [Patch] Proposal: USE_GNU89 switch

2009-05-30 Thread Mark Linimon
On Sat, May 30, 2009 at 11:01:38AM -0400, Diane Bruce wrote: By the time FreeBSD-9 is released clang support will be solid and all ports will compile with clang as well as gcc. ooh, can I have unicorns, too? :-) Seriously, I'd like to see the potential to throw the switch, with the caveat that