Jason Helfman ha scritto:
I am working on the following pr, and would like to get others approval to
the following patch:
http://people.freebsd.org/~jgh/files/pre-patch.txt
This patch is fixing several use cases of SRC_BASE before it is defined.
I don't agree for the quantis-kmod patch. I
Unfortunately certain things need to be defined before bsd.port.pre.mk
is included. So, pointy hat to me for giving bad advice.
These show up immediately as bad distinfo problems:
On 05/21/12 15:04, Jason Helfman so wittily quipped:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I am working on the following pr, and would like to get others approval to
the following patch:
http://people.freebsd.org/~jgh/files/pre-patch.txt
On Tue, May 22, 2012 at 07:04:29PM -0700, Bob Frazier thus spake:
On 05/21/12 15:04, Jason Helfman so wittily quipped:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I am working on the following pr, and would like to get others approval to
the following patch:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I am working on the following pr, and would like to get others approval to
the following patch:
http://people.freebsd.org/~jgh/files/pre-patch.txt
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165994
This patch is fixing several use cases of
Thanks for doing this work. A quick review looks to me to be TRT.
I would suggest some minor fixes but only for style: for me, it makes
it a bit clearer what's going on if the pre.mk include isn't among
the various WITH_* definitions, e.g. net/skystar2. Or maybe just
having a blank line before
