Re: FLAVOR for Qt4 and Qt5 (was Re: Flavor or not for this port?)
Hi Mathieu,
May I ask you to review it and push this port?
If it's OK, I will made the same with Qwt5 after.
Regards.
Loïc
On 04.01.2018 18:37, L.Bartoletti wrote:
Hi Mathieu,
Thank you for your review and tips.
I have just submitted the patch.
Rainer, QGis 2 may be able to use Qwt6 instead of Qwt5?
Regards.
Loïc
On 21.12.2017 17:10, Mathieu Arnold wrote:
Le 19/12/2017 à 20:48, L.Bartoletti a écrit :
Hi,
Here's my WIP
https://gitlab.com/lbartoletti/freebsd_ports/tree/master/qwt6
As long as you are defining a default FLAVOR value, do it right:
FLAVOR?= ${FLAVORS:[1]}
There are a few stuffs that could be simplified, this works for both
flavors:|
|
|PLIST= ${PKGDIR}/pkg-plist.${FLAVOR} PLIST_SUB+=
QT_MKSPECDIR=lib/${FLAVOR}/mkspecs DOCSDIR=
${PREFIX}/share/doc/qwt6-${FLAVOR} And this: ||@${REINPLACE_CMD} -e
's/__QT_VERSION__/${FLAVOR:S/qt//}/g'
${WRKSRC}/qwtconfig.pri|
||
You are missing:
qt4_CONFLICTS_INSTALL= qwt6-qt5
qt5_CONFLICTS_INSTALL= qwt6-qt4
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: FLAVOR for Qt4 and Qt5 (was Re: Flavor or not for this port?)
Hi Loïc,
Am 04.01.2018 um 18:37 schrieb L.Bartoletti:
> Hi Mathieu,
>
> Thank you for your review and tips.
>
> I have just submitted the patch.
>
> Rainer, QGis 2 may be able to use Qwt6 instead of Qwt5?
I just tried to use Qwt6 with QGIS2 and it seems to work. A few small
tests showed no regressions, so far.
If this is true, I could change my port to use qwt6@qt4, once flavors
for QWT hit the ports tree.
Thanks to both, Loïc and Mathieu, for the work on this.
Best wishes,
Rainer
>
> Regards.
>
> Loïc
>
> On 21.12.2017 17:10, Mathieu Arnold wrote:
>> Le 19/12/2017 à 20:48, L.Bartoletti a écrit :
>>> Hi,
>>>
>>> Here's my WIP
>>>
>>> https://gitlab.com/lbartoletti/freebsd_ports/tree/master/qwt6
>> As long as you are defining a default FLAVOR value, do it right:
>>
>> FLAVOR?= ${FLAVORS:[1]}
>>
>> There are a few stuffs that could be simplified, this works for both
>> flavors:|
>>
>> |
>>
>> |PLIST= ${PKGDIR}/pkg-plist.${FLAVOR} PLIST_SUB+=
>> QT_MKSPECDIR=lib/${FLAVOR}/mkspecs DOCSDIR=
>> ${PREFIX}/share/doc/qwt6-${FLAVOR} And this: ||@${REINPLACE_CMD} -e
>> 's/__QT_VERSION__/${FLAVOR:S/qt//}/g'
>> ${WRKSRC}/qwtconfig.pri|
>> ||
>>
>>
>>
>> You are missing:
>>
>> qt4_CONFLICTS_INSTALL= qwt6-qt5
>> qt5_CONFLICTS_INSTALL= qwt6-qt4
>>
>>
>>
>
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: FLAVOR for Qt4 and Qt5 (was Re: Flavor or not for this port?)
Hi Loïc,
Am 04.01.2018 um 18:37 schrieb L.Bartoletti:
> Hi Mathieu,
>
> Thank you for your review and tips.
>
> I have just submitted the patch.
>
> Rainer, QGis 2 may be able to use Qwt6 instead of Qwt5?
I just tried to use Qwt6 with QGIS2 and it seems to work. A few small
tests showed no regressions, so far.
If this is true, I could change my port to use qwt6@qt4, once flavors
for QWT hit the ports tree.
Thanks to both, Loïc and Mathieu, for the work on this.
Best wishes,
Rainer
>
> Regards.
>
> Loïc
>
> On 21.12.2017 17:10, Mathieu Arnold wrote:
>> Le 19/12/2017 à 20:48, L.Bartoletti a écrit :
>>> Hi,
>>>
>>> Here's my WIP
>>>
>>> https://gitlab.com/lbartoletti/freebsd_ports/tree/master/qwt6
>> As long as you are defining a default FLAVOR value, do it right:
>>
>> FLAVOR?= ${FLAVORS:[1]}
>>
>> There are a few stuffs that could be simplified, this works for both
>> flavors:|
>>
>> |
>>
>> |PLIST= ${PKGDIR}/pkg-plist.${FLAVOR} PLIST_SUB+=
>> QT_MKSPECDIR=lib/${FLAVOR}/mkspecs DOCSDIR=
>> ${PREFIX}/share/doc/qwt6-${FLAVOR} And this: ||@${REINPLACE_CMD} -e
>> 's/__QT_VERSION__/${FLAVOR:S/qt//}/g'
>> ${WRKSRC}/qwtconfig.pri|
>> ||
>>
>>
>>
>> You are missing:
>>
>> qt4_CONFLICTS_INSTALL= qwt6-qt5
>> qt5_CONFLICTS_INSTALL= qwt6-qt4
>>
>>
>>
>
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: FLAVOR for Qt4 and Qt5 (was Re: Flavor or not for this port?)
Hi Mathieu,
Thank you for your review and tips.
I have just submitted the patch.
Rainer, QGis 2 may be able to use Qwt6 instead of Qwt5?
Regards.
Loïc
On 21.12.2017 17:10, Mathieu Arnold wrote:
Le 19/12/2017 à 20:48, L.Bartoletti a écrit :
Hi,
Here's my WIP
https://gitlab.com/lbartoletti/freebsd_ports/tree/master/qwt6
As long as you are defining a default FLAVOR value, do it right:
FLAVOR?= ${FLAVORS:[1]}
There are a few stuffs that could be simplified, this works for both
flavors:|
|
|PLIST= ${PKGDIR}/pkg-plist.${FLAVOR} PLIST_SUB+=
QT_MKSPECDIR=lib/${FLAVOR}/mkspecs DOCSDIR=
${PREFIX}/share/doc/qwt6-${FLAVOR} And this: ||@${REINPLACE_CMD} -e
's/__QT_VERSION__/${FLAVOR:S/qt//}/g'
${WRKSRC}/qwtconfig.pri|
||
You are missing:
qt4_CONFLICTS_INSTALL= qwt6-qt5
qt5_CONFLICTS_INSTALL= qwt6-qt4
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: FLAVOR for Qt4 and Qt5 (was Re: Flavor or not for this port?)
Le 19/12/2017 à 20:48, L.Bartoletti a écrit :
> Hi,
>
> Here's my WIP
>
> https://gitlab.com/lbartoletti/freebsd_ports/tree/master/qwt6
As long as you are defining a default FLAVOR value, do it right:
FLAVOR?= ${FLAVORS:[1]}
There are a few stuffs that could be simplified, this works for both
flavors:|
|
|PLIST= ${PKGDIR}/pkg-plist.${FLAVOR} PLIST_SUB+=
QT_MKSPECDIR=lib/${FLAVOR}/mkspecs DOCSDIR=
${PREFIX}/share/doc/qwt6-${FLAVOR} And this: ||@${REINPLACE_CMD} -e
's/__QT_VERSION__/${FLAVOR:S/qt//}/g'
${WRKSRC}/qwtconfig.pri|
||
You are missing:
qt4_CONFLICTS_INSTALL= qwt6-qt5
qt5_CONFLICTS_INSTALL= qwt6-qt4
--
Mathieu Arnold
signature.asc
Description: OpenPGP digital signature
Re: FLAVOR for Qt4 and Qt5 (was Re: Flavor or not for this port?)
Hi Loïc,
Am 19.12.2017 um 20:48 schrieb L.Bartoletti:
Hi,
Here's my WIP
https://gitlab.com/lbartoletti/freebsd_ports/tree/master/qwt6
Looks interesting to me.
Do we agree, that the package should be named qwt6-qt[45], and not
qwt-qt[45]?
And shouldn't PORTNAME better be named qwt6 instead of qwt. If so, the
port has to handle with DISTNAME in some way to fetch a file named qwt-.
At least, the actual naming brings some problems, for example if one
tries to fetch the distfile
make distclean
make FLAVOR=qt4 fetch
make distclean
make FLAVOR=qt5 fetch
QWT is licensed under Qwt 1.0, which is a LGPL with three execptions[1].
There is no definition for this license in Mk/bsd.license.db.mk until
now. I don't know, what is the right way to define this 'unknown'
license in the port.
Again, many thanks for your work on this port.
Best wishes,
Rainer
[1] http://qwt.sourceforge.net/qwtlicense.html
Regards
On 18.12.2017 22:57, L.Bartoletti wrote:
Hi Rainer,
I have made a try with subpackages with success, but I think it's
better with flavor (like on OpenBSD).
So, I have started to create flavors for this port.
For now, I success for qt4 but not yet for qt5.
Extract from my Makefile in progress:
FLAVORS= qt5 qt4
FLAVOR?=
.if ${FLAVOR:Mqt5}
PKGNAMESUFFIX= -qt5
USE_QT5= widgets gui core designer gui opengl svg xml buildtools
printsupport concurrent
PLIST= ${PKGDIR}/pkg-plist.qt5
PLIST_SUB+= QT_MKSPECDIR=lib/qt5/mkspecs
DOCSDIR= ${PREFIX}/share/doc/qwt6-qt5
.else
PKGNAMESUFFIX= -qt4
USE_QT4= corelib gui opengl svg xml moc_build
PLIST= ${PKGDIR}/pkg-plist.qt4
PLIST_SUB+= QT_MKSPECDIR=lib/qt4/mkspecs
DOCSDIR= ${PREFIX}/share/doc/qwt6-qt4
.endif
Ther error for qt5:
qwt-qt5-6.1.3 can't be installed: different Qt versions specified via
USE_QT[4 5].
Regards.
On 17.12.2017 10:12, Rainer Hurling wrote:
Am 02.11.2017 um 07:41 schrieb Rainer Hurling:
Am 02.11.2017 um 07:13 schrieb L.Bartoletti:
Hi,
I want to take x11-toolkits/qwt{5,6}-*
Both are built for Qt4. I especially need qwt6 for Qt5. Since we have
flavors. Is it better to add a Qt5 flavor for Qwt6 or simply add a
x11-toolkits/qwt6-qt5 (like security/qtkeychain-qt{4,5} ?)
Thanks.
Regards.
Loïc
Hi Loïc,
Thanks for your dedication. I am very interested in a qwt6-qt5 port,
since it is needed for the upcoming version 3.0 of graphics/qgis :)
Sorry for my inexperience. In case of adding the qwt6-qt5 as a flavor,
should we expect any change or restriction in the way, it would be used
as a dependency of e.g. QGIS?
Thanks for any answer.
Best wishes,
Rainer
Hi Loïc,
Again about x11-toolkits/qwt{5,6}-*
Now, that we have our first real world experiences with FLAVORS, it
seems to be functional to use flavors in this context. Something like
x11-toolkits/qwt6@qt4
x11-toolkits/qwt6@qt5
A bit tricky could be, that USE_QT* are different in both cases:
USE_QT4= corelib gui opengl svg xml moc_build
USE_QT5= core gui opengl svg xml printsupport qmake_build widgets
What do you think?
Best wishes,
Rainer
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: FLAVOR for Qt4 and Qt5 (was Re: Flavor or not for this port?)
Hi,
Here's my WIP
https://gitlab.com/lbartoletti/freebsd_ports/tree/master/qwt6
Regards
On 18.12.2017 22:57, L.Bartoletti wrote:
Hi Rainer,
I have made a try with subpackages with success, but I think it's
better with flavor (like on OpenBSD).
So, I have started to create flavors for this port.
For now, I success for qt4 but not yet for qt5.
Extract from my Makefile in progress:
FLAVORS= qt5 qt4
FLAVOR?=
.if ${FLAVOR:Mqt5}
PKGNAMESUFFIX= -qt5
USE_QT5= widgets gui core designer gui opengl svg xml buildtools
printsupport concurrent
PLIST= ${PKGDIR}/pkg-plist.qt5
PLIST_SUB+= QT_MKSPECDIR=lib/qt5/mkspecs
DOCSDIR= ${PREFIX}/share/doc/qwt6-qt5
.else
PKGNAMESUFFIX= -qt4
USE_QT4= corelib gui opengl svg xml moc_build
PLIST= ${PKGDIR}/pkg-plist.qt4
PLIST_SUB+= QT_MKSPECDIR=lib/qt4/mkspecs
DOCSDIR= ${PREFIX}/share/doc/qwt6-qt4
.endif
Ther error for qt5:
qwt-qt5-6.1.3 can't be installed: different Qt versions specified via
USE_QT[4 5].
Regards.
On 17.12.2017 10:12, Rainer Hurling wrote:
Am 02.11.2017 um 07:41 schrieb Rainer Hurling:
Am 02.11.2017 um 07:13 schrieb L.Bartoletti:
Hi,
I want to take x11-toolkits/qwt{5,6}-*
Both are built for Qt4. I especially need qwt6 for Qt5. Since we have
flavors. Is it better to add a Qt5 flavor for Qwt6 or simply add a
x11-toolkits/qwt6-qt5 (like security/qtkeychain-qt{4,5} ?)
Thanks.
Regards.
Loïc
Hi Loïc,
Thanks for your dedication. I am very interested in a qwt6-qt5 port,
since it is needed for the upcoming version 3.0 of graphics/qgis :)
Sorry for my inexperience. In case of adding the qwt6-qt5 as a flavor,
should we expect any change or restriction in the way, it would be used
as a dependency of e.g. QGIS?
Thanks for any answer.
Best wishes,
Rainer
Hi Loïc,
Again about x11-toolkits/qwt{5,6}-*
Now, that we have our first real world experiences with FLAVORS, it
seems to be functional to use flavors in this context. Something like
x11-toolkits/qwt6@qt4
x11-toolkits/qwt6@qt5
A bit tricky could be, that USE_QT* are different in both cases:
USE_QT4= corelib gui opengl svg xml moc_build
USE_QT5= core gui opengl svg xml printsupport qmake_build widgets
What do you think?
Best wishes,
Rainer
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
FLAVOR for Qt4 and Qt5 (was Re: Flavor or not for this port?)
Hi Rainer,
I have made a try with subpackages with success, but I think it's better
with flavor (like on OpenBSD).
So, I have started to create flavors for this port.
For now, I success for qt4 but not yet for qt5.
Extract from my Makefile in progress:
FLAVORS= qt5 qt4
FLAVOR?=
.if ${FLAVOR:Mqt5}
PKGNAMESUFFIX= -qt5
USE_QT5= widgets gui core designer gui opengl svg xml buildtools
printsupport concurrent
PLIST= ${PKGDIR}/pkg-plist.qt5
PLIST_SUB+= QT_MKSPECDIR=lib/qt5/mkspecs
DOCSDIR= ${PREFIX}/share/doc/qwt6-qt5
.else
PKGNAMESUFFIX= -qt4
USE_QT4= corelib gui opengl svg xml moc_build
PLIST= ${PKGDIR}/pkg-plist.qt4
PLIST_SUB+= QT_MKSPECDIR=lib/qt4/mkspecs
DOCSDIR= ${PREFIX}/share/doc/qwt6-qt4
.endif
Ther error for qt5:
qwt-qt5-6.1.3 can't be installed: different Qt versions specified via
USE_QT[4 5].
Regards.
On 17.12.2017 10:12, Rainer Hurling wrote:
Am 02.11.2017 um 07:41 schrieb Rainer Hurling:
Am 02.11.2017 um 07:13 schrieb L.Bartoletti:
Hi,
I want to take x11-toolkits/qwt{5,6}-*
Both are built for Qt4. I especially need qwt6 for Qt5. Since we have
flavors. Is it better to add a Qt5 flavor for Qwt6 or simply add a
x11-toolkits/qwt6-qt5 (like security/qtkeychain-qt{4,5} ?)
Thanks.
Regards.
Loïc
Hi Loïc,
Thanks for your dedication. I am very interested in a qwt6-qt5 port,
since it is needed for the upcoming version 3.0 of graphics/qgis :)
Sorry for my inexperience. In case of adding the qwt6-qt5 as a flavor,
should we expect any change or restriction in the way, it would be used
as a dependency of e.g. QGIS?
Thanks for any answer.
Best wishes,
Rainer
Hi Loïc,
Again about x11-toolkits/qwt{5,6}-*
Now, that we have our first real world experiences with FLAVORS, it
seems to be functional to use flavors in this context. Something like
x11-toolkits/qwt6@qt4
x11-toolkits/qwt6@qt5
A bit tricky could be, that USE_QT* are different in both cases:
USE_QT4= corelib gui opengl svg xml moc_build
USE_QT5= core gui opengl svg xml printsupport qmake_build widgets
What do you think?
Best wishes,
Rainer
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
