Re: Newbie maintainer, question regarding patches

2012-02-24 Thread Doug Barton
On 02/24/2012 06:18, Michael Gmelin wrote: > In general I agree with your reasoning. The feature I'm talking about has > been approved and will be in the next version (this happened almost half a > year ago). Unfortunately Ice has a slow release cycle, as it is dual licensed > (GPLv2+commercial)

Re: Newbie maintainer, question regarding patches

2012-02-24 Thread Michael Gmelin
On Feb 24, 2012, at 14:55, Eitan Adler wrote: > On Fri, Feb 24, 2012 at 7:39 AM, Michael Gmelin wrote: >> b) I also have another massive patch which touches another 20 files which >> enables some new security features in ice (the history of this patch is that >> I developed it at first and subm

Re: Newbie maintainer, question regarding patches

2012-02-24 Thread Eitan Adler
On Fri, Feb 24, 2012 at 7:39 AM, Michael Gmelin wrote: > b) I also have another massive patch which touches another 20 files which > enables some new security features in ice (the history of this patch is that > I developed it at first and submitted it to the vendor, who refined it and > sent i

Re: Newbie maintainer, question regarding patches

2012-02-24 Thread Michael Scheidell
First, welcome! Thank you for stepping up to the plate and taking on ownership of a port. It is greatly appreciated. As for pr's, yes, keep sending them. Your patches still need to be committed to the ports tree by a committer. When you send in a maintenance patch, subject should/could be some

Newbie maintainer, question regarding patches

2012-02-24 Thread Michael Gmelin
Hi, I recently took over maintainership of the devel/ice port and trying to get familiar with the dos and don'ts of porting. In the past I contributed only by sending PRs, which would have been approved by the maintainer. Since I'm the maintainer now, will I still open normal PRs, which will th