Re: Owncloud port marked broken with PHP 7.0 and MySQL

[Kevin Lo]

On Tue, Mar 15, 2016 at 08:12:20AM -0400, Jim Ohlstein wrote:
> 
> Hello,

Hi Jim,

> On 3/15/16 7:54 AM, Kurt Jaeger wrote:
> > Hi!
> >
> >> At the risk of sounding like a broken record (did you actually READ what
> >> I wrote?) Owncloud does NOT require php-mysql, it requires
> >> php-pdo_mysql. In PHP versions before 7.0 that pulled in the
> >> corresponding php-mysql port. It is NOT a requirement (there, I said it
> >> a THIRD time).
> >
> > Can you submit a patch to the ports (maybe fixing the depends) so that
> > it builds ?
> >
> 
> It's pretty straightforward. I'm guessing other ports were pulled in by 
> this blanket search for requiring mysql extension when in fact what was 
> needed was pdo-mysql.

You're right.  Owncloud doesn't require php-mysql, I committed your fix
as r411212, thanks.

> 
> --- Makefile  (revision 411153)
> +++ Makefile  (working copy)
> @@ -2,6 +2,7 @@
> 
>   PORTNAME=   owncloud
>   PORTVERSION=9.0.0
> +PORTREVISION=1
>   CATEGORIES= www
>   MASTER_SITES=   http://download.owncloud.org/community/
> 
> @@ -40,8 +41,7 @@
>   LDAP_USE=   PHP=ldap
>   MP3INFO_BUILD_DEPENDS=  mp3info:${PORTSDIR}/audio/mp3info
>   MP3INFO_RUN_DEPENDS=${MP3INFO_BUILD_DEPENDS}
> -MYSQL_USE=   MYSQL=client PHP=mysql,pdo_mysql
> -MYSQL_VARS=  IGNORE_WITH_PHP+=70
> +MYSQL_USE=   MYSQL=client PHP=pdo_mysql
>   PGSQL_USES= pgsql
>   PGSQL_USE=  PHP=pdo_pgsql,pgsql
>   SQLITE_USE= PHP=pdo_sqlite,sqlite3
> 
> 
> Build log available at http://bit.ly/1UdfsGA.
> 
> -- 
> Jim Ohlstein
> 
> 
> "Never argue with a fool, onlookers may not be able to tell the 
> difference." - Mark Twain
> 
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: Owncloud port marked broken with PHP 7.0 and MySQL

[Kurt Jaeger]

Hi!

> > Can you submit a patch to the ports (maybe fixing the depends) so that
> > it builds ?

> It's pretty straightforward. I'm guessing other ports were pulled in by 
> this blanket search for requiring mysql extension when in fact what was 
> needed was pdo-mysql.

Now a major motion picture at:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208041

Thanks!

-- 
p...@opsec.eu+49 171 3101372 4 years to go !
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: Owncloud port marked broken with PHP 7.0 and MySQL

[Jim Ohlstein]

Hello,

On 3/15/16 7:54 AM, Kurt Jaeger wrote:

Hi!


At the risk of sounding like a broken record (did you actually READ what
I wrote?) Owncloud does NOT require php-mysql, it requires
php-pdo_mysql. In PHP versions before 7.0 that pulled in the
corresponding php-mysql port. It is NOT a requirement (there, I said it
a THIRD time).


Can you submit a patch to the ports (maybe fixing the depends) so that
it builds ?



It's pretty straightforward. I'm guessing other ports were pulled in by 
this blanket search for requiring mysql extension when in fact what was 
needed was pdo-mysql.


--- Makefile(revision 411153)
+++ Makefile(working copy)
@@ -2,6 +2,7 @@

 PORTNAME=  owncloud
 PORTVERSION=   9.0.0
+PORTREVISION=  1
 CATEGORIES=www
 MASTER_SITES=  http://download.owncloud.org/community/

@@ -40,8 +41,7 @@
 LDAP_USE=  PHP=ldap
 MP3INFO_BUILD_DEPENDS= mp3info:${PORTSDIR}/audio/mp3info
 MP3INFO_RUN_DEPENDS=   ${MP3INFO_BUILD_DEPENDS}
-MYSQL_USE= MYSQL=client PHP=mysql,pdo_mysql
-MYSQL_VARS=IGNORE_WITH_PHP+=70
+MYSQL_USE= MYSQL=client PHP=pdo_mysql
 PGSQL_USES=pgsql
 PGSQL_USE= PHP=pdo_pgsql,pgsql
 SQLITE_USE=PHP=pdo_sqlite,sqlite3


Build log available at http://bit.ly/1UdfsGA.

--
Jim Ohlstein


"Never argue with a fool, onlookers may not be able to tell the 
difference." - Mark Twain

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: Owncloud port marked broken with PHP 7.0 and MySQL

[Mathieu Arnold]

+--On 15 mars 2016 07:49:55 -0400 Jim Ohlstein  wrote:
| Hello,
| 
| On 3/15/16 7:05 AM, Mathieu Arnold wrote:
|> 
|> 
|> +--On 14 mars 2016 16:57:19 -0400 Jim Ohlstein  wrote:
|> | Hello,
|> | 
|> | Not sure of the motivation behind this. Owncloud has supported PHP 7.0
|> | since prior to this release (9.0.0). See
|> | https://owncloud.org/blog/php-7-is-here-and-owncloud-is-ready/. Perhaps
|> | removing the unnecessary php(Xx)-mysql runtime requirement is what's
|> | actually needed, as it actually requires php(Xx)-pdo-mysql. That in
|> | itself creates a php-mysql dependency in PHP versions up to 5.6, but
|> | not in later versions, such as 7.0.
|> 
|> The owncloud port needs mysql, php 7.0 does not provide mysql, so it was
|> marked broken, along with all the ports that do so, and who also don't
|> build with 7.0.
|> 
| 
| At the risk of sounding like a broken record (did you actually READ what
| I wrote?) Owncloud does NOT require php-mysql, it requires php-pdo_mysql.
| In PHP versions before 7.0 that pulled in the corresponding php-mysql
| port. It is NOT a requirement (there, I said it a THIRD time).

I was very specific in my answer, yes, I read what you wrote, I never
talked about owncloud, I talked about the port.

The port's MYSQL option end up doing USE_PHP=mysql.
PHP 7.0 does not have a mysql module.
Before my commit, if you tried to build the port with the MYSQL option
enabled, and with PHP 7.0 as the default, you would end up not building
anyway:

Unknown extension mysql for PHP 70.
*** Error code 1

Stop.
make: stopped in /usr/ports/www/owncloud

After my commit, if you try to build it with the MYSQL option enabled, it
will tell you:

cannot be installed: doesn't work with lang/php70 port (doesn't support PHP
70)

So, nothing changed from what you can do, you could not install it before,
you still cannot install it now.

Let me be very clear with what I wrote and what it says, it's all about the
*port* not the *software* I have no idea if the ~50 ports I marked broken
the other day can, or not, work with PHP 7.0.  I marked them all broken, in
one go, because they were taking time trying to build where they could not.

Now, if there is something to be done with one particular port, owncloud in
this case, please, open a problem report so that the maintainer can fix it.

Kind regards,

-- 
Mathieu Arnold

pgpOLo8Ophcor.pgp
Description: PGP signature

Re: Owncloud port marked broken with PHP 7.0 and MySQL

[Kurt Jaeger]

Hi!

> At the risk of sounding like a broken record (did you actually READ what 
> I wrote?) Owncloud does NOT require php-mysql, it requires 
> php-pdo_mysql. In PHP versions before 7.0 that pulled in the 
> corresponding php-mysql port. It is NOT a requirement (there, I said it 
> a THIRD time).

Can you submit a patch to the ports (maybe fixing the depends) so that
it builds ?

-- 
p...@opsec.eu+49 171 3101372 4 years to go !
___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: Owncloud port marked broken with PHP 7.0 and MySQL

[Jim Ohlstein]

Hello,

On 3/15/16 7:05 AM, Mathieu Arnold wrote:



+--On 14 mars 2016 16:57:19 -0400 Jim Ohlstein  wrote:
| Hello,
|
| Not sure of the motivation behind this. Owncloud has supported PHP 7.0
| since prior to this release (9.0.0). See
| https://owncloud.org/blog/php-7-is-here-and-owncloud-is-ready/. Perhaps
| removing the unnecessary php(Xx)-mysql runtime requirement is what's
| actually needed, as it actually requires php(Xx)-pdo-mysql. That in
| itself creates a php-mysql dependency in PHP versions up to 5.6, but not
| in later versions, such as 7.0.

The owncloud port needs mysql, php 7.0 does not provide mysql, so it was
marked broken, along with all the ports that do so, and who also don't
build with 7.0.



At the risk of sounding like a broken record (did you actually READ what 
I wrote?) Owncloud does NOT require php-mysql, it requires 
php-pdo_mysql. In PHP versions before 7.0 that pulled in the 
corresponding php-mysql port. It is NOT a requirement (there, I said it 
a THIRD time).


From their docs at 
https://doc.owncloud.org/server/9.0/admin_manual/installation/source_installation.html


Database connectors (pick the one for your database:)

PHP module sqlite (>= 3, usually not recommended for performance reasons)
PHP module pdo_mysql (MySQL/MariaDB)
PHP module pgsql (requires PostgreSQL >= 9.0)

Now I may just be dumb, but I don't see a mention of php-mysql (I do 
however see pdo_mysql).


--
Jim Ohlstein


"Never argue with a fool, onlookers may not be able to tell the 
difference." - Mark Twain

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"

Re: Owncloud port marked broken with PHP 7.0 and MySQL

[Mathieu Arnold]

+--On 14 mars 2016 16:57:19 -0400 Jim Ohlstein  wrote:
| Hello,
| 
| Not sure of the motivation behind this. Owncloud has supported PHP 7.0
| since prior to this release (9.0.0). See
| https://owncloud.org/blog/php-7-is-here-and-owncloud-is-ready/. Perhaps
| removing the unnecessary php(Xx)-mysql runtime requirement is what's
| actually needed, as it actually requires php(Xx)-pdo-mysql. That in
| itself creates a php-mysql dependency in PHP versions up to 5.6, but not
| in later versions, such as 7.0.

The owncloud port needs mysql, php 7.0 does not provide mysql, so it was
marked broken, along with all the ports that do so, and who also don't
build with 7.0.

-- 
Mathieu Arnold

pgp0m8rFpw8CR.pgp
Description: PGP signature

Owncloud port marked broken with PHP 7.0 and MySQL

[Jim Ohlstein]

Hello,

Not sure of the motivation behind this. Owncloud has supported PHP 7.0 
since prior to this release (9.0.0). See 
https://owncloud.org/blog/php-7-is-here-and-owncloud-is-ready/. Perhaps 
removing the unnecessary php(Xx)-mysql runtime requirement is what's 
actually needed, as it actually requires php(Xx)-pdo-mysql. That in 
itself creates a php-mysql dependency in PHP versions up to 5.6, but not 
in later versions, such as 7.0.


--
Jim Ohlstein


"Never argue with a fool, onlookers may not be able to tell the 
difference." - Mark Twain

___
freebsd-ports@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"