Trivial PR, fix package-noinstall

2010-04-10 Thread Dominic Fandrey
This morning I took a look at my outstanding PRs. There are is a ports PR I consider old and trivial: This one fixes a bug in the package-noinstall target. wxs told me that he prefers my proposed fix over his own: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/144164 Regards -- A: Because it

Re: Trivial PR, fix package-noinstall

2010-04-10 Thread Garrett Cooper
On Sat, Apr 10, 2010 at 2:29 AM, Dominic Fandrey kamik...@bsdforen.de wrote: This morning I took a look at my outstanding PRs. There are is a ports PR I consider old and trivial: This one fixes a bug in the package-noinstall target. wxs told me that he prefers my proposed fix over his own:

Re: Trivial PR, fix package-noinstall

2010-04-10 Thread Gary Jennejohn
On Sat, 10 Apr 2010 03:18:42 -0700 Garrett Cooper yanef...@gmail.com wrote: FWIW, I've thought this over and and user modifiable scripts should not be in packages; they should instead be example files which don't conflict with real configuration files. This is already the case for several

Re: Trivial PR, fix package-noinstall

2010-04-10 Thread Dominic Fandrey
On 10/04/2010 12:49, Garrett Cooper wrote: On Sat, Apr 10, 2010 at 3:44 AM, Dominic Fandrey kamik...@bsdforen.de wrote: On 10/04/2010 12:18, Garrett Cooper wrote: On Sat, Apr 10, 2010 at 2:29 AM, Dominic Fandrey kamik...@bsdforen.de wrote: This morning I took a look at my outstanding PRs.

Re: Trivial PR, fix package-noinstall

2010-04-10 Thread Dominic Fandrey
On 10/04/2010 13:11, Gary Jennejohn wrote: On Sat, 10 Apr 2010 03:18:42 -0700 Garrett Cooper yanef...@gmail.com wrote: FWIW, I've thought this over and and user modifiable scripts should not be in packages; they should instead be example files which don't conflict with real configuration

Re: Trivial PR, fix package-noinstall

2010-04-10 Thread Garrett Cooper
On Sat, Apr 10, 2010 at 4:26 AM, Dominic Fandrey kamik...@bsdforen.de wrote: On 10/04/2010 12:49, Garrett Cooper wrote: On Sat, Apr 10, 2010 at 3:44 AM, Dominic Fandrey kamik...@bsdforen.de wrote: On 10/04/2010 12:18, Garrett Cooper wrote: On Sat, Apr 10, 2010 at 2:29 AM, Dominic Fandrey

Re: Trivial PR, fix package-noinstall

2010-04-10 Thread Dominic Fandrey
On 10/04/2010 23:30, Garrett Cooper wrote: On Sat, Apr 10, 2010 at 4:26 AM, Dominic Fandrey kamik...@bsdforen.de wrote: On 10/04/2010 12:49, Garrett Cooper wrote: On Sat, Apr 10, 2010 at 3:44 AM, Dominic Fandrey kamik...@bsdforen.de wrote: On 10/04/2010 12:18, Garrett Cooper wrote: On Sat,