Re: patch upgrade for port committers?

2010-01-29 Thread Ion-Mihai Tetcu
On Fri, 29 Jan 2010 07:38:40 -0600 Stephen Montgomery-Smith wrote: > Ion-Mihai Tetcu wrote: > > On Thu, 28 Jan 2010 17:01:44 -0600 (CST) > > Stephen Montgomery-Smith wrote: > > >> Also, I have taken to using shar files instead of diff's when > >> creating new files. > > > > Don't please, it mak

Re: patch upgrade for port committers?

2010-01-29 Thread Stephen Montgomery-Smith
Ion-Mihai Tetcu wrote: On Thu, 28 Jan 2010 17:01:44 -0600 (CST) Stephen Montgomery-Smith wrote: Also, I have taken to using shar files instead of diff's when creating new files. Don't please, it makes committer's work harder. And update to a port should be a diff. Preferably a cvs diff -u.

Re: patch upgrade for port committers?

2010-01-29 Thread Ion-Mihai Tetcu
On Thu, 28 Jan 2010 17:01:44 -0600 (CST) Stephen Montgomery-Smith wrote: > > > On Thu, 28 Jan 2010, Charlie Kester wrote: > > > On Thu 28 Jan 2010 at 13:37:06 PST Doug Barton wrote: > >> > >> Any time you send someone a patch for any reason that deletes an > >> existing file it is worthwhile t

Re: patch upgrade for port committers?

2010-01-28 Thread Charlie Kester
On Thu 28 Jan 2010 at 18:25:30 PST Alberto Villa wrote: On 1/28/10, Charlie Kester wrote: On Thu 28 Jan 2010 at 13:37:06 PST Doug Barton wrote: When you submit a port/update that ADDS a file it is definitely worthwhile to mention this as well. Good advice that should be added to the porter's

Re: patch upgrade for port committers?

2010-01-28 Thread Sevan / Venture37
I was pointed to ports-mgmt/porttools by pgollucci@, that takes care of listing additions & removals in the PR when you use the port submit command. Sevan / Venture37 ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo

Re: patch upgrade for port committers?

2010-01-28 Thread Alberto Villa
On 1/28/10, Charlie Kester wrote: > On Thu 28 Jan 2010 at 13:37:06 PST Doug Barton wrote: >>When you submit a port/update that ADDS a file it is definitely >>worthwhile to mention this as well. > > Good advice that should be added to the porter's handbook. http://www.freebsd.org/doc/en/books/port

Re: patch upgrade for port committers?

2010-01-28 Thread Stephen Montgomery-Smith
On Thu, 28 Jan 2010, Charlie Kester wrote: On Thu 28 Jan 2010 at 13:37:06 PST Doug Barton wrote: Any time you send someone a patch for any reason that deletes an existing file it is worthwhile to call the person's attention to this fact. When you submit a port/update that ADDS a file it is

Re: patch upgrade for port committers?

2010-01-28 Thread Charlie Kester
On Thu 28 Jan 2010 at 13:37:06 PST Doug Barton wrote: Any time you send someone a patch for any reason that deletes an existing file it is worthwhile to call the person's attention to this fact. When you submit a port/update that ADDS a file it is definitely worthwhile to mention this as wel

Re: patch upgrade for port committers?

2010-01-28 Thread Ion-Mihai Tetcu
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, 28 Jan 2010 13:16:43 -0800 Xin LI wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 2010/01/28 11:46, Stephen Montgomery-Smith wrote: > > When an update to a port is committed, it is likely to contain > > > > (a) lines like "

Re: patch upgrade for port committers?

2010-01-28 Thread Doug Barton
On 01/28/10 11:46, Stephen Montgomery-Smith wrote: Cannot "patch" honor these cases? As a port maintainer, I have been caught quite a few times by committers not adding or removing files from the "files" directory in a port. Any time you send someone a patch for any reason that deletes an exis

Re: patch upgrade for port committers?

2010-01-28 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2010/01/28 11:46, Stephen Montgomery-Smith wrote: > When an update to a port is committed, it is likely to contain > > (a) lines like "Only in : " > > or (b) patches that are created against empty files using the "-N" > option for diff. >

Re: patch upgrade for port committers?

2010-01-28 Thread Ion-Mihai Tetcu
On Thu, 28 Jan 2010 13:46:16 -0600 Stephen Montgomery-Smith wrote: > When an update to a port is committed, it is likely to contain > > (a) lines like "Only in : " > > or (b) patches that are created against empty files using the "-N" > option for diff. > > Cannot "patch" honor these

patch upgrade for port committers?

2010-01-28 Thread Stephen Montgomery-Smith
When an update to a port is committed, it is likely to contain (a) lines like "Only in : " or (b) patches that are created against empty files using the "-N" option for diff. Cannot "patch" honor these cases? As a port maintainer, I have been caught quite a few times by committers