Re: tk85 Port Maintenance

2012-12-09 Thread Joseph a Nagy Jr
On 11/15/2012 02:45, Pietro Cerutti wrote: On 2012-Nov-14, 14:52, Joseph a Nagy Jr wrote: snip I'm sorry, I'm not seeing what I'm missing. As I said, PORTREVISION, distinfo, and the patch files. Look them up in the handbook. PORTREVISION: not seeing a problem As for the patch files, if I

Re: tk85 Port Maintenance

2012-11-15 Thread Pietro Cerutti
On 2012-Nov-14, 14:52, Joseph a Nagy Jr wrote: Off-list On 11/13/12 01:59, Pietro Cerutti wrote: On 2012-Nov-08, 09:12, Joseph a Nagy Jr wrote: On 11/08/12 03:13, Pietro Cerutti wrote: snip By the way, Tcl/Tk 8.5.13 is bound to be released in the next few days (the first RC is out

Re: tk85 Port Maintenance

2012-11-12 Thread Pietro Cerutti
On 2012-Nov-08, 09:12, Joseph a Nagy Jr wrote: On 11/08/12 03:13, Pietro Cerutti wrote: snip By the way, Tcl/Tk 8.5.13 is bound to be released in the next few days (the first RC is out now, actually). You might want to include the update in your diff :) http://pastebin.com/UmasjFfz

Re: tk85 Port Maintenance

2012-11-08 Thread Pietro Cerutti
On 2012-Nov-07, 17:12, Joseph a Nagy Jr wrote: On 11/06/12 02:20, Pietro Cerutti wrote: snip * I won't comment on the LICENSE stuff, I don't know enough about it * XFT_DESC This is already defined in bsd.options.desc.mk. I'd say that Xft font library is ok as a description.

Re: tk85 Port Maintenance

2012-11-08 Thread Joseph a Nagy Jr
On 11/08/12 03:13, Pietro Cerutti wrote: On 2012-Nov-07, 17:12, Joseph a Nagy Jr wrote: On 11/06/12 02:20, Pietro Cerutti wrote: snip * I won't comment on the LICENSE stuff, I don't know enough about it * XFT_DESC This is already defined in bsd.options.desc.mk. I'd say that Xft font

Re: tk85 Port Maintenance

2012-11-08 Thread Joseph a Nagy Jr
On 11/08/12 03:13, Pietro Cerutti wrote: snip By the way, Tcl/Tk 8.5.13 is bound to be released in the next few days (the first RC is out now, actually). You might want to include the update in your diff :) http://pastebin.com/UmasjFfz -- Yours in Christ, Joseph A Nagy Jr Whoever loves

Re: tk85 Port Maintenance

2012-11-08 Thread Eitan Adler
On 8 November 2012 09:56, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote: The tr - ${TR} conversion is also wrong, you're changing what the sed liner is looking for. If you do so, it won't find it anymore. That was one of many suggestions from portlint. try make -VTR to see what the difference

Re: tk85 Port Maintenance

2012-11-08 Thread Joseph a Nagy Jr
On 11/08/12 09:33, Eitan Adler wrote: On 8 November 2012 09:56, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote: The tr - ${TR} conversion is also wrong, you're changing what the sed liner is looking for. If you do so, it won't find it anymore. That was one of many suggestions from portlint.

Re: tk85 Port Maintenance

2012-11-08 Thread Joseph a Nagy Jr
On 11/08/12 20:59, Eitan Adler wrote: On 8 November 2012 21:42, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote: On 11/08/12 09:33, Eitan Adler wrote: On 8 November 2012 09:56, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote: The tr - ${TR} conversion is also wrong, you're changing what the sed

Re: tk85 Port Maintenance

2012-11-07 Thread Joseph a Nagy Jr
On 11/06/12 02:20, Pietro Cerutti wrote: snip * I won't comment on the LICENSE stuff, I don't know enough about it * XFT_DESC This is already defined in bsd.options.desc.mk. I'd say that Xft font library is ok as a description. * LIB_DEPENDS+= Xft:${PORTSDIR}/x11-fonts/libXft

Re: tk85 Port Maintenance

2012-11-06 Thread Joseph a Nagy Jr
On 11/02/12 06:21, Pietro Cerutti wrote: On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote: On 10/31/12 11:55, Pietro Cerutti wrote: On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote: snip New diff[0], undoing some of the earlier changes even though portlint complains: portlint

Re: tk85 Port Maintenance

2012-11-06 Thread Pietro Cerutti
On 2012-Nov-04, 08:48, Joseph a Nagy Jr wrote: On 11/02/12 06:21, Pietro Cerutti wrote: On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote: On 10/31/12 11:55, Pietro Cerutti wrote: On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote: snip New diff[0], undoing some of the earlier changes even

Re: tk85 Port Maintenance

2012-11-06 Thread Joseph a Nagy Jr
On 11/06/12 02:20, Pietro Cerutti wrote: snip * I won't comment on the LICENSE stuff, I don't know enough about it I've checked and there are no official endorsements of Tcl/Tk license except from CopyFree folks. FSF and OSI don't even mention Tcl/Tk license. * XFT_DESC This is already

Re: tk85 Port Maintenance

2012-11-05 Thread Joseph a Nagy Jr
snip http://pastebin.com/GSG0Y19W -- Yours in Christ, Joseph A Nagy Jr Whoever loves instruction loves knowledge, But he who hates correction is stupid. -- Proverbs 12:1 Emails are not formal business letters, whatever businesses may want. Original content CopyFree (F) under the OWL

Re: tk85 Port Maintenance

2012-11-04 Thread Joseph a Nagy Jr
On 11/02/12 06:21, Pietro Cerutti wrote: On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote: On 10/31/12 11:55, Pietro Cerutti wrote: On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote: snip New diff[0], undoing some of the earlier changes even though portlint complains: portlint

Re: tk85 Port Maintenance

2012-11-02 Thread Pietro Cerutti
On 2012-Oct-31, 12:41, Joseph a Nagy Jr wrote: On 10/31/12 11:55, Pietro Cerutti wrote: On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote: snip New diff[0], undoing some of the earlier changes even though portlint complains: portlint ~/port-maintenance/tk85/ WARN: Makefile: unless this

Re: tk85 Port Maintenance

2012-11-02 Thread Joseph a Nagy Jr
On 11/02/12 06:21, Pietro Cerutti wrote: snip This won't apply, either. Could you provide a diff as dumped by svn diff in tk85's directory? from within /usr/ports/x11-toolkits/tk85 on the original root@alex-laptop# svn diff Makefile Index: Makefile

tk85 Port Maintenance

2012-10-31 Thread Joseph a Nagy Jr
Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any and all feedback would be appreciated. [0]: http://pastebin.com/6DuzdAzv --

Re: tk85 Port Maintenance

2012-10-31 Thread Chris Rees
On 31 October 2012 13:03, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any

Re: tk85 Port Maintenance

2012-10-31 Thread Joseph a Nagy Jr
On 10/31/12 08:24, Chris Rees wrote: On 31 October 2012 13:03, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes

Re: tk85 Port Maintenance

2012-10-31 Thread Pietro Cerutti
On 2012-Oct-31, 08:36, Joseph a Nagy Jr wrote: On 10/31/12 08:24, Chris Rees wrote: On 31 October 2012 13:03, Joseph a Nagy Jr jnagyjr1...@gmail.com wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench

Re: tk85 Port Maintenance

2012-10-31 Thread Pietro Cerutti
On 2012-Oct-31, 08:03, Joseph a Nagy Jr wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback from portlint. Any and all feedback would

Re: tk85 Port Maintenance

2012-10-31 Thread Joseph a Nagy Jr
On 10/31/12 08:57, Pietro Cerutti wrote: On 2012-Oct-31, 08:03, Joseph a Nagy Jr wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback

Re: tk85 Port Maintenance

2012-10-31 Thread Joseph a Nagy Jr
On 10/31/12 08:49, Pietro Cerutti wrote: snip Please be informed that I have in the pipeline some work on Tcl/Tk ports, including removal of the -thread slaves. Okay Having said that, I don't have any major concerns about you taking maintainership of tk85, apart from the technical details

Re: tk85 Port Maintenance

2012-10-31 Thread Joseph a Nagy Jr
On 10/31/12 08:57, Pietro Cerutti wrote: On 2012-Oct-31, 08:03, Joseph a Nagy Jr wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a working update to it. All changes were due to feedback

Re: tk85 Port Maintenance

2012-10-31 Thread Pietro Cerutti
On 2012-Oct-31, 09:14, Joseph a Nagy Jr wrote: On 10/31/12 08:57, Pietro Cerutti wrote: On 2012-Oct-31, 08:03, Joseph a Nagy Jr wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making updates to the Makefile[0] in a workbench directory and have a

Re: tk85 Port Maintenance

2012-10-31 Thread Chris Rees
On 31 Oct 2012 15:21, Pietro Cerutti g...@freebsd.org wrote: On 2012-Oct-31, 09:14, Joseph a Nagy Jr wrote: On 10/31/12 08:57, Pietro Cerutti wrote: On 2012-Oct-31, 08:03, Joseph a Nagy Jr wrote: Hi All, I'd like to volunteer to maintain the tk85 port. I've already begun making

Re: tk85 Port Maintenance

2012-10-31 Thread Pietro Cerutti
On 2012-Oct-31, 15:25, Chris Rees wrote: On 31 Oct 2012 15:21, Pietro Cerutti g...@freebsd.org wrote: On 2012-Oct-31, 09:14, Joseph a Nagy Jr wrote: On 10/31/12 08:57, Pietro Cerutti wrote: On 2012-Oct-31, 08:03, Joseph a Nagy Jr wrote: Hi All, I'd like to volunteer to

Re: tk85 Port Maintenance

2012-10-31 Thread Joseph a Nagy Jr
On 10/31/12 10:39, Pietro Cerutti wrote: snip patch tk85.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -- |--- Makefile.orig 2012-10-26 19:47:37.0 -0500 |+++ Makefile 2012-10-29 20:16:13.0 -0500

Re: tk85 Port Maintenance

2012-10-31 Thread Joseph a Nagy Jr
On 10/31/12 10:39, Pietro Cerutti wrote: snip patch tk85.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -- |--- Makefile.orig 2012-10-26 19:47:37.0 -0500 |+++ Makefile 2012-10-29 20:16:13.0 -0500

Re: tk85 Port Maintenance

2012-10-31 Thread Pietro Cerutti
On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote: On 10/31/12 10:39, Pietro Cerutti wrote: snip patch tk85.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -- |--- Makefile.orig 2012-10-26 19:47:37.0 -0500 |+++

Re: tk85 Port Maintenance

2012-10-31 Thread Joseph a Nagy Jr
On 10/31/12 11:55, Pietro Cerutti wrote: On 2012-Oct-31, 11:28, Joseph a Nagy Jr wrote: snip New diff[0], undoing some of the earlier changes even though portlint complains: portlint ~/port-maintenance/tk85/ WARN: Makefile: unless this is a master port, COMMENT has to be set by =, not by