Re: databases/postgresql84-server 8.4.9 rc.d script broken

2011-10-19 Thread John Marshall 
On Tue, 18 Oct 2011, 21:16 -0400, Greg Larkin wrote:
 On 10/18/11 8:45 PM, John Marshall wrote:
  After upgrading databases/postgresql84-server from 8.4.8_1 to 8.4.9, the
  rc.d script vomits thus:
  
rwsrv03# /usr/local/etc/rc.d/postgresql start
su: unknown login: %%PG_USER%%
  
  Presumably the updated port is missing a substitution edit but I haven't
  found where.

 Apply this patch to the Makefile and reinstall postgres:

Done.

 The Makefile depended on the presence of a file that was removed in the
 last commit.  Because of that, the substitutions were no longer added to
 SUB_LIST.
 
 I'll open a PR tomorrow, if someone doesn't get to it before me.

(/me picks up the clue and locates Section 8.6 of the Porters Handbook)
Ah, so that's what SUB_LIST does! (I've been meaning to find out).  All
makes sense now.  Thank you!

Thanks to all who responded.

-- 
John Marshall


pgp6gfQ6TlIkk.pgp
Description: PGP signature

Re: databases/postgresql84-server 8.4.9 rc.d script broken

2011-10-19 Thread Matthias Andree 
Am 19.10.2011 02:45, schrieb John Marshall:
 After upgrading databases/postgresql84-server from 8.4.8_1 to 8.4.9, the
 rc.d script vomits thus:
 
   rwsrv03# /usr/local/etc/rc.d/postgresql start
   su: unknown login: %%PG_USER%%
 
 Presumably the updated port is missing a substitution edit but I haven't
 found where.

I had previously filed

http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/161785


Note that the PostgreSQL client update can break other software
depending on the state of the options.  If that happens (such as
breaking Perl-based PGSQL stuff), make rmconfig and rebuild.

Filed as http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/161786 - this
appears related to the GSSAPI option, which seems to have regressed
since the previous 8.4.8* versions, too.  See the PR for more details
please.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org

Re: databases/postgresql84-server 8.4.9 rc.d script broken

2011-10-18 Thread Matthew D. Fuller 
On Wed, Oct 19, 2011 at 11:45:28AM +1100 I heard the voice of
John Marshall, and lo! it spake thus:
 After upgrading databases/postgresql84-server from 8.4.8_1 to 8.4.9, the
 rc.d script vomits thus:

All of them, probably.  The 9.0.x ditto:

postgresql_user=${postgresql_user:-%%PG_USER%%}

Can be worked around locally by putting a postgresql_user=pgsql in
rc.conf.


-- 
Matthew Fuller (MF4839)   |  fulle...@over-yonder.net
Systems/Network Administrator |  http://www.over-yonder.net/~fullermd/
   On the Internet, nobody can hear you scream.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org

Re: databases/postgresql84-server 8.4.9 rc.d script broken

2011-10-18 Thread Jason Helfman 

I just submitted a patch for this. No PR number, yet.

-jgh

On Wed, Oct 19, 2011 at 11:45:28AM +1100, John Marshall thus spake:

After upgrading databases/postgresql84-server from 8.4.8_1 to 8.4.9, the
rc.d script vomits thus:

 rwsrv03# /usr/local/etc/rc.d/postgresql start
 su: unknown login: %%PG_USER%%

Presumably the updated port is missing a substitution edit but I haven't
found where.

--
John Marshall




--
Jason Helfman
System Administrator
experts-exchange.com
http://www.experts-exchange.com/M_4830110.html
E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org

Re: databases/postgresql84-server 8.4.9 rc.d script broken

2011-10-18 Thread Jason Helfman 

http://www.freebsd.org/cgi/query-pr.cgi?pr=161791

-jgh

On Tue, Oct 18, 2011 at 07:56:05PM -0500, Matthew D. Fuller thus spake:

On Wed, Oct 19, 2011 at 11:45:28AM +1100 I heard the voice of
John Marshall, and lo! it spake thus:

After upgrading databases/postgresql84-server from 8.4.8_1 to 8.4.9, the
rc.d script vomits thus:


All of them, probably.  The 9.0.x ditto:

postgresql_user=${postgresql_user:-%%PG_USER%%}

Can be worked around locally by putting a postgresql_user=pgsql in
rc.conf.


--
Matthew Fuller (MF4839)   |  fulle...@over-yonder.net
Systems/Network Administrator |  http://www.over-yonder.net/~fullermd/
  On the Internet, nobody can hear you scream.
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org



--
Jason Helfman
System Administrator
experts-exchange.com
http://www.experts-exchange.com/M_4830110.html
E4AD 7CF1 1396 27F6 79DD  4342 5E92 AD66 8C8C FBA5
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org

Re: databases/postgresql84-server 8.4.9 rc.d script broken

2011-10-18 Thread Greg Larkin 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 10/18/11 8:45 PM, John Marshall wrote:
 After upgrading databases/postgresql84-server from 8.4.8_1 to 8.4.9, the
 rc.d script vomits thus:
 
   rwsrv03# /usr/local/etc/rc.d/postgresql start
   su: unknown login: %%PG_USER%%
 
 Presumably the updated port is missing a substitution edit but I haven't
 found where.
 

Hi John,

Apply this patch to the Makefile and reinstall postgres:

- --
- --- Makefile.orig   2011-10-18 21:07:27.0 -0400
+++ Makefile2011-10-18 21:10:41.0 -0400
@@ -287,13 +287,8 @@
 SUB_FILES+=pkg-message${PKGNAMESUFFIX}
 PKGMESSAGE=${WRKSRC}/pkg-message${PKGNAMESUFFIX}
 .  endif
- -.  if exists(${FILESDIR}/pkg-install${PKGNAMESUFFIX}.in)
- -SUB_FILES+=pkg-install${PKGNAMESUFFIX}
- -SUB_LIST=  PG_GROUP=$(PG_GROUP) \
- -   PG_USER=$(PG_USER) \
- -   PG_UID=$(PG_UID)
+SUB_LIST=  PG_USER=$(PG_USER)
 PLIST_SUB+=PG_USER=$(PG_USER)
- -.  endif
 .endif

 .if !defined(NO_BUILD)
- --

The Makefile depended on the presence of a file that was removed in the
last commit.  Because of that, the substitutions were no longer added to
SUB_LIST.

I'll open a PR tomorrow, if someone doesn't get to it before me.

Hope that helps,
Greg
- -- 
Greg Larkin

http://www.FreeBSD.org/   - The Power To Serve
http://www.sourcehosting.net/ - Ready. Set. Code.
http://twitter.com/cpucycle/  - Follow you, follow me
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6eJOkACgkQ0sRouByUApBxGQCeKBCKeU54O1tM+59bgcDOq4mL
m0UAn0ViZlz8InU+tOYQXkD2QiRVAh0M
=ZNsK
-END PGP SIGNATURE-
___
freebsd-ports@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-ports
To unsubscribe, send any mail to freebsd-ports-unsubscr...@freebsd.org