Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-25 Thread Chris Rees
On 23 Dec 2011 20:14, Christer Edwards christer.edwa...@gmail.com wrote: On Fri, Dec 23, 2011 at 8:09 AM, Greg Larkin glar...@freebsd.org wrote: You get the award for persistence, so pat yourself on the back! That's one way to look at it :) So, I've been double-validating every aspect of

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-23 Thread Chris Rees
On 23 December 2011 02:28, Christer Edwards christer.edwa...@gmail.com wrote: On Thu, Dec 22, 2011 at 7:01 PM, Doug Barton do...@freebsd.org wrote: Try doing s/-/_/ for all the $name variables. I think that's what's causing your problem. I did a little more testing (and I added the Makefile

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-23 Thread Greg Larkin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/23/11 2:55 AM, Christer Edwards wrote: On Fri, Dec 23, 2011 at 12:51 AM, Doug Barton do...@freebsd.org wrote: On 12/22/2011 23:47, Christer Edwards wrote: The pid file does not seem to get created. Ok, so fix it. :) Setting 'pidfile' in

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-23 Thread Christer Edwards
On Fri, Dec 23, 2011 at 8:09 AM, Greg Larkin glar...@freebsd.org wrote: You get the award for persistence, so pat yourself on the back! That's one way to look at it :) So, I've been double-validating every aspect of this port as I want to make sure it's 100% before I submit it, and I ran into

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Christer Edwards
On Thu, Dec 22, 2011 at 5:45 PM, Doug Barton do...@freebsd.org wrote: There are some style problems and one real bug that are repeated for all 3 scripts. I attached a fixed version of one of them, hopefully that will help you see what's needed to fix the other 2. Also, please review

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Greg Larkin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/22/11 8:34 PM, Christer Edwards wrote: On Thu, Dec 22, 2011 at 5:45 PM, Doug Barton do...@freebsd.org wrote: There are some style problems and one real bug that are repeated for all 3 scripts. I attached a fixed version of one of them,

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Doug Barton
On 12/22/2011 17:34, Christer Edwards wrote: On Thu, Dec 22, 2011 at 5:45 PM, Doug Barton do...@freebsd.org wrote: There are some style problems and one real bug that are repeated for all 3 scripts. I attached a fixed version of one of them, hopefully that will help you see what's needed to

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Doug Barton
On 12/22/2011 18:01, Greg Larkin wrote: On 12/22/11 8:34 PM, Christer Edwards wrote: On Thu, Dec 22, 2011 at 5:45 PM, Doug Barton do...@freebsd.org wrote: There are some style problems and one real bug that are repeated for all 3 scripts. I attached a fixed version of one of them, hopefully

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Greg Larkin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/22/11 9:01 PM, Greg Larkin wrote: On 12/22/11 8:34 PM, Christer Edwards wrote: On Thu, Dec 22, 2011 at 5:45 PM, Doug Barton do...@freebsd.org wrote: There are some style problems and one real bug that are repeated for all 3 scripts. I

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Christer Edwards
On Thu, Dec 22, 2011 at 7:01 PM, Doug Barton do...@freebsd.org wrote: Try doing s/-/_/ for all the $name variables. I think that's what's causing your problem. I did a little more testing (and I added the Makefile and .in file suggestions). I can now get it to run consistently if I change $name

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Doug Barton
On 12/22/2011 18:28, Christer Edwards wrote: On Thu, Dec 22, 2011 at 7:01 PM, Doug Barton do...@freebsd.org wrote: Try doing s/-/_/ for all the $name variables. I think that's what's causing your problem. I did a little more testing (and I added the Makefile and .in file suggestions). I can

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Christer Edwards
On Thu, Dec 22, 2011 at 8:12 PM, Doug Barton do...@freebsd.org wrote: You need to pay attention to what Greg told you, and read the Handbook page that I sent. :) OK. I give. I've read that Handbook page a number of times and nothing is jumping out at me. I've been tinkering and testing all

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Doug Barton
On 12/22/2011 23:05, Christer Edwards wrote: On Thu, Dec 22, 2011 at 8:12 PM, Doug Barton do...@freebsd.org wrote: You need to pay attention to what Greg told you, and read the Handbook page that I sent. :) OK. I give. I've read that Handbook page a number of times and nothing is jumping

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Christer Edwards
On Fri, Dec 23, 2011 at 12:11 AM, Doug Barton do...@freebsd.org wrote: Did you read the pre-commit checklist? Particularly item 7? If the script uses an interpreted language like perl, python, or ruby, make certain that command_interpreter is set appropriately. Each rc script includes:

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Doug Barton
On 12/22/2011 23:21, Christer Edwards wrote: On Fri, Dec 23, 2011 at 12:11 AM, Doug Barton do...@freebsd.org wrote: Did you read the pre-commit checklist? Particularly item 7? If the script uses an interpreted language like perl, python, or ruby, make certain that command_interpreter is set

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Christer Edwards
On Fri, Dec 23, 2011 at 12:32 AM, Doug Barton do...@freebsd.org wrote: So now do 'ps axww | grep salt' and confirm that it's really running with python2.7, as opposed to something different. Indeed it is running with python2.7 Here is some ps output before and after starting the rc script:

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Doug Barton
On 12/22/2011 23:40, Christer Edwards wrote: On Fri, Dec 23, 2011 at 12:32 AM, Doug Barton do...@freebsd.org wrote: So now do 'ps axww | grep salt' and confirm that it's really running with python2.7, as opposed to something different. Indeed it is running with python2.7 Ok, does the pid

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Christer Edwards
On Fri, Dec 23, 2011 at 12:43 AM, Doug Barton do...@freebsd.org wrote: On 12/22/2011 23:40, Christer Edwards wrote: On Fri, Dec 23, 2011 at 12:32 AM, Doug Barton do...@freebsd.org wrote: So now do 'ps axww | grep salt' and confirm that it's really running with python2.7, as opposed to

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Doug Barton
On 12/22/2011 23:47, Christer Edwards wrote: The pid file does not seem to get created. Ok, so fix it. :) Setting 'pidfile' in the rc.d script is only useful if the service creates a pid file. It's not magic. Given that the thing seems to create a lot of instances of itself, and one pid may

Re: salt rc.d scripts (Was: RUN_DEPENDS for python based port)

2011-12-22 Thread Christer Edwards
On Fri, Dec 23, 2011 at 12:51 AM, Doug Barton do...@freebsd.org wrote: On 12/22/2011 23:47, Christer Edwards wrote: The pid file does not seem to get created. Ok, so fix it. :)  Setting 'pidfile' in the rc.d script is only useful if the service creates a pid file. It's not magic. Given that