iconv issue (Re: Pan-0.139 won't compile)

2013-03-12 Thread Lowell Gilbert
Walter Hurry walterhu...@gmail.com writes:

 On Tue, 12 Mar 2013 09:40:40 -0400, Lowell Gilbert wrote:

 Walter Hurry walterhu...@gmail.com writes:
 
 Trying to upgrade /usr/ports/news/pan I get this:
 ___
 mime-utils.cc: In function 'char* pan::__g_mime_iconv_strndup(void*,
 const char*, size_t, const char*)':
 mime-utils.cc:80: error: invalid conversion from 'char**' to 'const
 char**'
 mime-utils.cc:80: error:   initializing argument 2 of 'size_t libiconv
 (void*, const char**, size_t*, char**, size_t*)'
 gmake[3]: *** [mime-utils.o] Error 1 gmake[3]: Leaving directory
 `/usr/ports/news/pan/work/pan-0.139/pan/ usenet-utils'
 gmake[2]: *** [all-recursive] Error 1 gmake[2]: Leaving directory
 `/usr/ports/news/pan/work/pan-0.139/pan' gmake[1]: *** [all-recursive]
 Error 1 gmake[1]: Leaving directory
 `/usr/ports/news/pan/work/pan-0.139' gmake: *** [all] Error 2 ***
 [do-build] Error code 1

 Stop in /usr/ports/news/pan.
 *** [build] Error code 1
 ___

 What should I do next?
 
 Hmm. Interesting; looks like a compiler issue (the error strikes me as
 likely bogus). What compiler were you using?

 Well, this is 9.1-RELEASE on amd64, and I'm using the default, which I 
 believe is the cc1plus in gcc-4.2.1

On closer look, the error isn't bogus, but looks like it results from an
unnecessary pair of type casts. There's nothing in the autotools setups
about iconv, nor are there any patches in the port, so I'm not seeing an
obvious candidate for why this broke. 

My guess would be that this works if built with the base iconv, because
the test builds must have worked. That is not guaranteed, because the port
changes were both updating the version of pan and updating glib/gtk
updates as part of a wider set of updates. 

I'll put in a PR, because I won't have a chance to look more at this
today. 

Be well.
___
freebsd-questions@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-questions
To unsubscribe, send any mail to freebsd-questions-unsubscr...@freebsd.org


Re: iconv issue (Re: Pan-0.139 won't compile)

2013-03-12 Thread Lowell Gilbert
Lowell Gilbert freebsd-questions-lo...@be-well.ilk.org writes:

 I'll put in a PR, because I won't have a chance to look more at this
 today. 

ports/176887
___
freebsd-questions@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-questions
To unsubscribe, send any mail to freebsd-questions-unsubscr...@freebsd.org


Re: iconv issue (Re: Pan-0.139 won't compile)

2013-03-12 Thread Lowell Gilbert
And it's already been fixed.
___
freebsd-questions@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-questions
To unsubscribe, send any mail to freebsd-questions-unsubscr...@freebsd.org


Re: iconv issue (Re: Pan-0.139 won't compile)

2013-03-12 Thread Walter Hurry
On Tue, 12 Mar 2013 15:50:10 -0400, Lowell Gilbert wrote:

 And it's already been fixed.

Well done, and thanks!

If you look at my headers, you'll see I'm using it now.


___
freebsd-questions@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-questions
To unsubscribe, send any mail to freebsd-questions-unsubscr...@freebsd.org