Re: How to donate code
Le Wed, 18 Jul 2012 12:53:00 +0300, Виталий Туровец core...@corebug.net a écrit : Hello, The general advice is mail the patch to -hackers for review. If you don't get a reply or if people like it, submit a PR so it doesn't get lost. Be aware that the latency for some patches could be longer than you expect. :( I already realize that :( The secret is to not expect anything :) FWIW unified diff format patches are much preferred. (diff -u) Okay, i'll rewrite this code under -current OS build and mail the unified diff patch to -hackers list. I remember vaguely a thread on hacker@ about ifconfig and netmask, you may want to check it : http://unix.derkeiler.com/Mailing-Lists/FreeBSD/hackers/2011-04/msg00078.html (IPV4 non-CIDR netmasks are valid). ___ freebsd-questions@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-questions To unsubscribe, send any mail to freebsd-questions-unsubscr...@freebsd.org
Re: How to donate code
2012/7/19 Patrick Lamaiziere patf...@davenulle.org: Le Wed, 18 Jul 2012 12:53:00 +0300, Виталий Туровец core...@corebug.net a écrit : Hello, The general advice is mail the patch to -hackers for review. If you don't get a reply or if people like it, submit a PR so it doesn't get lost. Be aware that the latency for some patches could be longer than you expect. :( I already realize that :( The secret is to not expect anything :) FWIW unified diff format patches are much preferred. (diff -u) Okay, i'll rewrite this code under -current OS build and mail the unified diff patch to -hackers list. I remember vaguely a thread on hacker@ about ifconfig and netmask, you may want to check it : http://unix.derkeiler.com/Mailing-Lists/FreeBSD/hackers/2011-04/msg00078.html (IPV4 non-CIDR netmasks are valid). The thread you mentioned was about dotted decimal notation and i'm trying to add !CIDR! notation e.g. 1.1.1.1/32 :) -- ~~~ WBR, Vitaliy Turovets Systems Administrator Corebug.Net +38(093)265-70-55 VITU-RIPE X-NCC-RegID: ua.tv ___ freebsd-questions@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-questions To unsubscribe, send any mail to freebsd-questions-unsubscr...@freebsd.org
Re: How to donate code
2012/7/18 Eitan Adler li...@eitanadler.com: On 17 July 2012 02:16, Виталий Туровец core...@corebug.net wrote: Hello, colleagues! How would one propose some code to current branch? I've made a little change to ifconfig ( a switch to display IPv4 network masks in CIDR format instead of HEX) and want to suggest this change to FreeBSD project. Also i've created a PR with my patch describing what is done and for what (http://www.freebsd.org/cgi/query-pr.cgi?pr=169072cat=), but maybe there's some other way to somehow push this code for review by FreeBSD developers? Thank you a lot and sorry for noobish question :) The general advice is mail the patch to -hackers for review. If you don't get a reply or if people like it, submit a PR so it doesn't get lost. Be aware that the latency for some patches could be longer than you expect. :( I already realize that :( FWIW unified diff format patches are much preferred. (diff -u) Okay, i'll rewrite this code under -current OS build and mail the unified diff patch to -hackers list. Thank you all people! -- Eitan Adler -- ~~~ WBR, Vitaliy Turovets Systems Administrator Corebug.Net +38(093)265-70-55 VITU-RIPE X-NCC-RegID: ua.tv ___ freebsd-questions@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-questions To unsubscribe, send any mail to freebsd-questions-unsubscr...@freebsd.org
Re: How to donate code
Le Tue, 17 Jul 2012 12:16:12 +0300, Виталий Туровец core...@corebug.net a écrit : Hello, Hello, colleagues! How would one propose some code to current branch? I've made a little change to ifconfig ( a switch to display IPv4 network masks in CIDR format instead of HEX) and want to suggest this change to FreeBSD project. Also i've created a PR with my patch describing what is done and for what (http://www.freebsd.org/cgi/query-pr.cgi?pr=169072cat=), but maybe there's some other way to somehow push this code for review by FreeBSD developers? You may post to freebsd-current@ or freebsd-hacker@ mailing lists. A PR is always a good thing for the record. Regards. ___ freebsd-questions@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-questions To unsubscribe, send any mail to freebsd-questions-unsubscr...@freebsd.org
Re: How to donate code
On 17 July 2012 02:16, Виталий Туровец core...@corebug.net wrote: Hello, colleagues! How would one propose some code to current branch? I've made a little change to ifconfig ( a switch to display IPv4 network masks in CIDR format instead of HEX) and want to suggest this change to FreeBSD project. Also i've created a PR with my patch describing what is done and for what (http://www.freebsd.org/cgi/query-pr.cgi?pr=169072cat=), but maybe there's some other way to somehow push this code for review by FreeBSD developers? Thank you a lot and sorry for noobish question :) The general advice is mail the patch to -hackers for review. If you don't get a reply or if people like it, submit a PR so it doesn't get lost. Be aware that the latency for some patches could be longer than you expect. :( FWIW unified diff format patches are much preferred. (diff -u) -- Eitan Adler ___ freebsd-questions@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-questions To unsubscribe, send any mail to freebsd-questions-unsubscr...@freebsd.org
